29d49d9
URL: <https://sourceware.org/ml/gdb-patches/2013-05/msg00364.html>
29d49d9
Message-ID: <1368136582.30058.7.camel@soleil>
29d49d9
29d49d9
  From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
29d49d9
  To: gdb-patches at sourceware dot org
29d49d9
  Subject: RFA: fix gdb_assert caused by 'catch signal ...' and fork
29d49d9
  Date: Thu, 09 May 2013 23:56:22 +0200
29d49d9
29d49d9
  The attached patch fixes a gdb_assert caused by the combination of catch
29d49d9
  signal and fork:
29d49d9
    break-catch-sig.c:152: internal-error: signal_catchpoint_remove_location: Assertion `signal_catch_counts[iter] > 0' failed.
29d49d9
29d49d9
  The problem is that the signal_catch_counts is decremented by detach_breakpoints.
29d49d9
  The fix consists in not detaching breakpoint locations of type bp_loc_other.
29d49d9
  The patch introduces a new test.
29d49d9
29d49d9
Comments by Sergio Durigan Junior:
29d49d9
29d49d9
  I addded a specific testcase for this patch, which tests exactly the
29d49d9
  issue that the customer is facing.  This patch does not solve the
29d49d9
  whole problem of catching a syscall and forking (for more details,
29d49d9
  see <https://sourceware.org/bugzilla/show_bug.cgi?id=13457>,
29d49d9
  specifically comment #3), but it solves the issue reported by the
29d49d9
  customer.
29d49d9
29d49d9
  I also removed the original testcase of this patch, because it
29d49d9
  relied on "catch signal", which is a command that is not implemented
29d49d9
  in this version of GDB.
29d49d9
29d49d9
commit bd9673a4ded96ea5c108601501c8e59003ea1be6
29d49d9
Author: Philippe Waroquiers <philippe@sourceware.org>
29d49d9
Date:   Tue May 21 18:47:05 2013 +0000
29d49d9
29d49d9
    Fix internal error caused by interaction between catch signal and fork
29d49d9
29d49d9
Index: gdb-7.12/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
29d49d9
===================================================================
29d49d9
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
29d49d9
+++ gdb-7.12/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c	2016-10-20 21:03:09.584272695 +0200
29d49d9
@@ -0,0 +1,11 @@
29d49d9
+#include <stdio.h>
29d49d9
+#include <unistd.h>
29d49d9
+
29d49d9
+int
29d49d9
+main (int argc, char **argv)
29d49d9
+{
29d49d9
+  if (fork () == 0)
29d49d9
+    sleep (1);
29d49d9
+  chdir (".");
29d49d9
+  return 0;
29d49d9
+}
29d49d9
Index: gdb-7.12/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
29d49d9
===================================================================
29d49d9
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
29d49d9
+++ gdb-7.12/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp	2016-10-20 21:04:13.337771174 +0200
29d49d9
@@ -0,0 +1,58 @@
29d49d9
+# Copyright 2015 Free Software Foundation, Inc.
29d49d9
+
29d49d9
+# This program is free software; you can redistribute it and/or modify
29d49d9
+# it under the terms of the GNU General Public License as published by
29d49d9
+# the Free Software Foundation; either version 3 of the License, or
29d49d9
+# (at your option) any later version.
29d49d9
+#
29d49d9
+# This program is distributed in the hope that it will be useful,
29d49d9
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
29d49d9
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
29d49d9
+# GNU General Public License for more details.
29d49d9
+#
29d49d9
+# You should have received a copy of the GNU General Public License
29d49d9
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
29d49d9
+
29d49d9
+if { [is_remote target] || ![isnative] } then {
29d49d9
+    continue
29d49d9
+}
29d49d9
+
29d49d9
+set testfile "gdb-rhbz1149205-catch-syscall-fork"
29d49d9
+set srcfile ${testfile}.c
29d49d9
+set binfile [standard_output_file ${testfile}]
29d49d9
+
29d49d9
+# Until "catch syscall" is implemented on other targets...
29d49d9
+if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
29d49d9
+    continue
29d49d9
+}
29d49d9
+
29d49d9
+# This shall be updated whenever 'catch syscall' is implemented
29d49d9
+# on some architecture.
29d49d9
+#if { ![istarget "i\[34567\]86-*-linux*"]
29d49d9
+if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
29d49d9
+     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
29d49d9
+     && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
29d49d9
+     continue
29d49d9
+}
29d49d9
+
29d49d9
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
29d49d9
+    untested ${testfile}.exp
29d49d9
+    return -1
29d49d9
+}
29d49d9
+
29d49d9
+gdb_exit
29d49d9
+gdb_start
29d49d9
+gdb_reinitialize_dir $srcdir/$subdir
29d49d9
+gdb_load $binfile
29d49d9
+
29d49d9
+if { ![runto_main] } {
29d49d9
+    return -1
29d49d9
+}
29d49d9
+
29d49d9
+gdb_test "catch syscall chdir" \
29d49d9
+  "Catchpoint $decimal \\\(syscall (.)?chdir(.)? \\\[$decimal\\\]\\\)" \
29d49d9
+  "catch syscall chdir"
29d49d9
+
29d49d9
+gdb_test "continue" \
29d49d9
+  "Continuing\.\r\n.*\r\nCatchpoint $decimal \\\(call to syscall .?chdir.?.*" \
29d49d9
+  "continue from catch syscall after fork"