Blob Blame History Raw
Subject: [patch] gdb_assert -> complaint for weird DWARF

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


PR 16581:
	GDB crash on inherit_abstract_dies infinite recursion

fixed crash from an infinite recursion.  But in rare cases the new code can
now gdb_assert() due to weird DWARF file.

I do not yet fully understand why the DWARF is as it is but just GDB should
never crash due to invalid DWARF anyway.  The "invalid" DWARF I see only in
Fedora GCC build, not in FSF GCC build, more info at:


Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline; filename="complaint.patch"

2014-02-24  Jan Kratochvil  <>

	* dwarf2read.c (process_die): Change gdb_assert to complaint.

Index: gdb-
--- gdb-	2017-04-20 23:15:26.578897210 +0200
+++ gdb-	2017-04-20 23:15:57.805106371 +0200
@@ -8426,7 +8426,13 @@
   struct cleanup *in_process;
   /* We should only be processing those not already in process.  */
-  gdb_assert (!die->in_process);
+  if (die->in_process)
+    {
+      complaint (&symfile_complaints,
+		 _("DIE at 0x%x attempted to be processed twice"),
+		 to_underlying (die->sect_off));
+      return;
+    }
   die->in_process = 1;
   in_process = make_cleanup (reset_die_in_process,die);