From df63b36b2b4d7b1ba164389627be0bac016ae384 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Aug 19 2010 09:02:00 +0000 Subject: - Fix crash on MI variable calling inferior function (BZ 610986). --- diff --git a/gdb-upstream.patch b/gdb-upstream.patch index b643ad6..86b9fc0 100644 --- a/gdb-upstream.patch +++ b/gdb-upstream.patch @@ -1177,3 +1177,52 @@ http://sourceware.org/ml/gdb-cvs/2010-05/msg00255.html } cleanup (); + + + +https://bugzilla.redhat.com/show_bug.cgi?id=610986 +http://sourceware.org/ml/gdb-cvs/2010-08/msg00112.html + +### src/gdb/ChangeLog 2010/08/18 22:57:45 1.12097 +### src/gdb/ChangeLog 2010/08/19 07:34:26 1.12098 +## -1,3 +1,9 @@ ++2010-08-19 Jan Kratochvil ++ ++ * varobj.c (varobj_create): Replace variable old_fi with old_id, ++ initialize it by null_frame_id, wrap its usage by get_frame_id, ++ frame_id_p and frame_find_by_id. ++ + 2010-08-18 Tom Tromey + + PR python/11900: +--- src/gdb/varobj.c 2010/08/06 14:17:56 1.159 ++++ src/gdb/varobj.c 2010/08/19 07:34:27 1.160 +@@ -524,7 +524,7 @@ varobj_create (char *objname, + { + struct varobj *var; + struct frame_info *fi; +- struct frame_info *old_fi = NULL; ++ struct frame_id old_id = null_frame_id; + struct block *block; + struct cleanup *old_chain; + +@@ -611,7 +611,7 @@ + + var->root->frame = get_frame_id (fi); + var->root->thread_id = pid_to_thread_id (inferior_ptid); +- old_fi = get_selected_frame (NULL); ++ old_id = get_frame_id (get_selected_frame (NULL)); + select_frame (fi); + } + +@@ -639,8 +639,8 @@ + var->root->rootvar = var; + + /* Reset the selected frame */ +- if (old_fi != NULL) +- select_frame (old_fi); ++ if (frame_id_p (old_id)) ++ select_frame (frame_find_by_id (old_id)); + } + + /* If the variable object name is null, that means this diff --git a/gdb.spec b/gdb.spec index b6771b7..e386ce9 100644 --- a/gdb.spec +++ b/gdb.spec @@ -36,7 +36,7 @@ Version: 7.1 # The release always contains a leading reserved number, start it at 1. # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing. -Release: 32%{?_with_upstream:.upstream}%{dist} +Release: 33%{?_with_upstream:.upstream}%{dist} License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and GFDL and BSD and Public Domain Group: Development/Debuggers @@ -1181,6 +1181,9 @@ fi %endif %changelog +* Thu Aug 19 2010 Jan Kratochvil - 7.1-33.fc13 +- Fix crash on MI variable calling inferior function (BZ 610986). + * Fri Aug 6 2010 Jan Kratochvil - 7.1-32.fc13 - Fix GDB regression for starting on r/o filesystem (BZ 602644).