#4 [RFC] require git-core rather than git to reduce dependencies
Closed 3 years ago by pstodulk. Opened 3 years ago by tmz.
rpms/ tmz/git-remote-hg require-git-core-not-git  into  master

file modified
+1
@@ -2,3 +2,4 @@ 

  /git-remote-hg-0.3.tar.gz

  /git-remote-hg-0.4.tar.gz

  /git-remote-hg-1.0.0.tar.gz

+ /git-remote-hg-1.0.2.1.tar.gz

file modified
+17 -7
@@ -1,7 +1,7 @@ 

  %global debug_package %{nil}

  Name:           git-remote-hg

- Version:        1.0.0

- Release:        6%{?dist}

+ Version:        1.0.2.1

+ Release:        2%{?dist}

  BuildArch:      noarch

  Summary:        Mercurial wrapper for git

  License:        GPLv2+
@@ -13,10 +13,11 @@ 

  # The second commit (to the tests) isn't needed against 0.2

  

  BuildRequires:  asciidoc >= 8.4.1

- BuildRequires:  python2-devel

- Requires:       python2

- Requires:       git >= 2.0.0

- Requires:       mercurial >= 3.5

+ BuildRequires:  python3-devel

+ Requires:       python3

+ Requires:       git-core >= 2.0.0

+ Requires:       mercurial >= 5.4

+ Requires:       mercurial-py3

  Obsoletes:      git-hg

  

  %description
@@ -27,7 +28,7 @@ 

  %prep

  %setup -q

  #%patch01 -p1

- sed -i -e "1 s|^#!.*|#!%{__python2}|" git-remote-hg

+ sed -i -e "1 s|^#!.*|#!%{__python3}|" git-remote-hg

  sed -i -e 's|\tinstall|\tinstall -p|' Makefile

  

  %build
@@ -48,6 +49,15 @@ 

  %{_mandir}/man1/*

  

  %changelog

+ * Thu Nov 26 2020 Todd Zullinger <tmz@pobox.com> - 1.0.2.1-2

+ - require git-core rather than git to reduce dependencies

+ 

+ * Mon Nov 23 2020 Petr Stodulka <pstodulk@redhat.com> - 1.0.2.1-1

+ - Rebase to 1.0.2.1

+ - Transfer to Python3

+ - Requires Mercurial v5.4+ for Python3 (mercurial-py3)

+ - Resolves: rhbz#1738965, rhbz#1893525

+ 

  * Mon Jul 27 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.0.0-6

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild

  

file modified
+1 -1
@@ -1,1 +1,1 @@ 

- SHA512 (git-remote-hg-1.0.0.tar.gz) = 344349b8c64db5ad629176c664713773b4e8fe5ddf6bd13e7f3cac421f82eeb93fdd8aa59a2baab4b36b533cd6721adf8d31c69d4cc761e43c093c4d531c1a7d

+ SHA512 (git-remote-hg-1.0.2.1.tar.gz) = 722de4946e12fbeed40303682406455fcad347f718ac2f849982e6beaba263e434065ed44318aa9676431214ddd059ac917fe744c468f8388381fa2829183dcb

Nothing in git-remote-hg appears to require the tools from git rather than git-core. Avoid pulling in the extra dependencies of git.

I noticed the git requirement while testing a fix for a git fast-import bug (rhbz#1900335). Installing git-remote-hg in a container pulled in many more deps than it needed. I tested the git-remote-hg-1.0.0 release with only git-core as a dep by cloning https://hg.mozilla.org/projects/nss.

But I also noticed the package was a few revisions behind, so I didn't think I'd file a PR. Fortuitously, Villy pointed me to PR#3 which updates to the latest release and moves to python3. I built on top of that, which is one reason why I marked this as RFC. That PR should be merged before this one, obviously. :)

I will apply this change automatically as part of the #3 PR. Thanks for your help!

Pull-Request has been closed by pstodulk

3 years ago