PR#3: enable non-minimal build again - rpms/glassfish-jaxb

rpms / glassfish-jaxb

#3 enable non-minimal build again

Merged 3 years ago by ankursinha. Opened 3 years ago by decathorpe.

Unknown source master into master

enable non-minimal build again

Fabio Valentini • 3 years ago

23844bd

glassfish-jaxb.spec

file modified

+5 -2

		`@@ -1,9 +1,9 @@`
		`# Conditionally build with a minimal dependency set`
		`- %bcond_without jp_minimal`
		`+ %bcond_with jp_minimal`

		`Name: glassfish-jaxb`
		`Version: 2.2.11`
		`- Release: 17%{?dist}`
		`+ Release: 18%{?dist}`
		`Summary: JAXB Reference Implementation`

		`License: CDDL-1.1 and GPLv2 with exceptions`
		`@@ -312,6 +312,9 @@`


		`%changelog`
		`+ * Mon May 11 2020 Fabio Valentini <decathorpe@gmail.com> - 2.2.11-18`
		`+ - Enable non-minimal build again.`
		`+`
		`* Sat Apr 18 2020 Fabio Valentini <decathorpe@gmail.com> - 2.2.11-17`
		`- Build with reduced functionality and dependencies.`

decathorpe commented 3 years ago

always build with full functionality (needed by neuro-sig)
simplify packaging (no more conditionals)
regenerate BuildRequires with xmvn-builddep
add a few clarifying comments

churchyard commented 3 years ago

always build with full functionality again

What is the rationale?

ankursinha commented 3 years ago

Unfortunately, some of the bits are required for other packages:

https://pagure.io/stewardship-sig/issue/85

decathorpe commented 3 years ago

Yep. The neuro-sig needs jaxb2-maven-plugin, which needs most of the subpackages we previously removed.

I also simplified the packaging a bit in preparation for updating it to a newer release soon.
I've started working on getting newer versions packaged, and most of the ancient gunk this version references has been dropped upstream.

mbooth commented 3 years ago

Hmm, I'd rather you didn't remove the jp_minimal sections :-(

decathorpe commented 3 years ago

@mbooth I can add them in again, though I always find %bcond_without jp_minimal a bit confusing (triple negation?) ... do you need that bcond? At least in fedora we will need those packages for the foreseeable future

rebased onto 23844bd

3 years ago

decathorpe commented 3 years ago

Rebased, dropped the "cleanup" part.

ankursinha commented 3 years ago

Thanks @decathorpe. This looks ready for merging?

decathorpe commented 3 years ago

@ankursinha It is, from my point of view. Do you want me to push the button?

@churchyard I plan to move dependencies that are orphaned right now to java-maint-sig, not pick them up for the Stewardship SIG again, don't worry :)