da63b57
2014-08-21  Florian Weimer  <fweimer@redhat.com>
da63b57
da63b57
	[BZ #17187]
da63b57
	* iconv/gconv_trans.c (struct known_trans, search_tree, lock,
da63b57
	trans_compare, open_translit, __gconv_translit_find):
da63b57
	Remove module loading code.
da63b57
da63b57
diff --git a/iconv/gconv_trans.c b/iconv/gconv_trans.c
da63b57
index 1e25854..d71c029 100644
da63b57
--- a/iconv/gconv_trans.c
da63b57
+++ b/iconv/gconv_trans.c
da63b57
@@ -238,181 +238,11 @@ __gconv_transliterate (struct __gconv_step *step,
da63b57
   return __GCONV_ILLEGAL_INPUT;
da63b57
 }
da63b57
 
da63b57
-
da63b57
-/* Structure to represent results of found (or not) transliteration
da63b57
-   modules.  */
da63b57
-struct known_trans
da63b57
-{
da63b57
-  /* This structure must remain the first member.  */
da63b57
-  struct trans_struct info;
da63b57
-
da63b57
-  char *fname;
da63b57
-  void *handle;
da63b57
-  int open_count;
da63b57
-};
da63b57
-
da63b57
-
da63b57
-/* Tree with results of previous calls to __gconv_translit_find.  */
da63b57
-static void *search_tree;
da63b57
-
da63b57
-/* We modify global data.   */
da63b57
-__libc_lock_define_initialized (static, lock);
da63b57
-
da63b57
-
da63b57
-/* Compare two transliteration entries.  */
da63b57
-static int
da63b57
-trans_compare (const void *p1, const void *p2)
da63b57
-{
da63b57
-  const struct known_trans *s1 = (const struct known_trans *) p1;
da63b57
-  const struct known_trans *s2 = (const struct known_trans *) p2;
da63b57
-
da63b57
-  return strcmp (s1->info.name, s2->info.name);
da63b57
-}
da63b57
-
da63b57
-
da63b57
-/* Open (maybe reopen) the module named in the struct.  Get the function
da63b57
-   and data structure pointers we need.  */
da63b57
-static int
da63b57
-open_translit (struct known_trans *trans)
da63b57
-{
da63b57
-  __gconv_trans_query_fct queryfct;
da63b57
-
da63b57
-  trans->handle = __libc_dlopen (trans->fname);
da63b57
-  if (trans->handle == NULL)
da63b57
-    /* Not available.  */
da63b57
-    return 1;
da63b57
-
da63b57
-  /* Find the required symbol.  */
da63b57
-  queryfct = __libc_dlsym (trans->handle, "gconv_trans_context");
da63b57
-  if (queryfct == NULL)
da63b57
-    {
da63b57
-      /* We cannot live with that.  */
da63b57
-    close_and_out:
da63b57
-      __libc_dlclose (trans->handle);
da63b57
-      trans->handle = NULL;
da63b57
-      return 1;
da63b57
-    }
da63b57
-
da63b57
-  /* Get the context.  */
da63b57
-  if (queryfct (trans->info.name, &trans->info.csnames, &trans->info.ncsnames)
da63b57
-      != 0)
da63b57
-    goto close_and_out;
da63b57
-
da63b57
-  /* Of course we also have to have the actual function.  */
da63b57
-  trans->info.trans_fct = __libc_dlsym (trans->handle, "gconv_trans");
da63b57
-  if (trans->info.trans_fct == NULL)
da63b57
-    goto close_and_out;
da63b57
-
da63b57
-  /* Now the optional functions.  */
da63b57
-  trans->info.trans_init_fct =
da63b57
-    __libc_dlsym (trans->handle, "gconv_trans_init");
da63b57
-  trans->info.trans_context_fct =
da63b57
-    __libc_dlsym (trans->handle, "gconv_trans_context");
da63b57
-  trans->info.trans_end_fct =
da63b57
-    __libc_dlsym (trans->handle, "gconv_trans_end");
da63b57
-
da63b57
-  trans->open_count = 1;
da63b57
-
da63b57
-  return 0;
da63b57
-}
da63b57
-
da63b57
-
da63b57
 int
da63b57
 internal_function
da63b57
 __gconv_translit_find (struct trans_struct *trans)
da63b57
 {
da63b57
-  struct known_trans **found;
da63b57
-  const struct path_elem *runp;
da63b57
-  int res = 1;
da63b57
-
da63b57
-  /* We have to have a name.  */
da63b57
-  assert (trans->name != NULL);
da63b57
-
da63b57
-  /* Acquire the lock.  */
da63b57
-  __libc_lock_lock (lock);
da63b57
-
da63b57
-  /* See whether we know this module already.  */
da63b57
-  found = __tfind (trans, &search_tree, trans_compare);
da63b57
-  if (found != NULL)
da63b57
-    {
da63b57
-      /* Is this module available?  */
da63b57
-      if ((*found)->handle != NULL)
da63b57
-	{
da63b57
-	  /* Maybe we have to reopen the file.  */
da63b57
-	  if ((*found)->handle != (void *) -1)
da63b57
-	    /* The object is not unloaded.  */
da63b57
-	    res = 0;
da63b57
-	  else if (open_translit (*found) == 0)
da63b57
-	    {
da63b57
-	      /* Copy the data.  */
da63b57
-	      *trans = (*found)->info;
da63b57
-	      (*found)->open_count++;
da63b57
-	      res = 0;
da63b57
-	    }
da63b57
-	}
da63b57
-    }
da63b57
-  else
da63b57
-    {
da63b57
-      size_t name_len = strlen (trans->name) + 1;
da63b57
-      int need_so = 0;
da63b57
-      struct known_trans *newp;
da63b57
-
da63b57
-      /* We have to continue looking for the module.  */
da63b57
-      if (__gconv_path_elem == NULL)
da63b57
-	__gconv_get_path ();
da63b57
-
da63b57
-      /* See whether we have to append .so.  */
da63b57
-      if (name_len <= 4 || memcmp (&trans->name[name_len - 4], ".so", 3) != 0)
da63b57
-	need_so = 1;
da63b57
-
da63b57
-      /* Create a new entry.  */
da63b57
-      newp = (struct known_trans *) malloc (sizeof (struct known_trans)
da63b57
-					    + (__gconv_max_path_elem_len
da63b57
-					       + name_len + 3)
da63b57
-					    + name_len);
da63b57
-      if (newp != NULL)
da63b57
-	{
da63b57
-	  char *cp;
da63b57
-
da63b57
-	  /* Clear the struct.  */
da63b57
-	  memset (newp, '\0', sizeof (struct known_trans));
da63b57
-
da63b57
-	  /* Store a copy of the module name.  */
da63b57
-	  newp->info.name = cp = (char *) (newp + 1);
da63b57
-	  cp = __mempcpy (cp, trans->name, name_len);
da63b57
-
da63b57
-	  newp->fname = cp;
da63b57
-
da63b57
-	  /* Search in all the directories.  */
da63b57
-	  for (runp = __gconv_path_elem; runp->name != NULL; ++runp)
da63b57
-	    {
da63b57
-	      cp = __mempcpy (__stpcpy ((char *) newp->fname, runp->name),
da63b57
-			      trans->name, name_len);
da63b57
-	      if (need_so)
da63b57
-		memcpy (cp, ".so", sizeof (".so"));
da63b57
-
da63b57
-	      if (open_translit (newp) == 0)
da63b57
-		{
da63b57
-		  /* We found a module.  */
da63b57
-		  res = 0;
da63b57
-		  break;
da63b57
-		}
da63b57
-	    }
da63b57
-
da63b57
-	  if (res)
da63b57
-	    newp->fname = NULL;
da63b57
-
da63b57
-	  /* In any case we'll add the entry to our search tree.  */
da63b57
-	  if (__tsearch (newp, &search_tree, trans_compare) == NULL)
da63b57
-	    {
da63b57
-	      /* Yickes, this should not happen.  Unload the object.  */
da63b57
-	      res = 1;
da63b57
-	      /* XXX unload here.  */
da63b57
-	    }
da63b57
-	}
da63b57
-    }
da63b57
-
da63b57
-  __libc_lock_unlock (lock);
da63b57
-
da63b57
-  return res;
da63b57
+  /* This function always fails.  Transliteration module loading is
da63b57
+     not implemented.  */
da63b57
+  return 1;
da63b57
 }
da63b57
-- 
da63b57
1.9.3
da63b57