rpms / gnome-shell

Clone
Source Code
GIT

#13 Mark bundled provides
Merged 11 months ago by fmuellner. Opened 11 months ago by fmuellner.
rpms/ fmuellner/gnome-shell bundled-provides  into  rawhide

Mark bundled provides
Florian Müllner • 11 months ago  
3b5b7ff
file modified
+2 
@@ -132,6 +132,8 @@ 
 

  

  Provides:       desktop-notification-daemon = %{version}-%{release}
 

  Provides:       PolicyKit-authentication-agent = %{version}-%{release}
 

+ Provides:       bundled(gvc)
 

+ Provides:       bundled(libcroco) = 0.6.13
 

  

  %if 0%{?rhel}
 

  # In Fedora, fedora-obsolete-packages obsoletes caribou

See commit.

@jadahl @catanzaro @tpopela I'm not entire sure that those bundles are correct or complete, so any feedback would be welcome :-)

I though that libcroco was completely removed and retired https://src.fedoraproject.org/rpms/libcroco - so Shell is bundling it? Just to be sure.

I though that libcroco was completely removed and retired https://src.fedoraproject.org/rpms/libcroco - so Shell is bundling it? Just to be sure.

The dependency was replaced by an in-tree fork:

https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/47758d16ff0acd9edbd8ff6eb3922e59fb14f8bb

My understanding was that this still qualifies as bundling.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

I had assumed the bundled version was the one that was bundled, which is what I just did here: https://src.fedoraproject.org/rpms/mutter/c/d818ad168432c391d185dfc649fe4b442c975ff5?branch=rawhide

Is that not what is expected? So that e.g. some bug on bundled-package-ORIGINAL.VERSION fixed in that gets ported over correctly?

I had assumed the bundled version was the one that was bundled, which is what I just did here: https://src.fedoraproject.org/rpms/mutter/c/d818ad168432c391d185dfc649fe4b442c975ff5?branch=rawhide

Is that not what is expected? So that e.g. some bug on bundled-package-ORIGINAL.VERSION fixed in that gets ported over correctly?

Yes, you want to set the version equal to the version you forked from, that way Product Security knows it needs to assume the bundled version is vulnerable to anything fixed upstream since then. So that's what I would do for libcroco.

For projects that are not system libraries and have no meaningful version -- perhaps GVC? -- the version can just be omitted. It's not meant to be set equal to the gnome-shell package version.

rebased onto 3b5b7ff
11 months ago

So that's what I would do for libcroco.

Done.

For projects that are not system libraries and have no meaningful version -- perhaps GVC? -- the version can just be omitted.

GVC is explicitly unversioned, so omitting it is.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Pull-Request has been merged by fmuellner
11 months ago
Metadata
None
No Tags
Changes Summary 1
+2 -0
file changed
gnome-shell.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.