From e2824de3fc3696dd14752501f15c484a3b398ff8 Mon Sep 17 00:00:00 2001 From: Egmont Koblinger Date: Wed, 28 May 2014 12:16:41 +0200 Subject: [PATCH] app: Don't change the title on tab labels that no longer exist This fixes a potential crash when a tab is moved to another window, and later the title of that terminal changes. https://bugzilla.gnome.org/show_bug.cgi?id=730389 (cherry picked from commit 6c1ece7dab2a11b7e0c6561f89cf83510abb51bf) --- src/terminal-tab-label.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/terminal-tab-label.c b/src/terminal-tab-label.c index 90bab28..eb2f81d 100644 --- a/src/terminal-tab-label.c +++ b/src/terminal-tab-label.c @@ -212,8 +212,11 @@ terminal_tab_label_constructor (GType type, static void terminal_tab_label_finalize (GObject *object) { -// TerminalTabLabel *tab_label = TERMINAL_TAB_LABEL (object); + TerminalTabLabel *tab_label = TERMINAL_TAB_LABEL (object); + g_signal_handlers_disconnect_by_func (tab_label->priv->screen, + G_CALLBACK (sync_tab_label), + tab_label->priv->label); G_OBJECT_CLASS (terminal_tab_label_parent_class)->finalize (object); } -- 1.9.3