PR#1: Add "on Xorg" to session names - rpms/gnome-valgrind-session

rpms / gnome-valgrind-session

#1 Add "on Xorg" to session names

Closed 4 months ago by rishi. Opened 4 months ago by ferdnyc.

rpms/ ferdnyc/gnome-valgrind-session rename-sessions into rawhide

Add "on Xorg" to session names

FeRD (Frank Dana) • 4 months ago

3400ef9

gnome-valgrind-session-1.1-add-xorg-label.patch

file added

+35

		`@@ -0,0 +1,35 @@`
		`+ From b130ca140a1b3aa3a464cd4b7a757582eeb63ead Mon Sep 17 00:00:00 2001`
		`+ From: "FeRD (Frank Dana)" <ferdnyc@gmail.com>`
		`+ Date: Wed, 10 May 2023 15:12:29 -0400`
		`+ Subject: [PATCH] Add "on Xorg" to session names`
		`+`
		`+ ---`
		`+ gnome-valgrind-errors.desktop \| 2 +-`
		`+ gnome-valgrind-leaks.desktop \| 2 +-`
		`+ 2 files changed, 2 insertions(+), 2 deletions(-)`
		`+`
		`+ diff --git a/gnome-valgrind-errors.desktop b/gnome-valgrind-errors.desktop`
		`+ index 1d54301..4fc7d3f 100644`
		`+ --- a/gnome-valgrind-errors.desktop`
		`+ +++ b/gnome-valgrind-errors.desktop`
		`+ @@ -2,5 +2,5 @@`
		`+ Type=Application`
		`+ Exec=gnome-valgrind-errors`
		`+ TryExec=gnome-valgrind-errors`
		`+ -Name=GNOME Valgrind (Errors)`
		`+ +Name=GNOME Valgrind on Xorg (Errors)`
		`+ Comment=GNOME Valgrind (Error check)`
		`+ diff --git a/gnome-valgrind-leaks.desktop b/gnome-valgrind-leaks.desktop`
		`+ index 458c1fc..7adc656 100644`
		`+ --- a/gnome-valgrind-leaks.desktop`
		`+ +++ b/gnome-valgrind-leaks.desktop`
		`+ @@ -2,5 +2,5 @@`
		`+ Type=Application`
		`+ Exec=gnome-valgrind-leaks`
		`+ TryExec=gnome-valgrind-leaks`
		`+ -Name=GNOME Valgrind (Leaks)`
		`+ +Name=GNOME Valgrind on Xorg (Leaks)`
		`+ Comment=GNOME Valgrind (Leak check)`
		`+ --`
		`+ 2.40.1`
		`+`

gnome-valgrind-session.spec

file modified

+6 -1

		`@@ -1,13 +1,14 @@`
		`Summary: Run an entire GNOME session under valgrind`
		`Name: gnome-valgrind-session`
		`Version: 1.1`
		`- Release: 27%{?dist}`
		`+ Release: 28%{?dist}`
		`License: Public Domain`
		`URL: http://hp.cl.no/proj/gnome-valgrind-session/`
		`Source0: http://hp.cl.no/proj/gnome-valgrind-session/src/%{name}-%{version}.tar.bz2`
		`Patch0: %{name}-%{version}-desktop.patch`
		`Patch1: %{name}-%{version}-use-gnome-session-suffix-pid-drop-alignment.patch`
		`Patch2: %{name}-%{version}-use-gnome-session-drop-alignment.patch`
		`+ Patch3: %{name}-%{version}-add-xorg-label.patch`

		`Requires: gnome-session`
		`Requires: valgrind`
		`@@ -30,6 +31,7 @@`
		`%else`
		`%patch1 -p1`
		`%endif`
		`+ %patch3 -p1`

		`%build`

		`@@ -62,6 +64,9 @@`
		`%{_datadir}/xsessions/gnome-valgrind-leaks.desktop`

		`%changelog`
		`+ * Wed May 10 2023 FeRD (Frank Dana) <ferdnyc@gmail.com> - 1.1-28`
		`+ - Add "on Xorg" to session names`
		`+`
		`* Thu Jan 19 2023 Fedora Release Engineering <releng@fedoraproject.org> - 1.1-27`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild`

ferdnyc commented 4 months ago

This PR patches the gnome-valgrind-session .desktop files to add "on Xorg" to the session names. When this project was created, Wayland didn't exist and "on Xorg" would have been redundant, but now it makes sense to specify.

rebased onto 3400ef9

4 months ago

rishi commented 4 months ago

Merged. Thanks, @ferdnyc

I don't have any time for this package anymore, and I am going to orphan it. Would you like to pick it up?

Pull-Request has been closed by rishi

4 months ago

ferdnyc commented 3 months ago

@rishi

I don't have any time for this package anymore, and I am going to orphan it. Would you like to pick it up?

Sure, I've added it to my list.

(BTW, I saw your most recent commit and figured "Fedora 8" was a typo for "RHEL 8"... but, nope, turns out it's exactly what it says! This one's been around for a while, eh?)

rishi commented 3 months ago

@rishi

I don't have any time for this package anymore, and I am going to orphan it. Would you like to pick it up?

Sure, I've added it to my list.

(BTW, I saw your most recent commit and figured "Fedora 8" was a typo for "RHEL 8"... but, nope, turns out it's exactly what it says! This one's been around for a while, eh?)

Yes, it was one of my first Fedora packages. Thanks for picking it up!