#4 Split golist into a separate package.
Merged 4 years ago by jcajka. Opened 4 years ago by qulogic.
rpms/ qulogic/go-compilers master  into  master

file modified
+10 -29
@@ -1,18 +1,12 @@ 

- %global debug_package   %{nil}

- 

- %global commit          9f4330a0f4437ca61ba92f9f30e34424c6742ad6

- %global shortcommit     %(c=%{commit}; echo ${c:0:7})

- 

- %global m_commit        4d469a3d37c21353fbd6bb306ce707dc4151fd1e

- %global m_shortcommit   %(c=%{m_commit}; echo ${c:0:7})

+ %global commit        4d469a3d37c21353fbd6bb306ce707dc4151fd1e

+ %global shortcommit   %(c=%{commit}; echo ${c:0:7})

  

  Name:           go-compilers

  Version:        1

- Release:        33%{?dist}

+ Release:        34%{?dist}

  Summary:        Go language compilers for various architectures

  License:        GPLv3+

- Source0:        https://github.com/gofed/symbols-extractor/archive/%{commit}/symbols-extractor-%{shortcommit}.tar.gz

- Source1:        https://github.com/gofed/go-macros/archive/%{m_commit}/go-macros-%{m_shortcommit}.tar.gz

+ Source0:        https://github.com/gofed/go-macros/archive/%{commit}/go-macros-%{shortcommit}.tar.gz

  

  ExclusiveArch:  %{go_arches}

  
@@ -29,9 +23,8 @@ 

  %package golang-compiler

  Summary:       compiler for golang

  

- BuildRequires: golang

- 

  Requires:      golang

+ Requires:      golist

  

  Provides:      compiler(go-compiler) = 2

  Provides:      compiler(golang)
@@ -46,6 +39,7 @@ 

  

  # GCC>=5 holds in Fedora now

  Requires:      gcc-go

+ Requires:      golist

  

  Provides:      compiler(go-compiler) = 1

  Provides:      compiler(gcc-go)
@@ -55,18 +49,7 @@ 

  %endif

  

  %prep

- %setup -q -n symbols-extractor-%{commit}

- %setup -q -n go-macros-%{m_commit} -T -b 1

- 

- %build

- mkdir -p src/github.com/gofed

- pushd ../symbols-extractor-%{commit}

- export GOPATH=$(pwd):%{gopath}

- # TODO(jchaloup): build it as part of the golang compiler or to-be symbols-extractor package

- sed -i "s/.*\/cmd\/extract.*/\t\\\\/" Makefile

- sed -i "s/.*\/cmd\/checkapi.*/\t\\\\/" Makefile

- make

- popd

+ %setup -q -n go-macros-%{commit}

  

  %install

  %ifarch %{golang_arches}
@@ -81,10 +64,6 @@ 

  install -m 644 -D rpm/fileattrs/go.attr %{buildroot}%{_rpmconfigdir}/fileattrs/go.attr

  install -m 644 -D rpm/fileattrs/gobundled.attr %{buildroot}%{_rpmconfigdir}/fileattrs/gobundled.attr

  install -m 644 -D rpm/fileattrs/gosymlink.attr %{buildroot}%{_rpmconfigdir}/fileattrs/gosymlink.attr

- 

- pushd ../symbols-extractor-%{commit}

- install -D -p -m 0755 golist %{buildroot}%{_bindir}/golist

- popd

  %endif

  

  %ifarch %{gccgo_arches}
@@ -100,7 +79,6 @@ 

  %{_rpmconfigdir}/fileattrs/go.attr

  %{_rpmconfigdir}/fileattrs/gobundled.attr

  %{_rpmconfigdir}/fileattrs/gosymlink.attr

- %{_bindir}/golist

  %{_bindir}/go-rpm-integration

  %endif

  
@@ -110,6 +88,9 @@ 

  %endif

  

  %changelog

+ * Wed May 15 2019 Elliott Sales de Andrade <quantum.analyst@gmail.com> - 1-34

+ - Split golist into a separate package

+ 

  * Thu Jan 31 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1-33

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

file modified
-1
@@ -1,2 +1,1 @@ 

  SHA512 (go-macros-4d469a3.tar.gz) = 208955265d4ed2971cc99c7365cdcf808cf61dde3d47d7ef7345f716c729988ea07b1cd26b2e5a2e991c770fde3212295d2d49d0dac95bddcfc595b59de3d966

- SHA512 (symbols-extractor-9f4330a.tar.gz) = f233bf80192e0f39bd07ac64df9ba704cae26973562a7ab680e9d19436a705b61a7819a623c31c904465887b4b192eadd174e8b6df604393f721be150a21d32c

BR on golang is no longer needed.

rebased onto 953cbee

4 years ago

BR on golang is no longer needed.

Removed.

And gcc-go meta package is missing Requires on golist. Otherwise LGTM.

rebased onto 7641b85

4 years ago

I added Requires on gcc-go-compiler, but looking at it again, it never provided /usr/bin/golist, nor depended on golang-compiler (which did). So should it really have the Requires?

I guess that has been probably overlooked when the old golist got added. With gcc-go it should be the same as with golang, so there is a possibility to switch(not that we are testing it or should be, but it is good to have this option accounted for).

Pull-Request has been merged by jcajka

4 years ago