PR#4: Introduced gating - rpms/go-rpm-macros

rpms / go-rpm-macros

#4 Introduced gating

Merged 2 years ago by jcajka. Opened 2 years ago by jkurik.

rpms/ jkurik/go-rpm-macros rawhide into rawhide

Exchange etcd with grafana

Jan Kurik • 2 years ago

a61079a

Introduced gating

Jan Kurik • 2 years ago

69ba76f

.fmf/version

file added

		`@@ -0,0 +1,1 @@`
		`+ 1`

gating.yaml

file added

+19

		`@@ -0,0 +1,19 @@`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - fedora-*`
		`+ decision_context: bodhi_update_push_stable`
		`+ subject_type: koji_build`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - rhel-8`
		`+ decision_context: osci_compose_gate`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: baseos-ci.brew-build.tier1.functional}`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - rhel-9`
		`+ decision_context: osci_compose_gate`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: baseos-ci.brew-build.tier1.functional}`

plans/ci.fmf

file added

		`@@ -0,0 +1,6 @@`
		`+ summary: CI Gating Plan`
		`+ discover:`
		`+ how: fmf`
		`+ directory: tests`
		`+ execute:`
		`+ how: beakerlib`

tests/README

file added

		`@@ -0,0 +1,2 @@`
		`+ The test's Makefiles are not used in Fedora CI infrastructure. But are kept here`
		`+ for backward compatibility with traditional beakerlib test harness in RHEL.`

tests/Sanity/gobuild-grafana/Makefile

file added

+66

		`@@ -0,0 +1,66 @@`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+ #`
		`+ # Makefile of /tools/go-rpm-macros/Sanity/gobuild-grafana`
		`+ # Description: golang rpm macros usage building grafana`
		`+ # Author: Jan Kuřík <jkurik@redhat.com>`
		`+ #`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+ #`
		`+ # Copyright (c) 2021 Red Hat, Inc.`
		`+ #`
		`+ # This program is free software: you can redistribute it and/or`
		`+ # modify it under the terms of the GNU General Public License as`
		`+ # published by the Free Software Foundation, either version 2 of`
		`+ # the License, or (at your option) any later version.`
		`+ #`
		`+ # This program is distributed in the hope that it will be`
		`+ # useful, but WITHOUT ANY WARRANTY; without even the implied`
		`+ # warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR`
		`+ # PURPOSE. See the GNU General Public License for more details.`
		`+ #`
		`+ # You should have received a copy of the GNU General Public License`
		`+ # along with this program. If not, see http://www.gnu.org/licenses/.`
		`+ #`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+`
		`+ export TEST=/tools/go-rpm-macros/Sanity/gobuild-grafana`
		`+ export TESTVERSION=1.0`
		`+`
		`+ BUILT_FILES=`
		`+`
		`+ FILES=$(METADATA) runtest.sh Makefile PURPOSE`
		`+`
		`+ .PHONY: all install download clean`
		`+`
		`+ run: $(FILES) build`
		`+ ./runtest.sh`
		`+`
		`+ build: $(BUILT_FILES)`
		`+ test -x runtest.sh \|\| chmod a+x runtest.sh`
		`+`
		`+ clean:`
		`+ rm -f *~ $(BUILT_FILES)`
		`+`
		`+`
		`+ include /usr/share/rhts/lib/rhts-make.include`
		`+`
		`+ $(METADATA): Makefile`
		`+ @echo "Owner: Jan Kuřík <jkurik@redhat.com>" > $(METADATA)`
		`+ @echo "Name: $(TEST)" >> $(METADATA)`
		`+ @echo "TestVersion: $(TESTVERSION)" >> $(METADATA)`
		`+ @echo "Path: $(TEST_DIR)" >> $(METADATA)`
		`+ @echo "Description: golang rpm macros usage building" >> $(METADATA)`
		`+ @echo "Type: Sanity" >> $(METADATA)`
		`+ @echo "TestTime: 2h" >> $(METADATA)`
		`+ @echo "RunFor: golang" >> $(METADATA)`
		`+ @echo "Requires: golang" >> $(METADATA)`
		`+ @echo "Requires: go-rpm-macros go-srpm-macros" >> $(METADATA)`
		`+ @echo "Requires: /usr/bin/yumdownloader /usr/bin/yum-builddep" >> $(METADATA)`
		`+ @echo "Requires: /usr/bin/rpmbuild" >> $(METADATA)`
		`+ @echo "Priority: Normal" >> $(METADATA)`
		`+ @echo "License: GPLv2+" >> $(METADATA)`
		`+ @echo "Confidential: no" >> $(METADATA)`
		`+ @echo "Destructive: no" >> $(METADATA)`
		`+ @echo "Releases: Fedora" >> $(METADATA)`
		`+`
		`+ rhts-lint $(METADATA)`

tests/Sanity/gobuild-grafana/PURPOSE

file added

		`@@ -0,0 +1,3 @@`
		`+ PURPOSE of /tools/go-rpm-macros/Sanity/gobuild-grafana`
		`+ Description: golang rpm macros usage building grafana`
		`+ Author: Jan Kuřík <jkurik@redhat.com>`

tests/Sanity/gobuild-grafana/main.fmf

file added

+17

		`@@ -0,0 +1,17 @@`
		`+ summary: golang rpm macros usage building`
		`+ description: ''`
		`+ contact: Jan Kuřík <jkurik@redhat.com>`
		`+ component:`
		`+ - golang`
		`+ test: ./runtest.sh`
		`+ framework: beakerlib`
		`+ recommend:`
		`+ - golang`
		`+ - go-rpm-macros`
		`+ - go-srpm-macros`
		`+ - /usr/bin/yumdownloader`
		`+ - /usr/bin/yum-builddep`
		`+ - /usr/bin/rpmbuild`
		`+ duration: 2h`
		`+ extra-summary: /tools/go-rpm-macros/Sanity/gobuild-grafana`
		`+ extra-task: /tools/go-rpm-macros/Sanity/gobuild-grafana`

tests/Sanity/gobuild-grafana/runtest.sh

file added

+75

		`@@ -0,0 +1,75 @@`
		`+ #!/bin/bash`
		`+ # vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+ #`
		`+ # runtest.sh of /tools/go-rpm-macros/Sanity/gobuild-grafana`
		`+ # Description: golang rpm macros usage building grafana`
		`+ # Author: Jan Kuřík <jkurik@redhat.com>`
		`+ #`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+ #`
		`+ # Copyright (c) 2021 Red Hat, Inc.`
		`+ #`
		`+ # This program is free software: you can redistribute it and/or`
		`+ # modify it under the terms of the GNU General Public License as`
		`+ # published by the Free Software Foundation, either version 2 of`
		`+ # the License, or (at your option) any later version.`
		`+ #`
		`+ # This program is distributed in the hope that it will be`
		`+ # useful, but WITHOUT ANY WARRANTY; without even the implied`
		`+ # warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR`
		`+ # PURPOSE. See the GNU General Public License for more details.`
		`+ #`
		`+ # You should have received a copy of the GNU General Public License`
		`+ # along with this program. If not, see http://www.gnu.org/licenses/.`
		`+ #`
		`+ # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
		`+`
		`+ # Include Beaker environment`
		`+ . /usr/share/beakerlib/beakerlib.sh \|\| exit 1`
		`+`
		`+ PACKAGE="go-rpm-macros"`
		`+`
		`+ GO_PACKAGE="$(rpm -qf $(which go))"`
		`+`
		`+ # Conserve the non-zero return value through the pipe`
		`+ set -o pipefail`
		`+`
		`+ rlJournalStart`
		`+ rlPhaseStartSetup`
		`+ rlRun "TmpDir=\$(mktemp -d /var/tmp/XXXXXXX)" 0 "Creating tmp directory"`
		`+ rlRun "pushd $TmpDir"`
		`+ rlPhaseEnd`
		`+`
		`+ rlPhaseStartTest "check macros"`
		`+ rlRun "gobuild_string=\"$(rpm -E '%gobuild')\"" 127`
		`+ rlRun "gotest_string=\"$(rpm -E '%gotest')\"" 127`
		`+ rlAssertNotEquals "Checking if %gobuild macro is defined" "$gobuild_string" "%gobuild"`
		`+ rlAssertNotEquals "Checking if %gotest macro is defined" "$gotest_string" "%gotest"`
		`+ rlPhaseEnd`
		`+`
		`+ rlPhaseStart FAIL "setup grafana sources"`
		`+ rlRun "SRPM=\$(basename \$(yumdownloader --source --url grafana \| tail -n 1))"`
		`+ rlRun "yumdownloader --source grafana"`
		`+ rlRun "yum-builddep --enablerepo=\* -y --srpm ${SRPM}"`
		`+ rlRun "rpm -i -D '_topdir $TmpDir' ${SRPM}"`
		`+ rlRun "sed -i 's/^\s%define\scompile_frontend\s.*/%define compile_frontend 0/g' \`
		`+ SPECS/grafana.spec" 0 "Make sure we build only the golang part, no JS stuff"`
		`+ rlPhaseEnd`
		`+`
		`+ rlPhaseStartTest "rpmbuild grafana"`
		`+ rlRun "rpmbuild --showrc &> ${TmpDir}/rpm.rc"`
		`+ rlFileSubmit "${TmpDir}/rpm.rc"`
		`+ rlAssertGrep "%gobuild" SPECS/grafana.spec -w`
		`+ rlAssertGrep "%gotest" SPECS/grafana.spec -w`
		`+ rlRun "rpmbuild -bc --define='_topdir $TmpDir' SPECS/grafana.spec \`
		`+ \|& tee grafana.rpmbuild.log"`
		`+ rlFileSubmit "grafana.rpmbuild.log"`
		`+ rlPhaseEnd`
		`+`
		`+ rlPhaseStartCleanup`
		`+ rlRun "popd"`
		`+ rlRun "rm -r $TmpDir" 0 "Removing tmp directory"`
		`+ rlPhaseEnd`
		`+ rlJournalPrintText`
		`+ rlJournalEnd`

jkurik commented 2 years ago

Introduced gating and added a test building grafana to make sure golang rpm macros are correct.
The test checks for presence of '%gobuild' and '%gotest' macros in spec file of grafana and then rebuilds it.

Originally there was etcd package used for this purpose, however grafana package seems to serve better for this purpose, as it is using '%gobuild' and '%gotest' macros in its spec file.