#1 Add patch from GitHub's fork for GitHub CLI
Closed 2 years ago by mikelo2. Opened 2 years ago by mikelo2.
rpms/ mikelo2/golang-github-shurcool-graphql github-cli  into  rawhide

@@ -15,12 +15,14 @@ 

  

  Name:           %{goname}

  Version:        0

- Release:        0.7%{?dist}

+ Release:        0.8%{?dist}

  Summary:        Package graphql provides a GraphQL client implementation

  

  License:        MIT

  URL:            %{gourl}

  Source0:        %{gosource}

+ # Patches for GitHub cli from GitHub's fork

+ Patch0001:      https://github.com/cli/shurcooL-graphql/commit/0f7232a2bf7e6d8f393025a8f5cafbd219a7ebeb.patch

  

  BuildRequires:  golang(github.com/graph-gophers/graphql-go)

  # Examples are not packaged
@@ -35,6 +37,7 @@ 

  

  %prep

  %goprep

+ %patch0001 -p1

  

  %install

  %gopkginstall
@@ -47,6 +50,9 @@ 

  %gopkgfiles

  

  %changelog

+ * Tue Sep 28 2021 Mikel Olasagasti Uranga <mikel@olasagasti.info> - 0-0.8

+ - Version bump and patches

+ 

  * Thu Jul 22 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0-0.7

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild

  

no initial comment

It changes the signature of some functions, which could break compatibility with other packages, I'd rather package https://github.com/cli/shurcooL-graphql branch named-queries separately. Alternatively, you could use the non-reviewed PR: https://github.com/shurcooL/graphql/pull/57 which seems to contain a fix.

Pull-Request has been closed by mikelo2

2 years ago

golang-github-cli-shurcool-graphql exists already and that's the correct path to follow. It was created in the previous attempt of getting gh into Fedora.

Metadata