|
 |
6174550 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
6174550 |
From: Colin Watson <cjwatson@debian.org>
|
|
|
6174550 |
Date: Fri, 24 Jul 2020 17:18:09 +0100
|
|
|
6174550 |
Subject: [PATCH] efilinux: Fix integer overflows in grub_cmd_initrd
|
|
|
6174550 |
|
|
|
6174550 |
These could be triggered by an extremely large number of arguments to
|
|
|
6174550 |
the initrd command on 32-bit architectures, or a crafted filesystem with
|
|
|
6174550 |
very large files on any architecture.
|
|
|
6174550 |
|
|
|
6174550 |
Signed-off-by: Colin Watson <cjwatson@debian.org>
|
|
|
6174550 |
---
|
|
|
6174550 |
grub-core/loader/i386/efi/linux.c | 10 ++++++++--
|
|
|
6174550 |
1 file changed, 8 insertions(+), 2 deletions(-)
|
|
|
6174550 |
|
|
|
6174550 |
diff --git a/grub-core/loader/i386/efi/linux.c b/grub-core/loader/i386/efi/linux.c
|
|
|
6174550 |
index 15d40d6e35b..f992ceeef20 100644
|
|
|
6174550 |
--- a/grub-core/loader/i386/efi/linux.c
|
|
|
6174550 |
+++ b/grub-core/loader/i386/efi/linux.c
|
|
|
6174550 |
@@ -28,6 +28,8 @@
|
|
|
6174550 |
#include <grub/efi/efi.h>
|
|
|
6174550 |
#include <grub/efi/linux.h>
|
|
|
6174550 |
#include <grub/cpu/efi/memory.h>
|
|
|
6174550 |
+#include <grub/tpm.h>
|
|
|
6174550 |
+#include <grub/safemath.h>
|
|
|
6174550 |
|
|
|
6174550 |
GRUB_MOD_LICENSE ("GPLv3+");
|
|
|
6174550 |
|
|
|
6174550 |
@@ -206,7 +208,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
|
|
|
6174550 |
goto fail;
|
|
|
6174550 |
}
|
|
|
6174550 |
|
|
|
6174550 |
- files = grub_zalloc (argc * sizeof (files[0]));
|
|
|
6174550 |
+ files = grub_calloc (argc, sizeof (files[0]));
|
|
|
6174550 |
if (!files)
|
|
|
6174550 |
goto fail;
|
|
|
6174550 |
|
|
|
6174550 |
@@ -216,7 +218,11 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
|
|
|
6174550 |
if (! files[i])
|
|
|
6174550 |
goto fail;
|
|
|
6174550 |
nfiles++;
|
|
|
6174550 |
- size += ALIGN_UP (grub_file_size (files[i]), 4);
|
|
|
6174550 |
+ if (grub_add (size, ALIGN_UP (grub_file_size (files[i]), 4), &size))
|
|
|
6174550 |
+ {
|
|
|
6174550 |
+ grub_error (GRUB_ERR_OUT_OF_RANGE, N_("overflow is detected"));
|
|
|
6174550 |
+ goto fail;
|
|
|
6174550 |
+ }
|
|
|
6174550 |
}
|
|
|
6174550 |
|
|
|
6174550 |
initrd_mem = kernel_alloc(size, N_("can't allocate initrd"));
|