90dacf5
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
90dacf5
From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
90dacf5
Date: Fri, 4 Mar 2022 11:36:09 +0100
90dacf5
Subject: [PATCH] grub-core/loader/efi/linux.c: drop now unused
90dacf5
 grub_linuxefi_secure_validate
90dacf5
90dacf5
Drop the now unused grub_linuxefi_secure_validate() as all prior users
90dacf5
of this API now rely on the shim-lock-verifier codepath instead.
90dacf5
90dacf5
This patch must not be ported to older editions of grub code bases
90dacf5
that do not have verifiers framework, or it is not builtin, or
90dacf5
shim-lock-verifier is an optional module.
90dacf5
90dacf5
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
90dacf5
---
90dacf5
 grub-core/loader/efi/linux.c | 40 ----------------------------------------
90dacf5
 include/grub/efi/linux.h     |  2 --
90dacf5
 2 files changed, 42 deletions(-)
90dacf5
90dacf5
diff --git a/grub-core/loader/efi/linux.c b/grub-core/loader/efi/linux.c
e622855
index 9260731c10..9265cf4200 100644
90dacf5
--- a/grub-core/loader/efi/linux.c
90dacf5
+++ b/grub-core/loader/efi/linux.c
90dacf5
@@ -24,46 +24,6 @@
90dacf5
 #include <grub/efi/pe32.h>
90dacf5
 #include <grub/efi/linux.h>
90dacf5
 
90dacf5
-#define SHIM_LOCK_GUID \
90dacf5
- { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b, 0x23} }
90dacf5
-
90dacf5
-struct grub_efi_shim_lock
90dacf5
-{
90dacf5
-  grub_efi_status_t (*verify) (void *buffer, grub_uint32_t size);
90dacf5
-};
90dacf5
-typedef struct grub_efi_shim_lock grub_efi_shim_lock_t;
90dacf5
-
90dacf5
-// Returns 1 on success, -1 on error, 0 when not available
90dacf5
-int
90dacf5
-grub_linuxefi_secure_validate (void *data, grub_uint32_t size)
90dacf5
-{
90dacf5
-  grub_efi_guid_t guid = SHIM_LOCK_GUID;
90dacf5
-  grub_efi_shim_lock_t *shim_lock;
90dacf5
-  grub_efi_status_t status;
90dacf5
-
90dacf5
-  shim_lock = grub_efi_locate_protocol(&guid, NULL);
90dacf5
-  grub_dprintf ("secureboot", "shim_lock: %p\n", shim_lock);
90dacf5
-  if (!shim_lock)
90dacf5
-    {
90dacf5
-      grub_dprintf ("secureboot", "shim not available\n");
90dacf5
-      return 0;
90dacf5
-    }
90dacf5
-
90dacf5
-  grub_dprintf ("secureboot", "Asking shim to verify kernel signature\n");
90dacf5
-  status = shim_lock->verify (data, size);
90dacf5
-  grub_dprintf ("secureboot", "shim_lock->verify(): %ld\n", (long int)status);
90dacf5
-  if (status == GRUB_EFI_SUCCESS)
90dacf5
-    {
90dacf5
-      grub_dprintf ("secureboot", "Kernel signature verification passed\n");
90dacf5
-      return 1;
90dacf5
-    }
90dacf5
-
90dacf5
-  grub_dprintf ("secureboot", "Kernel signature verification failed (0x%lx)\n",
90dacf5
-		(unsigned long) status);
90dacf5
-
90dacf5
-  return -1;
90dacf5
-}
90dacf5
-
90dacf5
 #pragma GCC diagnostic push
90dacf5
 #pragma GCC diagnostic ignored "-Wcast-align"
90dacf5
 
90dacf5
diff --git a/include/grub/efi/linux.h b/include/grub/efi/linux.h
e622855
index 0033d9305a..887b02fd9f 100644
90dacf5
--- a/include/grub/efi/linux.h
90dacf5
+++ b/include/grub/efi/linux.h
90dacf5
@@ -22,8 +22,6 @@
90dacf5
 #include <grub/err.h>
90dacf5
 #include <grub/symbol.h>
90dacf5
 
90dacf5
-int
90dacf5
-EXPORT_FUNC(grub_linuxefi_secure_validate) (void *data, grub_uint32_t size);
90dacf5
 grub_err_t
90dacf5
 EXPORT_FUNC(grub_efi_linux_boot) (void *kernel_address, grub_off_t offset,
90dacf5
 				  void *kernel_param);