|
 |
c2f7a5e |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
bed013f |
From: Peter Jones <pjones@redhat.com>
|
|
|
bed013f |
Date: Thu, 16 Aug 2018 11:08:11 -0400
|
|
|
bed013f |
Subject: [PATCH] Make linux_arm_kernel_header.hdr_offset be at the right place
|
|
|
bed013f |
|
|
|
bed013f |
The kernel in front of me (slightly edited to make objdump work) looks like:
|
|
|
bed013f |
|
|
|
bed013f |
00000000 4d 5a 10 13 4d 5a 10 13 4d 5a 10 13 4d 5a 10 13 |MZ..MZ..MZ..MZ..|
|
|
|
bed013f |
00000010 4d 5a 10 13 4d 5a 10 13 4d 5a 10 13 00 00 a0 e1 |MZ..MZ..MZ......|
|
|
|
bed013f |
00000020 f6 03 00 ea 18 28 6f 01 00 00 00 00 00 32 74 00 |.....(o......2t.|
|
|
|
bed013f |
00000030 01 02 03 04 45 45 45 45 74 a2 00 00 40 00 00 00 |....EEEEt...@...|
|
|
|
bed013f |
00000040 50 45 00 00 4c 01 04 00 00 00 00 00 00 00 00 00 |PE..L...........|
|
|
|
bed013f |
00000050 00 00 00 00 90 00 06 03 0b 01 02 14 00 20 74 00 |............. t.|
|
|
|
bed013f |
00000060 00 14 00 00 00 00 00 00 b4 19 00 00 00 10 00 00 |................|
|
|
|
bed013f |
00000070 00 30 74 00 00 00 00 00 00 10 00 00 00 02 00 00 |.0t.............|
|
|
|
bed013f |
00000080 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
|
|
|
bed013f |
00000090 00 44 74 00 00 10 00 00 00 00 00 00 0a 00 00 00 |.Dt.............|
|
|
|
bed013f |
000000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
|
|
|
bed013f |
000000b0 00 00 00 00 06 00 00 00 00 00 00 00 00 00 00 00 |................|
|
|
|
bed013f |
000000c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
|
|
|
bed013f |
*
|
|
|
bed013f |
|
|
|
bed013f |
(I don't know why the MZ header is there 7 times, but the offsets work out, so
|
|
|
bed013f |
it's merely a surprising distraction.)
|
|
|
bed013f |
|
|
|
bed013f |
If linux_arm_kernel_header.reserved2 is 16 bytes, that means hdr_offset is
|
|
|
bed013f |
here:
|
|
|
bed013f |
|
|
|
bed013f |
00000030 01 02 03 04 45 45 45 45 74 a2 00 00 40 00 00 00 |....EEEEt...@...|
|
|
|
bed013f |
00000040 50 45 00 00 4c 01 04 00 00 00 00 00 00 00 00 00 |PE..L...........|
|
|
|
bed013f |
^^^^^^^^^^^
|
|
|
bed013f |
|
|
|
bed013f |
But it's supposed to be 4 bytes before that.
|
|
|
bed013f |
|
|
|
bed013f |
This patch makes the reserved field be 3*32 instead of 4*32, and that means we
|
|
|
bed013f |
can find the PE header correcrtly at 0x40 by reading the value at 0x3c.
|
|
|
bed013f |
|
|
|
bed013f |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
bed013f |
---
|
|
|
bed013f |
grub-core/loader/efi/linux.c | 3 +++
|
|
|
bed013f |
include/grub/arm/linux.h | 2 +-
|
|
|
c2f7a5e |
2 files changed, 4 insertions(+), 1 deletion(-)
|
|
|
bed013f |
|
|
|
bed013f |
diff --git a/grub-core/loader/efi/linux.c b/grub-core/loader/efi/linux.c
|
|
|
bed013f |
index 0622dfa48d4..b56ea0bc041 100644
|
|
|
bed013f |
--- a/grub-core/loader/efi/linux.c
|
|
|
bed013f |
+++ b/grub-core/loader/efi/linux.c
|
|
|
bed013f |
@@ -79,7 +79,10 @@ grub_efi_linux_boot (void *kernel_addr, grub_off_t handover_offset,
|
|
|
bed013f |
offset = 512;
|
|
|
bed013f |
#endif
|
|
|
bed013f |
|
|
|
bed013f |
+ grub_dprintf ("linux", "kernel_addr: %p handover_offset: %p params: %p\n",
|
|
|
bed013f |
+ kernel_addr, (void *)(grub_efi_uintn_t)handover_offset, kernel_params);
|
|
|
bed013f |
hf = (handover_func)((char *)kernel_addr + handover_offset + offset);
|
|
|
bed013f |
+ grub_dprintf ("linux", "handover_func() = %p\n", hf);
|
|
|
bed013f |
hf (grub_efi_image_handle, grub_efi_system_table, kernel_params);
|
|
|
bed013f |
|
|
|
bed013f |
return GRUB_ERR_BUG;
|
|
|
bed013f |
diff --git a/include/grub/arm/linux.h b/include/grub/arm/linux.h
|
|
|
bed013f |
index 5900fc8a40c..bed308f22cb 100644
|
|
|
bed013f |
--- a/include/grub/arm/linux.h
|
|
|
bed013f |
+++ b/include/grub/arm/linux.h
|
|
|
bed013f |
@@ -31,7 +31,7 @@ struct linux_arm_kernel_header {
|
|
|
bed013f |
grub_uint32_t magic;
|
|
|
bed013f |
grub_uint32_t start; /* _start */
|
|
|
bed013f |
grub_uint32_t end; /* _edata */
|
|
|
bed013f |
- grub_uint32_t reserved2[4];
|
|
|
bed013f |
+ grub_uint32_t reserved2[3];
|
|
|
bed013f |
grub_uint32_t hdr_offset;
|
|
|
bed013f |
};
|
|
|
bed013f |
|