|
 |
f0ad2aa |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
f0ad2aa |
From: Daniel Axtens <dja@axtens.net>
|
|
|
f0ad2aa |
Date: Tue, 1 Mar 2022 23:14:15 +1100
|
|
|
f0ad2aa |
Subject: [PATCH] net/http: Do not tear down socket if it's already been torn
|
|
|
f0ad2aa |
down
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
It's possible for data->sock to get torn down in tcp error handling.
|
|
|
f0ad2aa |
If we unconditionally tear it down again we will end up doing writes
|
|
|
f0ad2aa |
to an offset of the NULL pointer when we go to tear it down again.
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
Detect if it has been torn down and don't do it again.
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
Signed-off-by: Daniel Axtens <dja@axtens.net>
|
|
|
f0ad2aa |
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
|
f0ad2aa |
(cherry picked from commit ec233d3ecf995293304de443579aab5c46c49e85)
|
|
|
f0ad2aa |
---
|
|
|
f0ad2aa |
grub-core/net/http.c | 5 +++--
|
|
|
f0ad2aa |
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
diff --git a/grub-core/net/http.c b/grub-core/net/http.c
|
|
|
f0ad2aa |
index 7f878b5615..19cb8768e3 100644
|
|
|
f0ad2aa |
--- a/grub-core/net/http.c
|
|
|
f0ad2aa |
+++ b/grub-core/net/http.c
|
|
|
f0ad2aa |
@@ -427,7 +427,7 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial)
|
|
|
f0ad2aa |
return err;
|
|
|
f0ad2aa |
}
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
- for (i = 0; !data->headers_recv && i < 100; i++)
|
|
|
f0ad2aa |
+ for (i = 0; data->sock && !data->headers_recv && i < 100; i++)
|
|
|
f0ad2aa |
{
|
|
|
f0ad2aa |
grub_net_tcp_retransmit ();
|
|
|
f0ad2aa |
grub_net_poll_cards (300, &data->headers_recv);
|
|
|
f0ad2aa |
@@ -435,7 +435,8 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial)
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
if (!data->headers_recv)
|
|
|
f0ad2aa |
{
|
|
|
f0ad2aa |
- grub_net_tcp_close (data->sock, GRUB_NET_TCP_ABORT);
|
|
|
f0ad2aa |
+ if (data->sock)
|
|
|
f0ad2aa |
+ grub_net_tcp_close (data->sock, GRUB_NET_TCP_ABORT);
|
|
|
f0ad2aa |
if (data->err)
|
|
|
f0ad2aa |
{
|
|
|
f0ad2aa |
char *str = data->errmsg;
|