|
 |
f0ad2aa |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
f0ad2aa |
From: Darren Kenny <darren.kenny@oracle.com>
|
|
|
f0ad2aa |
Date: Tue, 29 Mar 2022 10:49:56 +0000
|
|
|
f0ad2aa |
Subject: [PATCH] fs/btrfs: Fix several fuzz issues with invalid dir item
|
|
|
f0ad2aa |
sizing
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
According to the btrfs code in Linux, the structure of a directory item
|
|
|
f0ad2aa |
leaf should be of the form:
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
|struct btrfs_dir_item|name|data|
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
in GRUB the name len and data len are in the grub_btrfs_dir_item
|
|
|
f0ad2aa |
structure's n and m fields respectively.
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
The combined size of the structure, name and data should be less than
|
|
|
f0ad2aa |
the allocated memory, a difference to the Linux kernel's struct
|
|
|
f0ad2aa |
btrfs_dir_item is that the grub_btrfs_dir_item has an extra field for
|
|
|
f0ad2aa |
where the name is stored, so we adjust for that too.
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
|
|
|
f0ad2aa |
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
|
f0ad2aa |
(cherry picked from commit 6d3f06c0b6a8992b9b1bb0e62af93ac5ff2781f0)
|
|
|
f0ad2aa |
[rharwood: we've an extra variable here]
|
|
|
f0ad2aa |
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
|
|
|
f0ad2aa |
---
|
|
|
f0ad2aa |
grub-core/fs/btrfs.c | 26 ++++++++++++++++++++++++++
|
|
|
f0ad2aa |
1 file changed, 26 insertions(+)
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
|
|
|
f0ad2aa |
index 07c0ff874b..2fcfb738fe 100644
|
|
|
f0ad2aa |
--- a/grub-core/fs/btrfs.c
|
|
|
f0ad2aa |
+++ b/grub-core/fs/btrfs.c
|
|
|
f0ad2aa |
@@ -2254,6 +2254,7 @@ grub_btrfs_dir (grub_device_t device, const char *path,
|
|
|
f0ad2aa |
grub_uint64_t tree;
|
|
|
f0ad2aa |
grub_uint8_t type;
|
|
|
f0ad2aa |
char *new_path = NULL;
|
|
|
f0ad2aa |
+ grub_size_t est_size = 0;
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
if (!data)
|
|
|
f0ad2aa |
return grub_errno;
|
|
|
f0ad2aa |
@@ -2320,6 +2321,18 @@ grub_btrfs_dir (grub_device_t device, const char *path,
|
|
|
f0ad2aa |
break;
|
|
|
f0ad2aa |
}
|
|
|
f0ad2aa |
|
|
|
f0ad2aa |
+ if (direl == NULL ||
|
|
|
f0ad2aa |
+ grub_add (grub_le_to_cpu16 (direl->n),
|
|
|
f0ad2aa |
+ grub_le_to_cpu16 (direl->m), &est_size) ||
|
|
|
f0ad2aa |
+ grub_add (est_size, sizeof (*direl), &est_size) ||
|
|
|
f0ad2aa |
+ grub_sub (est_size, sizeof (direl->name), &est_size) ||
|
|
|
f0ad2aa |
+ est_size > allocated)
|
|
|
f0ad2aa |
+ {
|
|
|
f0ad2aa |
+ grub_errno = GRUB_ERR_OUT_OF_RANGE;
|
|
|
f0ad2aa |
+ r = -grub_errno;
|
|
|
f0ad2aa |
+ goto out;
|
|
|
f0ad2aa |
+ }
|
|
|
f0ad2aa |
+
|
|
|
f0ad2aa |
for (cdirel = direl;
|
|
|
f0ad2aa |
(grub_uint8_t *) cdirel - (grub_uint8_t *) direl
|
|
|
f0ad2aa |
< (grub_ssize_t) elemsize;
|
|
|
f0ad2aa |
@@ -2330,6 +2343,19 @@ grub_btrfs_dir (grub_device_t device, const char *path,
|
|
|
f0ad2aa |
char c;
|
|
|
f0ad2aa |
struct grub_btrfs_inode inode;
|
|
|
f0ad2aa |
struct grub_dirhook_info info;
|
|
|
f0ad2aa |
+
|
|
|
f0ad2aa |
+ if (cdirel == NULL ||
|
|
|
f0ad2aa |
+ grub_add (grub_le_to_cpu16 (cdirel->n),
|
|
|
f0ad2aa |
+ grub_le_to_cpu16 (cdirel->m), &est_size) ||
|
|
|
f0ad2aa |
+ grub_add (est_size, sizeof (*cdirel), &est_size) ||
|
|
|
f0ad2aa |
+ grub_sub (est_size, sizeof (cdirel->name), &est_size) ||
|
|
|
f0ad2aa |
+ est_size > allocated)
|
|
|
f0ad2aa |
+ {
|
|
|
f0ad2aa |
+ grub_errno = GRUB_ERR_OUT_OF_RANGE;
|
|
|
f0ad2aa |
+ r = -grub_errno;
|
|
|
f0ad2aa |
+ goto out;
|
|
|
f0ad2aa |
+ }
|
|
|
f0ad2aa |
+
|
|
|
f0ad2aa |
err = grub_btrfs_read_inode (data, &inode, cdirel->key.object_id,
|
|
|
f0ad2aa |
tree);
|
|
|
f0ad2aa |
grub_memset (&info, 0, sizeof (info));
|