|
 |
ed1787d |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
ed1787d |
From: Zhang Boyang <zhangboyang.id@gmail.com>
|
|
|
ed1787d |
Date: Fri, 5 Aug 2022 02:27:05 +0800
|
|
|
ed1787d |
Subject: [PATCH] font: Fix integer overflow in ensure_comb_space()
|
|
|
ed1787d |
|
|
|
ed1787d |
In fact it can't overflow at all because glyph_id->ncomb is only 8-bit
|
|
|
ed1787d |
wide. But let's keep safe if somebody changes the width of glyph_id->ncomb
|
|
|
ed1787d |
in the future. This patch also fixes the inconsistency between
|
|
|
ed1787d |
render_max_comb_glyphs and render_combining_glyphs when grub_malloc()
|
|
|
ed1787d |
returns NULL.
|
|
|
ed1787d |
|
|
|
ed1787d |
Signed-off-by: Zhang Boyang <zhangboyang.id@gmail.com>
|
|
|
ed1787d |
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
|
ed1787d |
(cherry picked from commit b2740b7e4a03bb8331d48b54b119afea76bb9d5f)
|
|
|
ed1787d |
---
|
|
|
ed1787d |
grub-core/font/font.c | 14 +++++++++-----
|
|
|
ed1787d |
1 file changed, 9 insertions(+), 5 deletions(-)
|
|
|
ed1787d |
|
|
|
ed1787d |
diff --git a/grub-core/font/font.c b/grub-core/font/font.c
|
|
|
ed1787d |
index a115a63b0c..d0e6340404 100644
|
|
|
ed1787d |
--- a/grub-core/font/font.c
|
|
|
ed1787d |
+++ b/grub-core/font/font.c
|
|
|
ed1787d |
@@ -1468,14 +1468,18 @@ ensure_comb_space (const struct grub_unicode_glyph *glyph_id)
|
|
|
ed1787d |
if (glyph_id->ncomb <= render_max_comb_glyphs)
|
|
|
ed1787d |
return;
|
|
|
ed1787d |
|
|
|
ed1787d |
- render_max_comb_glyphs = 2 * glyph_id->ncomb;
|
|
|
ed1787d |
- if (render_max_comb_glyphs < 8)
|
|
|
ed1787d |
+ if (grub_mul (glyph_id->ncomb, 2, &render_max_comb_glyphs))
|
|
|
ed1787d |
+ render_max_comb_glyphs = 0;
|
|
|
ed1787d |
+ if (render_max_comb_glyphs > 0 && render_max_comb_glyphs < 8)
|
|
|
ed1787d |
render_max_comb_glyphs = 8;
|
|
|
ed1787d |
grub_free (render_combining_glyphs);
|
|
|
ed1787d |
- render_combining_glyphs = grub_malloc (render_max_comb_glyphs
|
|
|
ed1787d |
- * sizeof (render_combining_glyphs[0]));
|
|
|
ed1787d |
+ render_combining_glyphs = (render_max_comb_glyphs > 0) ?
|
|
|
ed1787d |
+ grub_calloc (render_max_comb_glyphs, sizeof (render_combining_glyphs[0])) : NULL;
|
|
|
ed1787d |
if (!render_combining_glyphs)
|
|
|
ed1787d |
- grub_errno = 0;
|
|
|
ed1787d |
+ {
|
|
|
ed1787d |
+ render_max_comb_glyphs = 0;
|
|
|
ed1787d |
+ grub_errno = GRUB_ERR_NONE;
|
|
|
ed1787d |
+ }
|
|
|
ed1787d |
}
|
|
|
ed1787d |
|
|
|
ed1787d |
int
|