#1 Fix warning building with clang
Merged 4 years ago by zdohnal. Opened 4 years ago by tstellar.
rpms/ tstellar/gutenprint clang-warning-fix  into  master

@@ -71,7 +71,7 @@ 

  +  stp_list_item_t *item;

  +  int prefixlen = strlen (prefix);

  +  if (!(new_list = stp_list_create()))

- +    return;

+ +    return NULL;

  +

  +  item = stp_list_get_start (list);

  +  while (item)

file modified
+5 -1
@@ -4,7 +4,7 @@ 

  Name:           gutenprint

  Summary:        Printer Drivers Package

  Version:        5.3.3

- Release:        2%{?dist}

+ Release:        3%{?dist}

  URL:            http://gimp-print.sourceforge.net/

  Source0:        http://downloads.sourceforge.net/gimp-print/%{name}-%{version}.tar.xz

  # Post-install script to update CUPS native PPDs.
@@ -243,6 +243,10 @@ 

  %{_mandir}/man8/cups-genppd*8*.gz

  

  %changelog

+ * Wed Mar 25 2020 Tom Stellard <tstellar@redhat.com> - 5.3.3-3

+ - Fix warning building with clang

+ - non-void function 'stp_paths_copy_with_prefix' should return a value [-Wreturn-type]

+ 

  * Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 5.3.3-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

non-void function 'stp_paths_copy_with_prefix' should return a value [-Wreturn-type]

Hi Tom,

thank you for the fix! I'll merge it.

Pull-Request has been merged by zdohnal

4 years ago