PR#10: Build extended version. - rpms/hugo

rpms / hugo

#10 Build extended version.

Closed 4 years ago by athoscr. Opened 4 years ago by mikep.

rpms/ mikep/hugo master into master

Build extended version.

W. Michael Petullo • 4 years ago

6975e30

hugo.spec

file modified

+5 -2

		`@@ -17,7 +17,7 @@`
		`%global godocs docs examples README.md CONTRIBUTING.md`

		`Name: hugo`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: The world’s fastest framework for building websites`

		`# Upstream license specification: Apache-2.0 and MIT`
		`@@ -154,7 +154,7 @@`


		`%build`
		`- %gobuild -o %{gobuilddir}/bin/hugo %{goipath}`
		`+ BUILDTAGS=extended %gobuild -o %{gobuilddir}/bin/hugo %{goipath}`
		`%{gobuilddir}/bin/hugo gen autocomplete --completionfile hugo-completion`
		`%{gobuilddir}/bin/hugo gen man`

		`@@ -188,6 +188,9 @@`


		`%changelog`
		`+ * Wed Mar 11 2020 W. Michael Petullo <mike@flyn.org> - 0.65.3-2`
		`+ - Build extended version`
		`+`
		`* Mon Feb 24 2020 Elliott Sales de Andrade <quantum.analyst@gmail.com> - 0.65.3-1`
		`- Update to latest version`

mikep commented 4 years ago

This is based on work by Panagiotiss (https://copr.fedorainfracloud.org/coprs/panagiotiss/hugo_extended/). Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1756202.

Signed-off-by: W. Michael Petullo mike@flyn.org

rebased onto 6975e30

4 years ago

athoscr commented 4 years ago

Could we generate a second binary for hugo-extended instead?

athoscr commented 4 years ago

Hi mike!

On a second though, I let's just ship the main binary with the extended capabilities.

Since this wont merge, I applied the changes. I will close this PR.

I also added you as an admin to this repo. You are now a co-maintainer of hugo. Feel free to push your changes to the repo and trigger new builds whenever needed!

Thanks!

Pull-Request has been closed by athoscr

4 years ago

thofmann commented 4 years ago

Thanks for providing the extended version of hugo?

Would it be possible to also build it for F31/F32?

athoscr commented 4 years ago

Pushed to f32: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d74df0d232

No objections on pushing to f31 as well. However, it would require updating a few dependencies there. Given f32 GA is almost here and that it would still take a few days for the package to reach the stable branch after the work would be complete. I do not think this is worth the effort.

If you really need the feature now and are not considering using the f32 beta package, you could join the go SIG and help porting the dependencies to f31.