#2 hypervkvpd.service: ordering fixes
Closed 2 months ago by vittyvk. Opened 2 months ago by cjp256.
rpms/ cjp256/hyperv-daemons kvpd-ordering  into  rawhide

hypervkvpd.service: ordering fixes
Chris Patterson • 2 months ago  
file modified
+5 -1
@@ -13,7 +13,7 @@ 

  

  Name:     hyperv-daemons

  Version:  0

- Release:  0.36%{?snapver}%{?dist}

+ Release:  0.37%{?snapver}%{?dist}

  Summary:  Hyper-V daemons suite

  

  License:  GPLv2
@@ -246,6 +246,10 @@ 

  %{_sbindir}/lsvmbus

  

  %changelog

+ * Fri Jul 01 2022 Chris Patterson <cpatterson@microsoft.com> - 0-0.37.20190303git

+ - Only start kvpd under Hyper-V

+ - Minimize dependencies for kvpd to ensure it starts before cloud-init

+ 

  * Thu Jan 20 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0-0.36.20190303git

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild

  

file modified
+4 -1
@@ -1,7 +1,10 @@ 

  [Unit]

  Description=Hyper-V KVP daemon

+ ConditionVirtualization=microsoft

Do we need to add the same to VSS/FCOPY daemons too?

  BindsTo=sys-devices-virtual-misc-vmbus\x21hv_kvp.device

- After=network.target

+ After=sys-devices-virtual-misc-vmbus\x21hv_kvp.device

+ RequiresMountsFor=/var/lib/hyperv

+ Before=cloud-init-local.service

  IgnoreOnIsolate=1

  

  [Service]

  • Only start kvpd under Hyper-V.

  • Minimize dependencies for kvpd by removing the unnecessary
    network.target requirement, but add kvp device and mount
    requirements.

  • Start before cloud-init-local.service which relies on kvpd
    for Azure.

Signed-off-by: Chris Patterson cpatterson@microsoft.com

Do we need to add the same to VSS/FCOPY daemons too?

The After=<applicable device> and ConditionVirtualization=microsoft may be useful for those too, but we would need to investigate further to make sure those changes aren't harmful.

Perhaps we can revisit that separately in the future?

I've merged these changes manually and I've split the commit into two: "ConditionVirtualization=microsoft" addition which I've added to all services and the rest. I've also updated source files to 5.19-rc6 to pick up the latest changes.

hyperv-daemons-0-0.37.20220710git.fc37 is on its way to rawhide.

Pull-Request has been closed by vittyvk

2 months ago
Metadata