#2 Regenerate PNG icons to fix transparency
Closed 4 years ago by mfabian. Opened 4 years ago by ferdnyc.
rpms/ ferdnyc/ibus-typing-booster iconfix  into  master

file modified
+18 -1
@@ -4,7 +4,7 @@ 

  

  Name:       ibus-typing-booster

  Version:    2.6.1

- Release:    1%{?dist}

+ Release:    2%{?dist}

  Summary:    A completion input method

  License:    GPLv3+, ASL 2.0

  URL:        https://mike-fabian.github.io/ibus-typing-booster/
@@ -62,6 +62,9 @@ 

  BuildRequires:  dconf

  BuildRequires:  dbus-x11

  BuildRequires:  ibus

+ # To regenerate icons

+ BuildRequires:  ImageMagick

+ BuildRequires:  inkscape

  BuildArch:  noarch

  

  %description
@@ -81,10 +84,21 @@ 

  

  

  %build

+ # Regenerate icons to fix transparency

+ # This is a temporary measure until the updated files can be upstreamed,

+ # see https://github.com/mike-fabian/ibus-typing-booster/pull/51

+ pushd icons

+ for size in 16 22 32 48 64 128 256; do

+   convert -background none -density 1024 -resize "${size}x${size}" \

+   ibus-typing-booster.svg -density 96 "${size}x${size}/ibus-typing-booster.png"

+ done

+ popd

+ 

  export PYTHON=%{__python3}

  %configure --disable-static --disable-additional

  make %{?_smp_mflags}

  

+ 

  %install 

  export PYTHON=%{__python3}

  make install DESTDIR=${RPM_BUILD_ROOT} NO_INDEX=true  INSTALL="install -p"   pkgconfigdir=%{_datadir}/pkgconfig
@@ -194,6 +208,9 @@ 

  

  

  %changelog

+ * Thu May 22 2019 FeRD (Frank Dana) <ferdnyc@gmail.com> - 2.6.1-2

+ - Regenerate PNG icons to fix transparency

+ 

  * Mon Mar 04 2019 Mike FABIAN <mfabian@redhat.com> - 2.6.1-1

  - Update to 2.6.1

  - Support emoji presentation and text presentation in emoji-picker

The icon files in the distro have poorly-defined transparent outlines, with visible aliasing that makes them render badly against a dark background. This PR regenerates the icons from the SVG source during the build process, as a temporary measure until the new icons can be upstreamed.

(Upstream PR: https://github.com/mike-fabian/ibus-typing-booster/pull/51)

This adds ImageMagick and Inkscape as temporary BuildRequires, because the icon generation is done via convert which will call inkscape as its SVG rendering delegate.

Metadata Update from @mfabian:
- Request assigned

4 years ago

1 new commit added

  • Move icon regeneration to start of build
4 years ago

I just pushed in one more commit to fix a boneheaded mistake.

(I originally had the icon regeneration happening after the install process, so the old versions were still being packaged. Now it's done right at the start of %build.)

The fedora package is updated to
https://github.com/mike-fabian/ibus-typing-booster/releases/tag/2.6.2
now which contains your fix.

Thank you!

Pull-Request has been closed by mfabian

4 years ago