#18 Switch to use py_byte_compile rpm macro
Closed a year ago by fujiwara. Opened a year ago by tdawson.
rpms/ tdawson/ibus master  into  master

file modified
-4
@@ -1,7 +1,3 @@ 

- # This package depends on automagic byte compilation

- # https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation_phase_2

- %global _python_bytecompile_extra 1

- 

  %if (0%{?fedora} > 29 || 0%{?rhel} > 7)

  %global with_python2 0

  %else

Fedora is now in phase 3 of bytecompilation
https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation_phase_3

ibus will not build in Fedora Rawhide (f33) without this change.

Signed-off-by: Troy Dawson tdawson@redhat.com

I still can see the byte compiled files in the ibus-setup package without both py_byte_compile and _python_bytecompile_extra?

1 new commit added

  • Clean pycache manually, without a script
a year ago

I apologize, I did not check.
You are correct. I had assumed that the script would take care of the cleanup.
I have changed it so that it manually cleans up the byte compiled file.

I don't understand your comment.
I assume %py_byte_compile generates pycache but it seems pycache is created during the build so you don't have to run %py_byte_compile and delete pycache but just deleting _python_bytecompile_extra would be enough.

1 new commit added

  • only remove _python_bytecompile_extra
a year ago

Sometimes a pull request is not the best way to communicate. I think this time I understand, and I hope this is what you want.

If it is not, I will not be offended if you create your own pull request to fix it properly.

Pull-Request has been closed by fujiwara

a year ago