|
Patrick Monnerat |
4078645 |
http://sourceware.org/ml/gdb-patches/2012-03/msg00358.html
|
|
Patrick Monnerat |
4078645 |
Subject: [patch 2/2] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #5
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
Hi,
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
here is the ON_STACK code again, with fixed alignment for i386 SSE.
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
It is generalized for all OSes on i386/amd64. I can move it to
|
|
Patrick Monnerat |
4078645 |
{i386,amd64)-linux-tdep.c but I find this code much more lightweight than
|
|
Patrick Monnerat |
4078645 |
i386_push_dummy_call which is already present in i386-tdep.
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
No regressions on
|
|
Patrick Monnerat |
4078645 |
{x86_64,x86_64-m32,i686}-fedora(15-rawhide)/rhel(5-6)-linux-gnu and for
|
|
Patrick Monnerat |
4078645 |
gdbsever non-extended mode.
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
For x86_64-fedora17-linux-gnu it fixes:
|
|
Patrick Monnerat |
4078645 |
-FAIL: gdb.cp/gdb2495.exp: Call a function that raises an exception without a handler.
|
|
Patrick Monnerat |
4078645 |
-FAIL: gdb.cp/gdb2495.exp: bt after returning from a popped frame
|
|
Patrick Monnerat |
4078645 |
+PASS: gdb.cp/gdb2495.exp: Call a function that raises an exception without a handler.
|
|
Patrick Monnerat |
4078645 |
+PASS: gdb.cp/gdb2495.exp: bt after returning from a popped frame
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
Thanks,
|
|
Patrick Monnerat |
4078645 |
Jan
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
gdb/
|
|
Patrick Monnerat |
4078645 |
2012-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
* amd64-dicos-tdep.c (amd64_dicos_push_dummy_code): Remove.
|
|
Patrick Monnerat |
4078645 |
(amd64_dicos_init_abi): Remove its installment.
|
|
Patrick Monnerat |
4078645 |
* dicos-tdep.c (dicos_init_abi): Remove the
|
|
Patrick Monnerat |
4078645 |
set_gdbarch_call_dummy_location call. Update the comment here.
|
|
Patrick Monnerat |
4078645 |
* i386-dicos-tdep.c (i386_dicos_push_dummy_code): Remove.
|
|
Patrick Monnerat |
4078645 |
(i386_dicos_init_abi): Remove its installment.
|
|
Patrick Monnerat |
4078645 |
* i386-tdep.c (i386_push_dummy_code): New function.
|
|
Patrick Monnerat |
4078645 |
(i386_gdbarch_init): Call set_gdbarch_call_dummy_location, install
|
|
Patrick Monnerat |
4078645 |
i386_push_dummy_code.
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
--- a/gdb/amd64-dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
+++ b/gdb/amd64-dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
@@ -23,24 +23,6 @@
|
|
Patrick Monnerat |
4078645 |
#include "amd64-tdep.h"
|
|
Patrick Monnerat |
4078645 |
#include "dicos-tdep.h"
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
-static CORE_ADDR
|
|
Patrick Monnerat |
4078645 |
-amd64_dicos_push_dummy_code (struct gdbarch *gdbarch,
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR sp, CORE_ADDR funaddr,
|
|
Patrick Monnerat |
4078645 |
- struct value **args, int nargs,
|
|
Patrick Monnerat |
4078645 |
- struct type *value_type,
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
|
|
Patrick Monnerat |
4078645 |
- struct regcache *regcache)
|
|
Patrick Monnerat |
4078645 |
-{
|
|
Patrick Monnerat |
4078645 |
- int bplen;
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR bppc = sp;
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- gdbarch_breakpoint_from_pc (gdbarch, &bppc, &bplen);
|
|
Patrick Monnerat |
4078645 |
- *bp_addr = sp - bplen;
|
|
Patrick Monnerat |
4078645 |
- *real_pc = funaddr;
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- return *bp_addr;
|
|
Patrick Monnerat |
4078645 |
-}
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
static void
|
|
Patrick Monnerat |
4078645 |
amd64_dicos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
Patrick Monnerat |
4078645 |
{
|
|
Patrick Monnerat |
4078645 |
@@ -49,8 +31,6 @@ amd64_dicos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
Patrick Monnerat |
4078645 |
amd64_init_abi (info, gdbarch);
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
dicos_init_abi (gdbarch);
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- set_gdbarch_push_dummy_code (gdbarch, amd64_dicos_push_dummy_code);
|
|
Patrick Monnerat |
4078645 |
}
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
static enum gdb_osabi
|
|
Patrick Monnerat |
4078645 |
--- a/gdb/dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
+++ b/gdb/dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
@@ -43,8 +43,8 @@ dicos_init_abi (struct gdbarch *gdbarch)
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
/* There's no (standard definition of) entry point or a guaranteed
|
|
Patrick Monnerat |
4078645 |
text location with a symbol where to place the call dummy, so we
|
|
Patrick Monnerat |
4078645 |
- put it on the stack. */
|
|
Patrick Monnerat |
4078645 |
- set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
|
|
Patrick Monnerat |
4078645 |
+ need it on the stack. Rely on i386_gdbarch_init used also for
|
|
Patrick Monnerat |
4078645 |
+ amd64 to set up ON_STACK inferior calls. */
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
/* DICOS rewinds the PC itself. */
|
|
Patrick Monnerat |
4078645 |
set_gdbarch_decr_pc_after_break (gdbarch, 0);
|
|
Patrick Monnerat |
4078645 |
--- a/gdb/i386-dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
+++ b/gdb/i386-dicos-tdep.c
|
|
Patrick Monnerat |
4078645 |
@@ -22,32 +22,12 @@
|
|
Patrick Monnerat |
4078645 |
#include "gdb_string.h"
|
|
Patrick Monnerat |
4078645 |
#include "dicos-tdep.h"
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
-static CORE_ADDR
|
|
Patrick Monnerat |
4078645 |
-i386_dicos_push_dummy_code (struct gdbarch *gdbarch,
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR sp, CORE_ADDR funaddr,
|
|
Patrick Monnerat |
4078645 |
- struct value **args, int nargs,
|
|
Patrick Monnerat |
4078645 |
- struct type *value_type,
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
|
|
Patrick Monnerat |
4078645 |
- struct regcache *regcache)
|
|
Patrick Monnerat |
4078645 |
-{
|
|
Patrick Monnerat |
4078645 |
- int bplen;
|
|
Patrick Monnerat |
4078645 |
- CORE_ADDR bppc = sp;
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- gdbarch_breakpoint_from_pc (gdbarch, &bppc, &bplen);
|
|
Patrick Monnerat |
4078645 |
- *bp_addr = sp - bplen;
|
|
Patrick Monnerat |
4078645 |
- *real_pc = funaddr;
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- return *bp_addr;
|
|
Patrick Monnerat |
4078645 |
-}
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
static void
|
|
Patrick Monnerat |
4078645 |
i386_dicos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
Patrick Monnerat |
4078645 |
{
|
|
Patrick Monnerat |
4078645 |
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
dicos_init_abi (gdbarch);
|
|
Patrick Monnerat |
4078645 |
-
|
|
Patrick Monnerat |
4078645 |
- set_gdbarch_push_dummy_code (gdbarch, i386_dicos_push_dummy_code);
|
|
Patrick Monnerat |
4078645 |
}
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
static enum gdb_osabi
|
|
Patrick Monnerat |
4078645 |
--- a/gdb/i386-tdep.c
|
|
Patrick Monnerat |
4078645 |
+++ b/gdb/i386-tdep.c
|
|
Patrick Monnerat |
4078645 |
@@ -2326,6 +2326,30 @@ i386_16_byte_align_p (struct type *type)
|
|
Patrick Monnerat |
4078645 |
return 0;
|
|
Patrick Monnerat |
4078645 |
}
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
+/* Implementation for set_gdbarch_push_dummy_code. */
|
|
Patrick Monnerat |
4078645 |
+
|
|
Patrick Monnerat |
4078645 |
+static CORE_ADDR
|
|
Patrick Monnerat |
4078645 |
+i386_push_dummy_code (struct gdbarch *gdbarch, CORE_ADDR sp, CORE_ADDR funaddr,
|
|
Patrick Monnerat |
4078645 |
+ struct value **args, int nargs, struct type *value_type,
|
|
Patrick Monnerat |
4078645 |
+ CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
|
|
Patrick Monnerat |
4078645 |
+ struct regcache *regcache)
|
|
Patrick Monnerat |
4078645 |
+{
|
|
Patrick Monnerat |
4078645 |
+ int bplen;
|
|
Patrick Monnerat |
4078645 |
+ CORE_ADDR bppc = sp;
|
|
Patrick Monnerat |
4078645 |
+
|
|
Patrick Monnerat |
4078645 |
+ gdbarch_breakpoint_from_pc (gdbarch, &bppc, &bplen);
|
|
Patrick Monnerat |
4078645 |
+ sp -= bplen;
|
|
Patrick Monnerat |
4078645 |
+
|
|
Patrick Monnerat |
4078645 |
+ /* amd64_push_dummy_call does alignment on its own but i386_push_dummy_call
|
|
Patrick Monnerat |
4078645 |
+ does not. ABI requires stack alignment for executables using SSE. */
|
|
Patrick Monnerat |
4078645 |
+ if (gdbarch_frame_align_p (gdbarch))
|
|
Patrick Monnerat |
4078645 |
+ sp = gdbarch_frame_align (gdbarch, sp);
|
|
Patrick Monnerat |
4078645 |
+
|
|
Patrick Monnerat |
4078645 |
+ *bp_addr = sp;
|
|
Patrick Monnerat |
4078645 |
+ *real_pc = funaddr;
|
|
Patrick Monnerat |
4078645 |
+ return sp;
|
|
Patrick Monnerat |
4078645 |
+}
|
|
Patrick Monnerat |
4078645 |
+
|
|
Patrick Monnerat |
4078645 |
static CORE_ADDR
|
|
Patrick Monnerat |
4078645 |
i386_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
|
|
Patrick Monnerat |
4078645 |
struct regcache *regcache, CORE_ADDR bp_addr, int nargs,
|
|
Patrick Monnerat |
4078645 |
@@ -7372,6 +7396,8 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
|
|
Patrick Monnerat |
4078645 |
set_gdbarch_get_longjmp_target (gdbarch, i386_get_longjmp_target);
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
/* Call dummy code. */
|
|
Patrick Monnerat |
4078645 |
+ set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
|
|
Patrick Monnerat |
4078645 |
+ set_gdbarch_push_dummy_code (gdbarch, i386_push_dummy_code);
|
|
Patrick Monnerat |
4078645 |
set_gdbarch_push_dummy_call (gdbarch, i386_push_dummy_call);
|
|
Patrick Monnerat |
4078645 |
set_gdbarch_frame_align (gdbarch, i386_frame_align);
|
|
Patrick Monnerat |
4078645 |
|
|
Patrick Monnerat |
4078645 |
|