#3 Add support for Jack properties
Merged 4 years ago by nphilipp. Opened 4 years ago by brunovernay.
Unknown source master  into  master

@@ -11,10 +11,10 @@

  Summary:       The Jack Audio Connection Kit

  Name:          jack-audio-connection-kit

  Version:       1.9.14

- Release:       2%{?dist}

+ Release:       3%{?dist}

  # The entire source (~500 files) is a mixture of these three licenses

  License:       GPLv2 and GPLv2+ and LGPLv2+

- URL:           http://www.jackaudio.org

+ URL:           https://www.jackaudio.org

  Source0:       https://github.com/jackaudio/jack2/releases/download/v%{version}/v%{version}.tar.gz#/jack2-%{version}.tar.gz

  Source1:       %{name}-README.Fedora

  Source2:       %{name}-script.pa
@@ -28,6 +28,8 @@

  

  BuildRequires: alsa-lib-devel

  BuildRequires: dbus-devel

+ # Berkeley DB v6 new licence (AGPLv3) is incompatible with GPLv2. https://en.wikipedia.org/wiki/Berkeley_DB#Licensing

+ BuildRequires: libdb-devel < 6.0.20

  BuildRequires: doxygen

  BuildRequires: expat-devel

  BuildRequires: gcc-c++
@@ -93,6 +95,7 @@

     --libdir=%{_libdir} \

     --doxygen \

     --dbus \

+    --db \

     --classic \

  %ifnarch s390 s390x

  %if !0%{?bootstrap} && !0%{?flatpak}
@@ -228,6 +231,9 @@

  

  

  %changelog

+ * Sat Mar 21 2020 Bruno Vernay <brunovern.a@gmail.com> - 1.9.14-3

+ - Add Berkley DB support for Jack properties

+ 

  * Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.9.14-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

Enabling Berkeley DB as Jack properties require them (Aliases are deprecated in Jack.)
This will also make the tests to pass.
Also uses HTTPS in URLs.

If someone knows how to configure Jack2 project in a IDE (Eclipse, Netbeans, whatever) I would be very interested.

Will this introduce any incompatibilities, e.g. with existing setups people might be using?

Berkeley DB will be dropped from Fedora soon I think

It should not introduce any incompatibilities.
Aliases might still be used alongside properties even if aliases are deprecated in Jack.

A quick search about Berkeley DB shows that
- Fedora will switch to Sqlite for RPM https://www.phoronix.com/scan.php?page=news_item&px=Fedora-RPMDB-To-SQLite
- keep multiples version available https://fedoraproject.org/wiki/Changes/BerkeleyDB_6

We don't seem to have Berkeley DB v6 (the one licensed AGPLv3+) yet, the change you linked never seems to have been completed.

However, as jack2 has parts licensed as GPLv2-only (which is incompatible with AGPLv3) we should prevent that it is ever built against the so-licensed libdb, should it become packaged in Fedora at some point. Please add < 6 to this line and a comment before it à la # The license of Berkeley DB v6 is incompatible with GPLv2.

@tartina, I haven't seen concrete plans to drop libdb from Fedora, but if it ever happens, we can just revert this change. For the time being, I think it's fine to have that feature -- we don't have quite the same stringent requirements as the RPM folks.

@tartina, I haven't seen concrete plans to drop libdb from Fedora, but if it ever happens, we can just revert this change. For the time being, I think it's fine to have that feature -- we don't have quite the same stringent requirements as the RPM folks.

I agree.
I thought RPM was the only packege to still use bdb, when they decided to switch to sqlite it seemed to me the end of bdb.
And we can revert if needed, so
+1 for me

1 new commit added

  • Avoid Berkeley DB version with new AGPL licence
4 years ago

I added the requested limitation to avoid AGPLv3 (precisely at < 6.0.20) according to Wikipedia.
Note that I am not so sure about "incompatibilities" https://en.wikipedia.org/wiki/Comparison_of_free_and_open-source_software_licenses but I do not want (nor can't ) debate this topic

Better to stay on the safe side anyway. I will also inform Jack2 about the alternatives (SQLite, LMDB ....)

Thankfully we don't have to debate this, as the legal types did this already and summarized it on the Licensing wiki page in the List of Good Licenses:

Full Name: Affero General Public License 3.0 or later
Short Name: AGPLv3+
FSF Free?: Yes
GPLv2 Compat?: NO
GPLv3 Compat?: Sortof
Upstream URL: http://www.fsf.org/licensing/licenses/agpl-3.0.html

Is there something I should do for this pull request?
Or are we waiting for some kind of monthly global release?

No, nothing for you to do, we just dropped the ball. Sorry and thanks for the contribution!

Pull-Request has been merged by nphilipp

4 years ago