#9 drop useless powermock build dependency
Merged 3 years ago by decathorpe. Opened 3 years ago by decathorpe.
Unknown source master  into  master

file modified
+10 -5
@@ -1,6 +1,6 @@

  Name:          jackson-databind

  Version:       2.11.2

- Release:       1%{?dist}

+ Release:       2%{?dist}

  Summary:       General data-binding package for Jackson (2.x)

  License:       ASL 2.0 and LGPLv2+

  
@@ -13,9 +13,7 @@

  BuildRequires:  mvn(com.fasterxml.jackson:jackson-base:pom:) >= %{version}

  BuildRequires:  mvn(com.google.code.maven-replacer-plugin:replacer)

  BuildRequires:  mvn(org.apache.felix:maven-bundle-plugin)

- BuildRequires:  mvn(org.powermock:powermock-api-mockito2)

- BuildRequires:  mvn(org.powermock:powermock-core)

- BuildRequires:  mvn(org.powermock:powermock-module-junit4)

+ BuildRequires:  mvn(org.mockito:mockito-core)

  

  BuildArch:      noarch

  
@@ -46,7 +44,11 @@

  rm src/test/java/com/fasterxml/jackson/databind/introspect/NoClassDefFoundWorkaroundTest.java

  %pom_xpath_remove pom:classpathDependencyExcludes

  

- # org.powermock.reflect.exceptions.FieldNotFoundException: Field 'fTestClass' was not found in class org.junit.internal.runners.MethodValidator.

+ # TestTypeFactoryWithClassLoader fails to compile

+ # - it's the only test that uses powermock, so drop the powermock dependencies

+ # - mockito is only transitively pulled in by powermock, so add it back

+ %pom_remove_dep org.powermock:

+ %pom_add_dep org.mockito:mockito-core::test

  rm src/test/java/com/fasterxml/jackson/databind/type/TestTypeFactoryWithClassLoader.java

  

  # Off test that require connection with the web
@@ -70,6 +72,9 @@

  %license LICENSE NOTICE

  

  %changelog

+ * Sun Aug 09 2020 Fabio Valentini <decathorpe@gmail.com> - 2.11.2-2

+ - Drop useless powermock build dependency.

+ 

  * Sat Aug 08 2020 Fabio Valentini <decathorpe@gmail.com> - 2.11.2-1

  - Update to version 2.11.2.

  

powermock is only required by one test file that we're dropping anyway because it's broken, so drop the powermock dependency entirely.

The changes look good and the CI returns green! :thumbsup:

Thanks for reviewing my changes!

Pull-Request has been merged by decathorpe

3 years ago