df67399
# HG changeset patch
df67399
# User andrew
df67399
# Date 1545198926 0
df67399
#      Wed Dec 19 05:55:26 2018 +0000
df67399
# Node ID f2cbd688824c128db7fa848c8732fb0ab3507776
df67399
# Parent  81f07f6d1f8b7b51b136d3974c61bc8bb513770c
df67399
PR3655: Allow use of system crypto policy to be disabled by the user
df67399
Summary: Read user overrides first so security.useSystemPropertiesFile can be disabled and add -Djava.security.disableSystemPropertiesFile
df67399
df67399
diff --git a/src/share/classes/javopenjdk.orig/jdk/security/Security.java openjdk/jdk/src/share/classes/java/security/Security.java
df67399
--- openjdk.orig/jdk/src/share/classes/java/security/Security.java
df67399
+++ openjdk/jdk/src/share/classes/java/security/Security.java
df67399
@@ -122,31 +122,6 @@
df67399
         }
df67399
 
df67399
         if ("true".equalsIgnoreCase(props.getProperty
df67399
-                ("security.useSystemPropertiesFile"))) {
df67399
-
df67399
-            // now load the system file, if it exists, so its values
df67399
-            // will win if they conflict with the earlier values
df67399
-            try (BufferedInputStream bis =
df67399
-                 new BufferedInputStream(new FileInputStream(SYSTEM_PROPERTIES))) {
df67399
-                props.load(bis);
df67399
-                loadedProps = true;
df67399
-
df67399
-                if (sdebug != null) {
df67399
-                    sdebug.println("reading system security properties file " +
df67399
-                                   SYSTEM_PROPERTIES);
df67399
-                    sdebug.println(props.toString());
df67399
-                }
df67399
-            } catch (IOException e) {
df67399
-                if (sdebug != null) {
df67399
-                    sdebug.println
df67399
-                        ("unable to load security properties from " +
df67399
-                         SYSTEM_PROPERTIES);
df67399
-                    e.printStackTrace();
df67399
-                }
df67399
-            }
df67399
-        }
df67399
-
df67399
-        if ("true".equalsIgnoreCase(props.getProperty
df67399
                 ("security.overridePropertiesFile"))) {
df67399
 
df67399
             String extraPropFile = System.getProperty
df67399
@@ -212,6 +187,33 @@
df67399
             }
df67399
         }
df67399
 
df67399
+        String disableSystemProps = System.getProperty("java.security.disableSystemPropertiesFile");
df67399
+        if (disableSystemProps == null &&
df67399
+            "true".equalsIgnoreCase(props.getProperty
df67399
+                ("security.useSystemPropertiesFile"))) {
df67399
+
df67399
+            // now load the system file, if it exists, so its values
df67399
+            // will win if they conflict with the earlier values
df67399
+            try (BufferedInputStream bis =
df67399
+                 new BufferedInputStream(new FileInputStream(SYSTEM_PROPERTIES))) {
df67399
+                props.load(bis);
df67399
+                loadedProps = true;
df67399
+
df67399
+                if (sdebug != null) {
df67399
+                    sdebug.println("reading system security properties file " +
df67399
+                                   SYSTEM_PROPERTIES);
df67399
+                    sdebug.println(props.toString());
df67399
+                }
df67399
+            } catch (IOException e) {
df67399
+                if (sdebug != null) {
df67399
+                    sdebug.println
df67399
+                        ("unable to load security properties from " +
df67399
+                         SYSTEM_PROPERTIES);
df67399
+                    e.printStackTrace();
df67399
+                }
df67399
+            }
df67399
+        }
df67399
+
df67399
         if (!loadedProps) {
df67399
             initializeStatic();
df67399
             if (sdebug != null) {