|
 |
c41960f |
From 3ce5852ec6add45a28fe1706e9163351940e905c Mon Sep 17 00:00:00 2001
|
|
|
c41960f |
From: Peter Jones <pjones@redhat.com>
|
|
|
c41960f |
Date: Mon, 2 Oct 2017 18:25:29 -0400
|
|
|
c41960f |
Subject: [PATCH 1/3] Make get_cert_list() not complain about cert lists that
|
|
|
c41960f |
aren't present.
|
|
|
c41960f |
|
|
|
c41960f |
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
|
c41960f |
---
|
|
|
2d62e0d |
security/integrity/platform_certs/load_uefi.c | 37 ++++++++++++++++++++++---------------
|
|
|
c41960f |
1 file changed, 22 insertions(+), 15 deletions(-)
|
|
|
c41960f |
|
|
|
2d62e0d |
diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
|
|
|
2d62e0d |
index 81b19c52832b..e188f3ecbce3 100644
|
|
|
2d62e0d |
--- a/security/integrity/platform_certs/load_uefi.c
|
|
|
2d62e0d |
+++ b/security/integrity/platform_certs/load_uefi.c
|
|
|
2d62e0d |
@@ -38,8 +38,8 @@ static __init bool uefi_check_ignore_db(void)
|
|
|
c41960f |
/*
|
|
|
c41960f |
* Get a certificate list blob from the named EFI variable.
|
|
|
c41960f |
*/
|
|
|
c41960f |
-static __init void *get_cert_list(efi_char16_t *name, efi_guid_t *guid,
|
|
|
c41960f |
- unsigned long *size)
|
|
|
c41960f |
+static __init int get_cert_list(efi_char16_t *name, efi_guid_t *guid,
|
|
|
2d62e0d |
+ unsigned long *size , void **cert_list)
|
|
|
c41960f |
{
|
|
|
c41960f |
efi_status_t status;
|
|
|
c41960f |
unsigned long lsize = 4;
|
|
|
2d62e0d |
@@ -47,24 +47,31 @@ static __init void *get_cert_list(efi_char16_t *name, efi_guid_t *guid,
|
|
|
c41960f |
void *db;
|
|
|
2d62e0d |
|
|
|
c41960f |
status = efi.get_variable(name, guid, NULL, &lsize, &tmpdb);
|
|
|
c41960f |
+ if (status == EFI_NOT_FOUND) {
|
|
|
c41960f |
+ *size = 0;
|
|
|
c41960f |
+ *cert_list = NULL;
|
|
|
c41960f |
+ return 0;
|
|
|
c41960f |
+ }
|
|
|
c41960f |
+
|
|
|
c41960f |
if (status != EFI_BUFFER_TOO_SMALL) {
|
|
|
c41960f |
pr_err("Couldn't get size: 0x%lx\n", status);
|
|
|
c41960f |
- return NULL;
|
|
|
c41960f |
+ return efi_status_to_err(status);
|
|
|
c41960f |
}
|
|
|
2d62e0d |
|
|
|
c41960f |
db = kmalloc(lsize, GFP_KERNEL);
|
|
|
2d62e0d |
if (!db)
|
|
|
c41960f |
- return NULL;
|
|
|
c41960f |
+ return -ENOMEM;
|
|
|
2d62e0d |
|
|
|
c41960f |
status = efi.get_variable(name, guid, NULL, &lsize, db);
|
|
|
c41960f |
if (status != EFI_SUCCESS) {
|
|
|
c41960f |
kfree(db);
|
|
|
c41960f |
pr_err("Error reading db var: 0x%lx\n", status);
|
|
|
c41960f |
- return NULL;
|
|
|
c41960f |
+ return efi_status_to_err(status);
|
|
|
c41960f |
}
|
|
|
2d62e0d |
|
|
|
c41960f |
*size = lsize;
|
|
|
c41960f |
- return db;
|
|
|
c41960f |
+ *cert_list = db;
|
|
|
c41960f |
+ return 0;
|
|
|
c41960f |
}
|
|
|
2d62e0d |
|
|
|
c41960f |
/*
|
|
|
2d62e0d |
@@ -153,10 +160,10 @@ static int __init load_uefi_certs(void)
|
|
|
c41960f |
* an error if we can't get them.
|
|
|
c41960f |
*/
|
|
|
c41960f |
if (!uefi_check_ignore_db()) {
|
|
|
c41960f |
- db = get_cert_list(L"db", &secure_var, &dbsize);
|
|
|
c41960f |
- if (!db) {
|
|
|
c41960f |
+ rc = get_cert_list(L"db", &secure_var, &dbsize, &db);
|
|
|
c41960f |
+ if (rc < 0) {
|
|
|
c41960f |
pr_err("MODSIGN: Couldn't get UEFI db list\n");
|
|
|
c41960f |
- } else {
|
|
|
c41960f |
+ } else if (dbsize != 0) {
|
|
|
c41960f |
rc = parse_efi_signature_list("UEFI:db",
|
|
|
2d62e0d |
db, dbsize, get_handler_for_db);
|
|
|
c41960f |
if (rc)
|
|
|
2d62e0d |
@@ -166,10 +173,10 @@ static int __init load_uefi_certs(void)
|
|
|
c41960f |
}
|
|
|
c41960f |
}
|
|
|
2d62e0d |
|
|
|
c41960f |
- mok = get_cert_list(L"MokListRT", &mok_var, &moksize);
|
|
|
c41960f |
- if (!mok) {
|
|
|
c41960f |
+ rc = get_cert_list(L"MokListRT", &mok_var, &moksize, &mok;;
|
|
|
c41960f |
+ if (rc < 0) {
|
|
|
2d62e0d |
pr_info("Couldn't get UEFI MokListRT\n");
|
|
|
c41960f |
- } else {
|
|
|
c41960f |
+ } else if (moksize != 0) {
|
|
|
c41960f |
rc = parse_efi_signature_list("UEFI:MokListRT",
|
|
|
c41960f |
mok, moksize, get_handler_for_db);
|
|
|
c41960f |
if (rc)
|
|
|
2d62e0d |
@@ -177,10 +184,10 @@ static int __init load_uefi_certs(void)
|
|
|
c41960f |
kfree(mok);
|
|
|
c41960f |
}
|
|
|
2d62e0d |
|
|
|
c41960f |
- dbx = get_cert_list(L"dbx", &secure_var, &dbxsize);
|
|
|
c41960f |
- if (!dbx) {
|
|
|
c41960f |
+ rc = get_cert_list(L"dbx", &secure_var, &dbxsize, &dbx;;
|
|
|
c41960f |
+ if (rc < 0) {
|
|
|
2d62e0d |
pr_info("Couldn't get UEFI dbx list\n");
|
|
|
c41960f |
- } else {
|
|
|
c41960f |
+ } else if (dbxsize != 0) {
|
|
|
c41960f |
rc = parse_efi_signature_list("UEFI:dbx",
|
|
|
c41960f |
dbx, dbxsize,
|
|
|
c41960f |
get_handler_for_dbx);
|