|
 |
7d2c2f2 |
From 73a35468564f4e47deade0a4a5eb7ec289611ebc Mon Sep 17 00:00:00 2001
|
|
|
7d2c2f2 |
From: Matt Roper <matthew.d.roper@intel.com>
|
|
|
7d2c2f2 |
Date: Thu, 12 May 2016 07:06:11 -0700
|
|
|
7d2c2f2 |
Subject: [PATCH 17/17] drm/i915: Remove wm_config from
|
|
|
7d2c2f2 |
dev_priv/intel_atomic_state
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
We calculate the watermark config into intel_atomic_state and then save
|
|
|
7d2c2f2 |
it into dev_priv, but never actually use it from there. This is
|
|
|
7d2c2f2 |
left-over from some early ILK-style watermark programming designs that
|
|
|
7d2c2f2 |
got changed over time.
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
|
|
|
7d2c2f2 |
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
|
7d2c2f2 |
Link: http://patchwork.freedesktop.org/patch/msgid/1463061971-19638-18-git-send-email-matthew.d.roper@intel.com
|
|
|
7d2c2f2 |
---
|
|
|
7d2c2f2 |
drivers/gpu/drm/i915/i915_drv.h | 3 ---
|
|
|
7d2c2f2 |
drivers/gpu/drm/i915/intel_display.c | 31 -------------------------------
|
|
|
7d2c2f2 |
drivers/gpu/drm/i915/intel_drv.h | 1 -
|
|
|
7d2c2f2 |
3 files changed, 35 deletions(-)
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
|
|
|
7d2c2f2 |
index e7bde72..608f8e4 100644
|
|
|
7d2c2f2 |
--- a/drivers/gpu/drm/i915/i915_drv.h
|
|
|
7d2c2f2 |
+++ b/drivers/gpu/drm/i915/i915_drv.h
|
|
|
7d2c2f2 |
@@ -1961,9 +1961,6 @@ struct drm_i915_private {
|
|
|
7d2c2f2 |
*/
|
|
|
7d2c2f2 |
uint16_t skl_latency[8];
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
- /* Committed wm config */
|
|
|
7d2c2f2 |
- struct intel_wm_config config;
|
|
|
7d2c2f2 |
-
|
|
|
7d2c2f2 |
/*
|
|
|
7d2c2f2 |
* The skl_wm_values structure is a bit too big for stack
|
|
|
7d2c2f2 |
* allocation, so we keep the staging struct where we store
|
|
|
7d2c2f2 |
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
|
|
|
7d2c2f2 |
index a75daac..9c109c6 100644
|
|
|
7d2c2f2 |
--- a/drivers/gpu/drm/i915/intel_display.c
|
|
|
7d2c2f2 |
+++ b/drivers/gpu/drm/i915/intel_display.c
|
|
|
7d2c2f2 |
@@ -13343,35 +13343,6 @@ static int calc_watermark_data(struct drm_atomic_state *state)
|
|
|
7d2c2f2 |
{
|
|
|
7d2c2f2 |
struct drm_device *dev = state->dev;
|
|
|
7d2c2f2 |
struct drm_i915_private *dev_priv = to_i915(dev);
|
|
|
7d2c2f2 |
- struct intel_atomic_state *intel_state = to_intel_atomic_state(state);
|
|
|
7d2c2f2 |
- struct drm_crtc *crtc;
|
|
|
7d2c2f2 |
- struct drm_crtc_state *cstate;
|
|
|
7d2c2f2 |
- struct drm_plane *plane;
|
|
|
7d2c2f2 |
- struct drm_plane_state *pstate;
|
|
|
7d2c2f2 |
-
|
|
|
7d2c2f2 |
- /*
|
|
|
7d2c2f2 |
- * Calculate watermark configuration details now that derived
|
|
|
7d2c2f2 |
- * plane/crtc state is all properly updated.
|
|
|
7d2c2f2 |
- */
|
|
|
7d2c2f2 |
- drm_for_each_crtc(crtc, dev) {
|
|
|
7d2c2f2 |
- cstate = drm_atomic_get_existing_crtc_state(state, crtc) ?:
|
|
|
7d2c2f2 |
- crtc->state;
|
|
|
7d2c2f2 |
-
|
|
|
7d2c2f2 |
- if (cstate->active)
|
|
|
7d2c2f2 |
- intel_state->wm_config.num_pipes_active++;
|
|
|
7d2c2f2 |
- }
|
|
|
7d2c2f2 |
- drm_for_each_legacy_plane(plane, dev) {
|
|
|
7d2c2f2 |
- pstate = drm_atomic_get_existing_plane_state(state, plane) ?:
|
|
|
7d2c2f2 |
- plane->state;
|
|
|
7d2c2f2 |
-
|
|
|
7d2c2f2 |
- if (!to_intel_plane_state(pstate)->visible)
|
|
|
7d2c2f2 |
- continue;
|
|
|
7d2c2f2 |
-
|
|
|
7d2c2f2 |
- intel_state->wm_config.sprites_enabled = true;
|
|
|
7d2c2f2 |
- if (pstate->crtc_w != pstate->src_w >> 16 ||
|
|
|
7d2c2f2 |
- pstate->crtc_h != pstate->src_h >> 16)
|
|
|
7d2c2f2 |
- intel_state->wm_config.sprites_scaled = true;
|
|
|
7d2c2f2 |
- }
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
/* Is there platform-specific watermark information to calculate? */
|
|
|
7d2c2f2 |
if (dev_priv->display.compute_global_watermarks)
|
|
|
7d2c2f2 |
@@ -13625,7 +13596,6 @@ static int intel_atomic_commit(struct drm_device *dev,
|
|
|
7d2c2f2 |
}
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
drm_atomic_helper_swap_state(dev, state);
|
|
|
7d2c2f2 |
- dev_priv->wm.config = intel_state->wm_config;
|
|
|
7d2c2f2 |
dev_priv->wm.distrust_bios_wm = false;
|
|
|
7d2c2f2 |
dev_priv->wm.skl_results = intel_state->wm_results;
|
|
|
7d2c2f2 |
intel_shared_dpll_commit(state);
|
|
|
7d2c2f2 |
@@ -15405,7 +15375,6 @@ retry:
|
|
|
7d2c2f2 |
}
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
/* Write calculated watermark values back */
|
|
|
7d2c2f2 |
- to_i915(dev)->wm.config = to_intel_atomic_state(state)->wm_config;
|
|
|
7d2c2f2 |
for_each_crtc_in_state(state, crtc, cstate, i) {
|
|
|
7d2c2f2 |
struct intel_crtc_state *cs = to_intel_crtc_state(cstate);
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
|
|
|
7d2c2f2 |
index ab0be7a..8d73c20 100644
|
|
|
7d2c2f2 |
--- a/drivers/gpu/drm/i915/intel_drv.h
|
|
|
7d2c2f2 |
+++ b/drivers/gpu/drm/i915/intel_drv.h
|
|
|
7d2c2f2 |
@@ -305,7 +305,6 @@ struct intel_atomic_state {
|
|
|
7d2c2f2 |
unsigned int min_pixclk[I915_MAX_PIPES];
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
struct intel_shared_dpll_config shared_dpll[I915_NUM_PLLS];
|
|
|
7d2c2f2 |
- struct intel_wm_config wm_config;
|
|
|
7d2c2f2 |
|
|
|
7d2c2f2 |
/*
|
|
|
7d2c2f2 |
* Current watermarks can't be trusted during hardware readout, so
|
|
|
7d2c2f2 |
--
|
|
|
7d2c2f2 |
2.7.4
|
|
|
7d2c2f2 |
|