Jeremy Cline 5e02444
From dbdda4277cf0422a9ccb7ea98d0263c3cdbecdf6 Mon Sep 17 00:00:00 2001
Jeremy Cline 5e02444
From: Mark Salter <msalter@redhat.com>
Jeremy Cline 5e02444
Date: Tue, 8 May 2018 21:54:39 -0400
Jeremy Cline 5e02444
Subject: [PATCH] ACPI / irq: Workaround firmware issue on X-Gene based
Jeremy Cline 5e02444
 m400
Jeremy Cline 5e02444
Jeremy Cline 5e02444
The ACPI firmware on the xgene-based m400 platorms erroneously
Jeremy Cline 5e02444
describes its UART interrupt as ACPI_PRODUCER rather than
Jeremy Cline 5e02444
ACPI_CONSUMER. This leads to the UART driver being unable to
Jeremy Cline 5e02444
find its interrupt and the kernel unable find a console.
Jeremy Cline 5e02444
Work around this by avoiding the producer/consumer check
Jeremy Cline 5e02444
for X-Gene UARTs.
Jeremy Cline 5e02444
Jeremy Cline 5e02444
Signed-off-by: Mark Salter <msalter@redhat.com>
Jeremy Cline 5e02444
---
Jeremy Cline 5e02444
 drivers/acpi/irq.c | 17 +++++++++++++++--
Jeremy Cline 5e02444
 1 file changed, 15 insertions(+), 2 deletions(-)
Jeremy Cline 5e02444
Jeremy Cline 5e02444
diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c
Jeremy Cline 5e02444
index 7c352cba0528..028c1a564cff 100644
Jeremy Cline 5e02444
--- a/drivers/acpi/irq.c
Jeremy Cline 5e02444
+++ b/drivers/acpi/irq.c
Jeremy Cline 5e02444
@@ -129,6 +129,7 @@ struct acpi_irq_parse_one_ctx {
Jeremy Cline 5e02444
 	unsigned int index;
Jeremy Cline 5e02444
 	unsigned long *res_flags;
Jeremy Cline 5e02444
 	struct irq_fwspec *fwspec;
Jeremy Cline 5e02444
+	bool skip_producer_check;
Jeremy Cline 5e02444
 };
Jeremy Cline 5e02444
 
Jeremy Cline 5e02444
 /**
Jeremy Cline 5e02444
@@ -200,7 +201,8 @@ static acpi_status acpi_irq_parse_one_cb(struct acpi_resource *ares,
Jeremy Cline 5e02444
 		return AE_CTRL_TERMINATE;
Jeremy Cline 5e02444
 	case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
Jeremy Cline 5e02444
 		eirq = &ares->data.extended_irq;
Jeremy Cline 5e02444
-		if (eirq->producer_consumer == ACPI_PRODUCER)
Jeremy Cline 5e02444
+		if (!ctx->skip_producer_check &&
Jeremy Cline 5e02444
+		    eirq->producer_consumer == ACPI_PRODUCER)
Jeremy Cline 5e02444
 			return AE_OK;
Jeremy Cline 5e02444
 		if (ctx->index >= eirq->interrupt_count) {
Jeremy Cline 5e02444
 			ctx->index -= eirq->interrupt_count;
Jeremy Cline 5e02444
@@ -235,8 +237,19 @@ static acpi_status acpi_irq_parse_one_cb(struct acpi_resource *ares,
Jeremy Cline 5e02444
 static int acpi_irq_parse_one(acpi_handle handle, unsigned int index,
Jeremy Cline 5e02444
 			      struct irq_fwspec *fwspec, unsigned long *flags)
Jeremy Cline 5e02444
 {
Jeremy Cline 5e02444
-	struct acpi_irq_parse_one_ctx ctx = { -EINVAL, index, flags, fwspec };
Jeremy Cline 5e02444
+	struct acpi_irq_parse_one_ctx ctx = { -EINVAL, index, flags, fwspec, false };
Jeremy Cline 5e02444
 
Jeremy Cline 5e02444
+	/*
Jeremy Cline 5e02444
+	 * Firmware on arm64-based HPE m400 platform incorrectly marks
Jeremy Cline 5e02444
+	 * its UART interrupt as ACPI_PRODUCER rather than ACPI_CONSUMER.
Jeremy Cline 5e02444
+	 * Don't do the producer/consumer check for that device.
Jeremy Cline 5e02444
+	 */
Jeremy Cline 5e02444
+	if (IS_ENABLED(CONFIG_ARM64)) {
Jeremy Cline 5e02444
+		struct acpi_device *adev = acpi_bus_get_acpi_device(handle);
Jeremy Cline 5e02444
+
Jeremy Cline 5e02444
+		if (adev && !strcmp(acpi_device_hid(adev), "APMC0D08"))
Jeremy Cline 5e02444
+			ctx.skip_producer_check = true;
Jeremy Cline 5e02444
+	}
Jeremy Cline 5e02444
 	acpi_walk_resources(handle, METHOD_NAME__CRS, acpi_irq_parse_one_cb, &ctx;;
Jeremy Cline 5e02444
 	return ctx.rc;
Jeremy Cline 5e02444
 }
Jeremy Cline 5e02444
-- 
Jeremy Cline 5e02444
2.17.0
Jeremy Cline 5e02444