|
 |
48f65f6 |
From 0621809e37936e7c2b3eac9165cf2aad7f9189eb Mon Sep 17 00:00:00 2001
|
|
|
48f65f6 |
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
|
|
|
48f65f6 |
Date: Mon, 3 Aug 2015 14:57:30 +0900
|
|
|
48f65f6 |
Subject: [PATCH] HID: hid-input: Fix accessing freed memory during device
|
|
|
48f65f6 |
disconnect
|
|
|
48f65f6 |
|
|
|
48f65f6 |
During unbinding the driver was dereferencing a pointer to memory
|
|
|
48f65f6 |
already freed by power_supply_unregister().
|
|
|
48f65f6 |
|
|
|
48f65f6 |
Driver was freeing its internal description of battery through pointers
|
|
|
48f65f6 |
stored in power_supply structure. However, because the core owns the
|
|
|
48f65f6 |
power supply instance, after calling power_supply_unregister() this
|
|
|
48f65f6 |
memory is freed and the driver cannot access these members.
|
|
|
48f65f6 |
|
|
|
48f65f6 |
Fix this by storing the pointer to internal description of battery in a
|
|
|
48f65f6 |
local variable before calling power_supply_unregister(), so the pointer
|
|
|
48f65f6 |
remains valid.
|
|
|
48f65f6 |
|
|
|
48f65f6 |
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
|
|
|
48f65f6 |
Reported-by: H.J. Lu <hjl.tools@gmail.com>
|
|
|
48f65f6 |
Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
|
|
|
48f65f6 |
Cc: <stable@vger.kernel.org>
|
|
|
48f65f6 |
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
|
|
|
48f65f6 |
Signed-off-by: Jiri Kosina <jkosina@suse.com>
|
|
|
48f65f6 |
---
|
|
|
48f65f6 |
drivers/hid/hid-input.c | 7 +++++--
|
|
|
48f65f6 |
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
|
48f65f6 |
|
|
|
48f65f6 |
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
|
|
|
48f65f6 |
index 3511bbab..e3c6364 100644
|
|
|
48f65f6 |
--- a/drivers/hid/hid-input.c
|
|
|
48f65f6 |
+++ b/drivers/hid/hid-input.c
|
|
|
48f65f6 |
@@ -462,12 +462,15 @@ out:
|
|
|
48f65f6 |
|
|
|
48f65f6 |
static void hidinput_cleanup_battery(struct hid_device *dev)
|
|
|
48f65f6 |
{
|
|
|
48f65f6 |
+ const struct power_supply_desc *psy_desc;
|
|
|
48f65f6 |
+
|
|
|
48f65f6 |
if (!dev->battery)
|
|
|
48f65f6 |
return;
|
|
|
48f65f6 |
|
|
|
48f65f6 |
+ psy_desc = dev->battery->desc;
|
|
|
48f65f6 |
power_supply_unregister(dev->battery);
|
|
|
48f65f6 |
- kfree(dev->battery->desc->name);
|
|
|
48f65f6 |
- kfree(dev->battery->desc);
|
|
|
48f65f6 |
+ kfree(psy_desc->name);
|
|
|
48f65f6 |
+ kfree(psy_desc);
|
|
|
48f65f6 |
dev->battery = NULL;
|
|
|
48f65f6 |
}
|
|
|
48f65f6 |
#else /* !CONFIG_HID_BATTERY_STRENGTH */
|
|
|
48f65f6 |
--
|
|
|
48f65f6 |
2.4.3
|
|
|
48f65f6 |
|