e5e1555
From 82a50018782f84e733e718d4b24e1653d19333be Mon Sep 17 00:00:00 2001
e5e1555
From: Dan Carpenter <dan.carpenter@oracle.com>
e5e1555
Date: Wed, 15 Jun 2016 09:31:45 -0400
e5e1555
Subject: [PATCH] KEYS: potential uninitialized variable
e5e1555
e5e1555
If __key_link_begin() failed then "edit" would be uninitialized.  I've
e5e1555
added a check to fix that.
e5e1555
e5e1555
Fixes: f70e2e06196a ('KEYS: Do preallocation for __key_link()')
e5e1555
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
e5e1555
---
e5e1555
 security/keys/key.c | 2 +-
e5e1555
 1 file changed, 1 insertion(+), 1 deletion(-)
e5e1555
e5e1555
diff --git a/security/keys/key.c b/security/keys/key.c
e5e1555
index bd5a272f28a6..346fbf201c22 100644
e5e1555
--- a/security/keys/key.c
e5e1555
+++ b/security/keys/key.c
e5e1555
@@ -597,7 +597,7 @@ int key_reject_and_link(struct key *key,
e5e1555
 
e5e1555
 	mutex_unlock(&key_construction_mutex);
e5e1555
 
e5e1555
-	if (keyring)
e5e1555
+	if (keyring && link_ret == 0)
e5e1555
 		__key_link_end(keyring, &key->index_key, edit);
e5e1555
 
e5e1555
 	/* wake up anyone waiting for a key to be constructed */
e5e1555
-- 
e5e1555
2.5.5
e5e1555