|
 |
569d051 |
Bugzilla: 1047892
|
|
|
569d051 |
Upstream-status: Submitted for 3.14
|
|
|
569d051 |
|
|
|
569d051 |
Path: news.gmane.org!not-for-mail
|
|
|
569d051 |
From: Marcelo Tosatti <mtosatti@redhat.com>
|
|
|
569d051 |
Newsgroups: gmane.comp.emulators.kvm.devel
|
|
|
569d051 |
Subject: KVM: VMX: fix use after free of vmx->loaded_vmcs
|
|
|
569d051 |
Date: Fri, 3 Jan 2014 17:00:51 -0200
|
|
|
569d051 |
Lines: 31
|
|
|
569d051 |
Approved: news@gmane.org
|
|
|
569d051 |
Message-ID: <20140103190051.GA16151@amt.cnet>
|
|
|
569d051 |
NNTP-Posting-Host: plane.gmane.org
|
|
|
569d051 |
Mime-Version: 1.0
|
|
|
569d051 |
Content-Type: text/plain; charset=us-ascii
|
|
|
569d051 |
X-Trace: ger.gmane.org 1388775805 10008 80.91.229.3 (3 Jan 2014 19:03:25 GMT)
|
|
|
569d051 |
X-Complaints-To: usenet@ger.gmane.org
|
|
|
569d051 |
NNTP-Posting-Date: Fri, 3 Jan 2014 19:03:25 +0000 (UTC)
|
|
|
569d051 |
Cc: Jan Kiszka <jan.kiszka@web.de>, Paolo Bonzini <pbonzini@redhat.com>
|
|
|
569d051 |
To: kvm-devel <kvm@vger.kernel.org>
|
|
|
569d051 |
Original-X-From: kvm-owner@vger.kernel.org Fri Jan 03 20:03:30 2014
|
|
|
569d051 |
Return-path: <kvm-owner@vger.kernel.org>
|
|
|
569d051 |
Envelope-to: gcekd-kvm-devel@plane.gmane.org
|
|
|
569d051 |
Original-Received: from vger.kernel.org ([209.132.180.67])
|
|
|
569d051 |
by plane.gmane.org with esmtp (Exim 4.69)
|
|
|
569d051 |
(envelope-from <kvm-owner@vger.kernel.org>)
|
|
|
569d051 |
id 1VzA1p-0000BI-F0
|
|
|
569d051 |
for gcekd-kvm-devel@plane.gmane.org; Fri, 03 Jan 2014 20:03:29 +0100
|
|
|
569d051 |
Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
|
|
569d051 |
id S1752819AbaACTDZ (ORCPT <rfc822;gcekd-kvm-devel@m.gmane.org>);
|
|
|
569d051 |
Fri, 3 Jan 2014 14:03:25 -0500
|
|
|
569d051 |
Original-Received: from mx1.redhat.com ([209.132.183.28]:26936 "EHLO mx1.redhat.com"
|
|
|
569d051 |
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
|
|
|
569d051 |
id S1751681AbaACTDY (ORCPT <rfc822;kvm@vger.kernel.org>);
|
|
|
569d051 |
Fri, 3 Jan 2014 14:03:24 -0500
|
|
|
569d051 |
Original-Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
|
|
|
569d051 |
by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s03J3NIr007205
|
|
|
569d051 |
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
|
|
|
569d051 |
Fri, 3 Jan 2014 14:03:24 -0500
|
|
|
569d051 |
Original-Received: from amt.cnet (vpn1-4-118.gru2.redhat.com [10.97.4.118])
|
|
|
569d051 |
by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s03J3Mxl004396;
|
|
|
569d051 |
Fri, 3 Jan 2014 14:03:23 -0500
|
|
|
569d051 |
Original-Received: from amt.cnet (localhost [127.0.0.1])
|
|
|
569d051 |
by amt.cnet (Postfix) with ESMTP id 98901104ADF;
|
|
|
569d051 |
Fri, 3 Jan 2014 17:00:53 -0200 (BRST)
|
|
|
569d051 |
Original-Received: (from marcelo@localhost)
|
|
|
569d051 |
by amt.cnet (8.14.6/8.14.6/Submit) id s03J0pCL016186;
|
|
|
569d051 |
Fri, 3 Jan 2014 17:00:51 -0200
|
|
|
569d051 |
Content-Disposition: inline
|
|
|
569d051 |
User-Agent: Mutt/1.5.21 (2010-09-15)
|
|
|
569d051 |
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11
|
|
|
569d051 |
Original-Sender: kvm-owner@vger.kernel.org
|
|
|
569d051 |
Precedence: bulk
|
|
|
569d051 |
List-ID: <kvm.vger.kernel.org>
|
|
|
569d051 |
X-Mailing-List: kvm@vger.kernel.org
|
|
|
569d051 |
Xref: news.gmane.org gmane.comp.emulators.kvm.devel:117837
|
|
|
569d051 |
Archived-At: <http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/117837>
|
|
|
569d051 |
|
|
|
569d051 |
|
|
|
569d051 |
After free_loaded_vmcs executes, the "loaded_vmcs" structure
|
|
|
569d051 |
is kfreed, and now vmx->loaded_vmcs points to a kfreed area.
|
|
|
569d051 |
Subsequent free_loaded_vmcs then attempts to manipulate
|
|
|
569d051 |
vmx->loaded_vmcs.
|
|
|
569d051 |
|
|
|
569d051 |
Switch the order to avoid the problem.
|
|
|
569d051 |
|
|
|
569d051 |
https://bugzilla.redhat.com/show_bug.cgi?id=1047892
|
|
|
569d051 |
|
|
|
569d051 |
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
|
|
|
569d051 |
|
|
|
569d051 |
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
|
|
|
569d051 |
index da7837e..2efa33f0 100644
|
|
|
569d051 |
--- a/arch/x86/kvm/vmx.c
|
|
|
569d051 |
+++ b/arch/x86/kvm/vmx.c
|
|
|
569d051 |
@@ -7332,8 +7332,8 @@ static void vmx_free_vcpu(struct kvm_vcpu *vcpu)
|
|
|
569d051 |
struct vcpu_vmx *vmx = to_vmx(vcpu);
|
|
|
569d051 |
|
|
|
569d051 |
free_vpid(vmx);
|
|
|
569d051 |
- free_nested(vmx);
|
|
|
569d051 |
free_loaded_vmcs(vmx->loaded_vmcs);
|
|
|
569d051 |
+ free_nested(vmx);
|
|
|
569d051 |
kfree(vmx->guest_msrs);
|
|
|
569d051 |
kvm_vcpu_uninit(vcpu);
|
|
|
569d051 |
kmem_cache_free(kvm_vcpu_cache, vmx);
|
|
|
569d051 |
--
|
|
|
569d051 |
To unsubscribe from this list: send the line "unsubscribe kvm" in
|
|
|
569d051 |
the body of a message to majordomo@vger.kernel.org
|
|
|
569d051 |
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
|
|
569d051 |
|