272a38d
From 9f1958a0cc911e1f79b2733ee5029dbd819ff328 Mon Sep 17 00:00:00 2001
d07b889
From: Josh Boyer <jwboyer@fedoraproject.org>
272a38d
Date: Fri, 5 May 2017 08:21:59 +0100
272a38d
Subject: [PATCH 4/4] MODSIGN: Allow the "db" UEFI variable to be suppressed
d07b889
d07b889
If a user tells shim to not use the certs/hashes in the UEFI db variable
272a38d
for verification purposes, shim will set a UEFI variable called
272a38d
MokIgnoreDB.  Have the uefi import code look for this and ignore the db
272a38d
variable if it is found.
d07b889
d07b889
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
272a38d
Signed-off-by: David Howells <dhowells@redhat.com>
d07b889
---
272a38d
 certs/load_uefi.c | 44 ++++++++++++++++++++++++++++++++++----------
272a38d
 1 file changed, 34 insertions(+), 10 deletions(-)
d07b889
272a38d
diff --git a/certs/load_uefi.c b/certs/load_uefi.c
272a38d
index b44e464..3d88459 100644
272a38d
--- a/certs/load_uefi.c
272a38d
+++ b/certs/load_uefi.c
272a38d
@@ -13,6 +13,26 @@ static __initdata efi_guid_t efi_cert_x509_sha256_guid = EFI_CERT_X509_SHA256_GU
272a38d
 static __initdata efi_guid_t efi_cert_sha256_guid = EFI_CERT_SHA256_GUID;
272a38d
272a38d
 /*
272a38d
+ * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
272a38d
+ * it does.
272a38d
+ *
272a38d
+ * This UEFI variable is set by the shim if a user tells the shim to not use
272a38d
+ * the certs/hashes in the UEFI db variable for verification purposes.  If it
272a38d
+ * is set, we should ignore the db variable also and the true return indicates
272a38d
+ * this.
272a38d
+ */
272a38d
+static __init bool uefi_check_ignore_db(void)
d07b889
+{
d07b889
+	efi_status_t status;
d07b889
+	unsigned int db = 0;
d07b889
+	unsigned long size = sizeof(db);
d07b889
+	efi_guid_t guid = EFI_SHIM_LOCK_GUID;
d07b889
+
d07b889
+	status = efi.get_variable(L"MokIgnoreDB", &guid, NULL, &size, &db);
272a38d
+	return status == EFI_SUCCESS;
d07b889
+}
d07b889
+
272a38d
+/*
272a38d
  * Get a certificate list blob from the named EFI variable.
272a38d
  */
272a38d
 static __init void *get_cert_list(efi_char16_t *name, efi_guid_t *guid,
272a38d
@@ -113,7 +133,9 @@ static __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_ty
272a38d
 }
272a38d
272a38d
 /*
272a38d
- * Load the certs contained in the UEFI databases
272a38d
+ * Load the certs contained in the UEFI databases into the secondary trusted
272a38d
+ * keyring and the UEFI blacklisted X.509 cert SHA256 hashes into the blacklist
272a38d
+ * keyring.
272a38d
  */
272a38d
 static int __init load_uefi_certs(void)
d07b889
 {
272a38d
@@ -129,15 +151,17 @@ static int __init load_uefi_certs(void)
d07b889
 	/* Get db, MokListRT, and dbx.  They might not exist, so it isn't
d07b889
 	 * an error if we can't get them.
d07b889
 	 */
d07b889
-	db = get_cert_list(L"db", &secure_var, &dbsize);
d07b889
-	if (!db) {
d07b889
-		pr_err("MODSIGN: Couldn't get UEFI db list\n");
d07b889
-	} else {
272a38d
-		rc = parse_efi_signature_list("UEFI:db",
272a38d
-					      db, dbsize, get_handler_for_db);
d07b889
-		if (rc)
d07b889
-			pr_err("Couldn't parse db signatures: %d\n", rc);
d07b889
-		kfree(db);
272a38d
+	if (!uefi_check_ignore_db()) {
d07b889
+		db = get_cert_list(L"db", &secure_var, &dbsize);
d07b889
+		if (!db) {
d07b889
+			pr_err("MODSIGN: Couldn't get UEFI db list\n");
d07b889
+		} else {
272a38d
+			rc = parse_efi_signature_list("UEFI:db",
272a38d
+						      db, dbsize, get_handler_for_db);
d07b889
+			if (rc)
d07b889
+				pr_err("Couldn't parse db signatures: %d\n", rc);
d07b889
+			kfree(db);
d07b889
+		}
d07b889
 	}
272a38d
d07b889
 	mok = get_cert_list(L"MokListRT", &mok_var, &moksize);
f70c487
-- 
a98ed5c
2.9.3
f70c487