|
 |
4ff7e47 |
From patchwork Mon Apr 20 16:43:04 2020
|
|
|
4ff7e47 |
Content-Type: text/plain; charset="utf-8"
|
|
|
4ff7e47 |
MIME-Version: 1.0
|
|
|
4ff7e47 |
Content-Transfer-Encoding: 7bit
|
|
|
4ff7e47 |
X-Patchwork-Submitter: Nicolas Chauvet <kwizart@gmail.com>
|
|
|
4ff7e47 |
X-Patchwork-Id: 1273561
|
|
|
4ff7e47 |
Return-Path: <linux-tegra-owner@vger.kernel.org>
|
|
|
4ff7e47 |
X-Original-To: incoming@patchwork.ozlabs.org
|
|
|
4ff7e47 |
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
|
|
|
4ff7e47 |
Authentication-Results: ozlabs.org;
|
|
|
4ff7e47 |
spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org
|
|
|
4ff7e47 |
(client-ip=23.128.96.18; helo=vger.kernel.org;
|
|
|
4ff7e47 |
envelope-from=linux-tegra-owner@vger.kernel.org; receiver=<UNKNOWN>)
|
|
|
4ff7e47 |
Authentication-Results: ozlabs.org;
|
|
|
4ff7e47 |
dmarc=pass (p=none dis=none) header.from=gmail.com
|
|
|
4ff7e47 |
Authentication-Results: ozlabs.org; dkim=pass (2048-bit key;
|
|
|
4ff7e47 |
unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256
|
|
|
4ff7e47 |
header.s=20161025 header.b=TzeKBoiR; dkim-atps=neutral
|
|
|
4ff7e47 |
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
|
|
|
4ff7e47 |
by ozlabs.org (Postfix) with ESMTP id 495XZC49yWz9sP7
|
|
|
4ff7e47 |
for <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2020 02:43:15 +1000 (AEST)
|
|
|
4ff7e47 |
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
|
|
4ff7e47 |
id S1726731AbgDTQnK (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 12:43:10 -0400
|
|
|
4ff7e47 |
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42314 "EHLO
|
|
|
4ff7e47 |
lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
|
|
|
4ff7e47 |
by vger.kernel.org with ESMTP id S1726693AbgDTQnI (ORCPT
|
|
|
4ff7e47 |
<rfc822;linux-tegra@vger.kernel.org>);
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 12:43:08 -0400
|
|
|
4ff7e47 |
Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com
|
|
|
4ff7e47 |
[IPv6:2a00:1450:4864:20::342])
|
|
|
4ff7e47 |
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED4CC061A0C;
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 09:43:08 -0700 (PDT)
|
|
|
4ff7e47 |
Received: by mail-wm1-x342.google.com with SMTP id x25so280061wmc.0;
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 09:43:08 -0700 (PDT)
|
|
|
4ff7e47 |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
|
|
|
4ff7e47 |
h=from:to:cc:subject:date:message-id:mime-version
|
|
|
4ff7e47 |
:content-transfer-encoding;
|
|
|
4ff7e47 |
bh=IHuj1FiuJPknu8Z7Uq/JeXw8aSg2xFkcoVYT3QRT6dA=;
|
|
|
4ff7e47 |
b=TzeKBoiR2hu1L+OGuVzAMrvuOnCDM+J1nsGD1QbB9tkwdgx5rUc3jCkTzkFKQpJZ+g
|
|
|
4ff7e47 |
jx96zAcsJH7FSzAMjcpWTgiixmPWJj0xuWXML6IW4oVt5Npm6F2D8UyjZyfgnUKcGU/k
|
|
|
4ff7e47 |
Ye+bmwRUMi6cBC1Jpn93V5znfun/KPJFuOi1qLjh4g9rRAQWp4o4mZYTnxBkkMhi63gU
|
|
|
4ff7e47 |
V7L+RQlj4buS+IXOZ/xi5chAd/gFJkADDOm8HVDAcIG6pEUCkXciuRiNL3f81ss3nwjq
|
|
|
4ff7e47 |
uQQg7uRc8wXqOP1IqZ+W8kYP25Bty+uiykVyhv6XfOg0vWk4GK+wnM0wcP7boPe8Y8sS
|
|
|
4ff7e47 |
dTLg==
|
|
|
4ff7e47 |
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
|
|
4ff7e47 |
d=1e100.net; s=20161025;
|
|
|
4ff7e47 |
h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
|
|
|
4ff7e47 |
:content-transfer-encoding;
|
|
|
4ff7e47 |
bh=IHuj1FiuJPknu8Z7Uq/JeXw8aSg2xFkcoVYT3QRT6dA=;
|
|
|
4ff7e47 |
b=YcZCjbicKhCKe1SzKhwIcD9gZI/8J/QS/LQk4lcoLCwcSjlg9p0O/m5t80TGXT4lcn
|
|
|
4ff7e47 |
wFh0VyY+SsMR6uXCPrN8QXYbEY6fFVxEY2+btKzt+ft0v4jQUljopKGOV6n85FRs89U4
|
|
|
4ff7e47 |
DrjNPXoL7izbuheb/tW9ZBrrMTLQ1btIJ/MiAZ2gKtlrachezXQjW1Gtn66/hEpIQybL
|
|
|
4ff7e47 |
9ctDGvygIAju/Yd9fx+cakfzPUGzKTc/yOhjKjbMfxF6YxTbdqPc08+0a3cOYoSoRKLE
|
|
|
4ff7e47 |
i/drXsQpQhJHOhzZWXinld37vEHc/1pa/HYv3QR+UAproGfZq4eGqBh6cIYY87fW7nHk
|
|
|
4ff7e47 |
lsmg==
|
|
|
4ff7e47 |
X-Gm-Message-State: AGi0PuYqEn+eRXnjHmfYwoSYQUy0ZK+SX7Vpbgu/XErfwPhXok1ZAmWe
|
|
|
4ff7e47 |
N87IAyxXhJOQCMJxw6TgfSo=
|
|
|
4ff7e47 |
X-Google-Smtp-Source: APiQypLsj3XpHj4CyxtmOjlqdZs3DB8oJEEo2ghhT6QywH/SywA9LShfe1OCbQ3t6MmEGWRd+WIiVw==
|
|
|
4ff7e47 |
X-Received: by 2002:a1c:41d7:: with SMTP id o206mr194590wma.89.1587400987185;
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 09:43:07 -0700 (PDT)
|
|
|
4ff7e47 |
Received: from arrakis.kwizart.net (lfbn-nic-1-185-211.w2-15.abo.wanadoo.fr.
|
|
|
4ff7e47 |
[2.15.34.211])
|
|
|
4ff7e47 |
by smtp.gmail.com with ESMTPSA id l4sm47922wrv.60.2020.04.20.09.43.05
|
|
|
4ff7e47 |
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
|
|
|
4ff7e47 |
Mon, 20 Apr 2020 09:43:06 -0700 (PDT)
|
|
|
4ff7e47 |
From: Nicolas Chauvet <kwizart@gmail.com>
|
|
|
4ff7e47 |
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
|
|
|
4ff7e47 |
Thierry Reding <thierry.reding@gmail.com>,
|
|
|
4ff7e47 |
Jonathan Hunter <jonathanh@nvidia.com>
|
|
|
4ff7e47 |
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
|
|
|
4ff7e47 |
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
|
|
|
4ff7e47 |
Nicolas Chauvet <kwizart@gmail.com>
|
|
|
4ff7e47 |
Subject: [RFC] PCI: tegra: Revert raw_violation_fixup for tegra124
|
|
|
4ff7e47 |
Date: Mon, 20 Apr 2020 18:43:04 +0200
|
|
|
4ff7e47 |
Message-Id: <20200420164304.28810-1-kwizart@gmail.com>
|
|
|
4ff7e47 |
X-Mailer: git-send-email 2.25.2
|
|
|
4ff7e47 |
MIME-Version: 1.0
|
|
|
4ff7e47 |
Sender: linux-tegra-owner@vger.kernel.org
|
|
|
4ff7e47 |
Precedence: bulk
|
|
|
4ff7e47 |
List-ID: <linux-tegra.vger.kernel.org>
|
|
|
4ff7e47 |
X-Mailing-List: linux-tegra@vger.kernel.org
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
As reported in https://bugzilla.kernel.org/206217 , raw_violation_fixup
|
|
|
4ff7e47 |
is causing more harm than good in some common use-cases.
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
This patch as RFC is a partial revert of the 191cd6fb5 commit:
|
|
|
4ff7e47 |
"PCI: tegra: Add SW fixup for RAW violations"
|
|
|
4ff7e47 |
that was first introduced in 5.3 kernel.
|
|
|
4ff7e47 |
This fix the following regression since then.
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
When using both the network NIC and I/O on MMC this can lead to the
|
|
|
4ff7e47 |
following message on jetson-tk1:
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
NETDEV WATCHDOG: enp1s0 (r8169): transmit queue 0 timed out
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
and
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
pcieport 0000:00:02.0: AER: Uncorrected (Non-Fatal) error received: 0000:01:00.0
|
|
|
4ff7e47 |
r8169 0000:01:00.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID)
|
|
|
4ff7e47 |
r8169 0000:01:00.0: AER: device [10ec:8168] error status/mask=00004000/00400000
|
|
|
4ff7e47 |
r8169 0000:01:00.0: AER: [14] CmpltTO (First)
|
|
|
4ff7e47 |
r8169 0000:01:00.0: AER: can't recover (no error_detected callback)
|
|
|
4ff7e47 |
pcieport 0000:00:02.0: AER: device recovery failed
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
After that, the ethernet NIC isn't functional anymore even after reloading
|
|
|
4ff7e47 |
the module.
|
|
|
4ff7e47 |
After a reboot, this is reproducible by copying a large file over the
|
|
|
4ff7e47 |
ethernet NIC to the MMC.
|
|
|
4ff7e47 |
For some reasons this cannot be reproduced when the same file is copied
|
|
|
4ff7e47 |
to a tmpfs.
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
This patch is RFC because it requires more understanding from Nvidia.
|
|
|
4ff7e47 |
- Is the fixup (available in l4t downstrem) still needed for upstream ?
|
|
|
4ff7e47 |
- Is there a need to update the fixup values for upstream ?
|
|
|
4ff7e47 |
- If the fixup is reverted, does the hw bug can still be seen with
|
|
|
4ff7e47 |
upstream ?
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
Others can also provides more understanding:
|
|
|
4ff7e47 |
- Conditions to reproduce the bug (or not)...
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
|
|
|
4ff7e47 |
Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
|
|
|
4ff7e47 |
---
|
|
|
4ff7e47 |
drivers/pci/controller/pci-tegra.c | 2 +-
|
|
|
4ff7e47 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
4ff7e47 |
|
|
|
4ff7e47 |
diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
|
|
|
4ff7e47 |
index 3e64ba6a36a8..4027e074094a 100644
|
|
|
4ff7e47 |
--- a/drivers/pci/controller/pci-tegra.c
|
|
|
4ff7e47 |
+++ b/drivers/pci/controller/pci-tegra.c
|
|
|
4ff7e47 |
@@ -2470,7 +2470,7 @@ static const struct tegra_pcie_soc tegra124_pcie = {
|
|
|
4ff7e47 |
.program_uphy = true,
|
|
|
4ff7e47 |
.update_clamp_threshold = true,
|
|
|
4ff7e47 |
.program_deskew_time = false,
|
|
|
4ff7e47 |
- .raw_violation_fixup = true,
|
|
|
4ff7e47 |
+ .raw_violation_fixup = false,
|
|
|
4ff7e47 |
.update_fc_timer = false,
|
|
|
4ff7e47 |
.has_cache_bars = false,
|
|
|
4ff7e47 |
.ectl.enable = false,
|