Blame Restrict-dev-mem-and-dev-kmem-when-module-loading-is.patch
|
 |
6a91557 |
From: Matthew Garrett <matthew.garrett@nebula.com>
|
|
|
6a91557 |
Date: Fri, 9 Mar 2012 09:28:15 -0500
|
|
|
6a91557 |
Subject: [PATCH] Restrict /dev/mem and /dev/kmem when module loading is
|
|
|
6a91557 |
restricted
|
|
|
6a91557 |
|
|
|
6a91557 |
Allowing users to write to address space makes it possible for the kernel
|
|
|
6a91557 |
to be subverted, avoiding module loading restrictions. Prevent this when
|
|
|
6a91557 |
any restrictions have been imposed on loading modules.
|
|
|
6a91557 |
|
|
|
6a91557 |
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
|
|
|
6a91557 |
---
|
|
|
6a91557 |
drivers/char/mem.c | 6 ++++++
|
|
|
6a91557 |
1 file changed, 6 insertions(+)
|
|
|
6a91557 |
|
|
|
6a91557 |
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
|
|
|
6b37529 |
index c268e2581ed6..fb9ea1172ba8 100644
|
|
|
6a91557 |
--- a/drivers/char/mem.c
|
|
|
6a91557 |
+++ b/drivers/char/mem.c
|
|
|
6a91557 |
@@ -164,6 +164,9 @@ static ssize_t write_mem(struct file *file, const char __user *buf,
|
|
|
6a91557 |
if (p != *ppos)
|
|
|
6a91557 |
return -EFBIG;
|
|
|
6a91557 |
|
|
|
6a91557 |
+ if (secure_modules())
|
|
|
6a91557 |
+ return -EPERM;
|
|
|
6a91557 |
+
|
|
|
6a91557 |
if (!valid_phys_addr_range(p, count))
|
|
|
6a91557 |
return -EFAULT;
|
|
|
6a91557 |
|
|
|
6a91557 |
@@ -502,6 +505,9 @@ static ssize_t write_kmem(struct file *file, const char __user *buf,
|
|
|
6a91557 |
char *kbuf; /* k-addr because vwrite() takes vmlist_lock rwlock */
|
|
|
6a91557 |
int err = 0;
|
|
|
6a91557 |
|
|
|
6a91557 |
+ if (secure_modules())
|
|
|
6a91557 |
+ return -EPERM;
|
|
|
6a91557 |
+
|
|
|
6a91557 |
if (p < (unsigned long) high_memory) {
|
|
|
6a91557 |
unsigned long to_write = min_t(unsigned long, count,
|
|
|
6a91557 |
(unsigned long)high_memory - p);
|
|
|
6a91557 |
--
|
|
|
1e63a38 |
2.1.0
|
|
|
6a91557 |
|