|
 |
47ad3e2 |
From 7adc5cbc25dcc47dc3856108d9823d08da75da9d Mon Sep 17 00:00:00 2001
|
|
|
47ad3e2 |
From: Kangjie Lu <kangjielu@gmail.com>
|
|
|
47ad3e2 |
Date: Tue, 3 May 2016 16:32:16 -0400
|
|
|
47ad3e2 |
Subject: [PATCH] USB: usbfs: fix potential infoleak in devio
|
|
|
47ad3e2 |
MIME-Version: 1.0
|
|
|
47ad3e2 |
Content-Type: text/plain; charset=UTF-8
|
|
|
47ad3e2 |
Content-Transfer-Encoding: 8bit
|
|
|
47ad3e2 |
|
|
|
47ad3e2 |
The stack object “ci” has a total size of 8 bytes. Its last 3 bytes
|
|
|
47ad3e2 |
are padding bytes which are not initialized and leaked to userland
|
|
|
47ad3e2 |
via “copy_to_user”.
|
|
|
47ad3e2 |
|
|
|
47ad3e2 |
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
|
|
|
47ad3e2 |
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
|
47ad3e2 |
---
|
|
|
47ad3e2 |
drivers/usb/core/devio.c | 9 +++++----
|
|
|
47ad3e2 |
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
47ad3e2 |
|
|
|
47ad3e2 |
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
|
|
|
47ad3e2 |
index 52c4461dfccd..9b7f1f75e887 100644
|
|
|
47ad3e2 |
--- a/drivers/usb/core/devio.c
|
|
|
47ad3e2 |
+++ b/drivers/usb/core/devio.c
|
|
|
47ad3e2 |
@@ -1316,10 +1316,11 @@ static int proc_getdriver(struct usb_dev_state *ps, void __user *arg)
|
|
|
47ad3e2 |
|
|
|
47ad3e2 |
static int proc_connectinfo(struct usb_dev_state *ps, void __user *arg)
|
|
|
47ad3e2 |
{
|
|
|
47ad3e2 |
- struct usbdevfs_connectinfo ci = {
|
|
|
47ad3e2 |
- .devnum = ps->dev->devnum,
|
|
|
47ad3e2 |
- .slow = ps->dev->speed == USB_SPEED_LOW
|
|
|
47ad3e2 |
- };
|
|
|
47ad3e2 |
+ struct usbdevfs_connectinfo ci;
|
|
|
47ad3e2 |
+
|
|
|
47ad3e2 |
+ memset(&ci, 0, sizeof(ci));
|
|
|
47ad3e2 |
+ ci.devnum = ps->dev->devnum;
|
|
|
47ad3e2 |
+ ci.slow = ps->dev->speed == USB_SPEED_LOW;
|
|
|
47ad3e2 |
|
|
|
47ad3e2 |
if (copy_to_user(arg, &ci, sizeof(ci)))
|
|
|
47ad3e2 |
return -EFAULT;
|
|
|
47ad3e2 |
--
|
|
|
47ad3e2 |
2.5.5
|
|
|
47ad3e2 |
|