|
 |
4c6625a |
From 15ac2b08a2fd0f4aacbe8ae39788252fea6fbe63 Mon Sep 17 00:00:00 2001
|
|
|
4c6625a |
From: Xander Hover <LKML@hover.be>
|
|
|
4c6625a |
Date: Wed, 23 Nov 2011 16:40:31 -0500
|
|
|
4c6625a |
Subject: [PATCH] b44: Use dev_kfree_skb_irq() in b44_tx()
|
|
|
4c6625a |
|
|
|
4c6625a |
Reported issues when using dev_kfree_skb() on UP systems and
|
|
|
4c6625a |
systems with low numbers of cores. dev_kfree_skb_irq() will
|
|
|
4c6625a |
properly save IRQ state before freeing the skb.
|
|
|
4c6625a |
|
|
|
4c6625a |
Tested on 3.1.1 and 3.2_rc2
|
|
|
4c6625a |
|
|
|
4c6625a |
Example of reproducible trace of kernel 3.1.1
|
|
|
4c6625a |
------------[ cut here ]------------
|
|
|
4c6625a |
WARNING: at kernel/softirq.c:159 local_bh_enable+0x32/0x79()
|
|
|
4c6625a |
...
|
|
|
4c6625a |
Pid: 0, comm: swapper Not tainted 3.1.1-gentoo #1
|
|
|
4c6625a |
Call Trace:
|
|
|
4c6625a |
[<c1022970>] warn_slowpath_common+0x65/0x7a
|
|
|
4c6625a |
[<c102699e>] ? local_bh_enable+0x32/0x79
|
|
|
4c6625a |
[<c1022994>] warn_slowpath_null+0xf/0x13
|
|
|
4c6625a |
[<c102699e>] local_bh_enable+0x32/0x79
|
|
|
4c6625a |
[<c134bfd8>] destroy_conntrack+0x7c/0x9b
|
|
|
4c6625a |
[<c134890b>] nf_conntrack_destroy+0x1f/0x26
|
|
|
4c6625a |
[<c132e3a6>] skb_release_head_state+0x74/0x83
|
|
|
4c6625a |
[<c132e286>] __kfree_skb+0xb/0x6b
|
|
|
4c6625a |
[<c132e30a>] consume_skb+0x24/0x26
|
|
|
4c6625a |
[<c127c925>] b44_poll+0xaa/0x449
|
|
|
4c6625a |
[<c1333ca1>] net_rx_action+0x3f/0xea
|
|
|
4c6625a |
[<c1026a44>] __do_softirq+0x5f/0xd5
|
|
|
4c6625a |
[<c10269e5>] ? local_bh_enable+0x79/0x79
|
|
|
4c6625a |
<IRQ> [<c1026c32>] ? irq_exit+0x34/0x8d
|
|
|
4c6625a |
[<c1003628>] ? do_IRQ+0x74/0x87
|
|
|
4c6625a |
[<c13f5329>] ? common_interrupt+0x29/0x30
|
|
|
4c6625a |
[<c1006e18>] ? default_idle+0x29/0x3e
|
|
|
4c6625a |
[<c10015a7>] ? cpu_idle+0x2f/0x5d
|
|
|
4c6625a |
[<c13e91c5>] ? rest_init+0x79/0x7b
|
|
|
4c6625a |
[<c15c66a9>] ? start_kernel+0x297/0x29c
|
|
|
4c6625a |
[<c15c60b0>] ? i386_start_kernel+0xb0/0xb7
|
|
|
4c6625a |
---[ end trace 583f33bb1aa207a9 ]---
|
|
|
4c6625a |
|
|
|
4c6625a |
Signed-off-by: Xander Hover <LKML@hover.be>
|
|
|
4c6625a |
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
4c6625a |
---
|
|
|
4c6625a |
drivers/net/ethernet/broadcom/b44.c | 2 +-
|
|
|
4c6625a |
1 files changed, 1 insertions(+), 1 deletions(-)
|
|
|
4c6625a |
|
|
|
4c6625a |
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
|
|
|
4c6625a |
index 4cf835d..3fb66d0 100644
|
|
|
4c6625a |
--- a/drivers/net/b44.c
|
|
|
4c6625a |
+++ b/drivers/net/b44.c
|
|
|
4c6625a |
@@ -608,7 +608,7 @@ static void b44_tx(struct b44 *bp)
|
|
|
4c6625a |
skb->len,
|
|
|
4c6625a |
DMA_TO_DEVICE);
|
|
|
4c6625a |
rp->skb = NULL;
|
|
|
4c6625a |
- dev_kfree_skb(skb);
|
|
|
4c6625a |
+ dev_kfree_skb_irq(skb);
|
|
|
4c6625a |
}
|
|
|
4c6625a |
|
|
|
4c6625a |
bp->tx_cons = cons;
|
|
|
4c6625a |
--
|
|
|
4c6625a |
1.7.7.4
|
|
|
4c6625a |
|