|
 |
71dcda6 |
From patchwork Tue Oct 9 13:24:46 2018
|
|
|
71dcda6 |
Content-Type: text/plain; charset="utf-8"
|
|
|
71dcda6 |
MIME-Version: 1.0
|
|
|
71dcda6 |
Content-Transfer-Encoding: 7bit
|
|
|
71dcda6 |
Subject: drm/vc4: Set ->is_yuv to false when num_planes == 1
|
|
|
71dcda6 |
From: Boris Brezillon <boris.brezillon@bootlin.com>
|
|
|
71dcda6 |
X-Patchwork-Id: 255528
|
|
|
71dcda6 |
Message-Id: <20181009132446.21960-1-boris.brezillon@bootlin.com>
|
|
|
71dcda6 |
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
|
|
|
71dcda6 |
dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>
|
|
|
71dcda6 |
Cc: Boris Brezillon <boris.brezillon@bootlin.com>, stable@vger.kernel.org
|
|
|
71dcda6 |
Date: Tue, 9 Oct 2018 15:24:46 +0200
|
|
|
71dcda6 |
|
|
|
71dcda6 |
When vc4_plane_state is duplicated ->is_yuv is left assigned to its
|
|
|
71dcda6 |
previous value, and we never set it back to false when switching to
|
|
|
71dcda6 |
a non-YUV format.
|
|
|
71dcda6 |
|
|
|
71dcda6 |
Fix that by setting ->is_yuv to false in the 'num_planes == 1' branch
|
|
|
71dcda6 |
of the vc4_plane_setup_clipping_and_scaling() function.
|
|
|
71dcda6 |
|
|
|
71dcda6 |
Fixes: fc04023fafecf ("drm/vc4: Add support for YUV planes.")
|
|
|
71dcda6 |
Cc: <stable@vger.kernel.org>
|
|
|
71dcda6 |
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
|
|
|
71dcda6 |
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
|
71dcda6 |
---
|
|
|
71dcda6 |
drivers/gpu/drm/vc4/vc4_plane.c | 1 +
|
|
|
71dcda6 |
1 file changed, 1 insertion(+)
|
|
|
71dcda6 |
|
|
|
71dcda6 |
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
|
|
|
71dcda6 |
index d04b3c3246ba..60d5ad19cedd 100644
|
|
|
71dcda6 |
--- a/drivers/gpu/drm/vc4/vc4_plane.c
|
|
|
71dcda6 |
+++ b/drivers/gpu/drm/vc4/vc4_plane.c
|
|
|
71dcda6 |
@@ -321,6 +321,7 @@ static int vc4_plane_setup_clipping_and_scaling(struct drm_plane_state *state)
|
|
|
71dcda6 |
if (vc4_state->is_unity)
|
|
|
71dcda6 |
vc4_state->x_scaling[0] = VC4_SCALING_PPF;
|
|
|
71dcda6 |
} else {
|
|
|
71dcda6 |
+ vc4_state->is_yuv = false;
|
|
|
71dcda6 |
vc4_state->x_scaling[1] = VC4_SCALING_NONE;
|
|
|
71dcda6 |
vc4_state->y_scaling[1] = VC4_SCALING_NONE;
|
|
|
71dcda6 |
}
|