|
 |
8d40c35 |
From 1faabf2aab1fdaa1ace4e8c829d1b9cf7bfec2f1 Mon Sep 17 00:00:00 2001
|
|
|
8d40c35 |
From: Eric Dumazet <edumazet@google.com>
|
|
|
8d40c35 |
Date: Sat, 20 Jul 2013 03:07:16 +0000
|
|
|
8d40c35 |
Subject: bridge: do not call setup_timer() multiple times
|
|
|
8d40c35 |
|
|
|
8d40c35 |
commit 9f00b2e7cf24 ("bridge: only expire the mdb entry when query is
|
|
|
8d40c35 |
received") added a nasty bug as an active timer can be reinitialized.
|
|
|
8d40c35 |
|
|
|
8d40c35 |
setup_timer() must be done once, no matter how many time mod_timer()
|
|
|
8d40c35 |
is called. br_multicast_new_group() is the right place to do this.
|
|
|
8d40c35 |
|
|
|
8d40c35 |
Reported-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
|
|
|
8d40c35 |
Diagnosed-by: Thomas Gleixner <tglx@linutronix.de>
|
|
|
8d40c35 |
Signed-off-by: Eric Dumazet <edumazet@google.com>
|
|
|
8d40c35 |
Tested-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
|
|
|
8d40c35 |
Cc: Cong Wang <amwang@redhat.com>
|
|
|
8d40c35 |
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
8d40c35 |
---
|
|
|
8d40c35 |
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
|
|
|
8d40c35 |
index 69af490..4b99c9a 100644
|
|
|
8d40c35 |
--- a/net/bridge/br_multicast.c
|
|
|
8d40c35 |
+++ b/net/bridge/br_multicast.c
|
|
|
8d40c35 |
@@ -619,6 +619,9 @@ rehash:
|
|
|
8d40c35 |
mp->br = br;
|
|
|
8d40c35 |
mp->addr = *group;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
+ setup_timer(&mp->timer, br_multicast_group_expired,
|
|
|
8d40c35 |
+ (unsigned long)mp);
|
|
|
8d40c35 |
+
|
|
|
8d40c35 |
hlist_add_head_rcu(&mp->hlist[mdb->ver], &mdb->mhash[hash]);
|
|
|
8d40c35 |
mdb->size++;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
@@ -1126,7 +1129,6 @@ static int br_ip4_multicast_query(struct net_bridge *br,
|
|
|
8d40c35 |
if (!mp)
|
|
|
8d40c35 |
goto out;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
- setup_timer(&mp->timer, br_multicast_group_expired, (unsigned long)mp);
|
|
|
8d40c35 |
mod_timer(&mp->timer, now + br->multicast_membership_interval);
|
|
|
8d40c35 |
mp->timer_armed = true;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
@@ -1204,7 +1206,6 @@ static int br_ip6_multicast_query(struct net_bridge *br,
|
|
|
8d40c35 |
if (!mp)
|
|
|
8d40c35 |
goto out;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
- setup_timer(&mp->timer, br_multicast_group_expired, (unsigned long)mp);
|
|
|
8d40c35 |
mod_timer(&mp->timer, now + br->multicast_membership_interval);
|
|
|
8d40c35 |
mp->timer_armed = true;
|
|
|
8d40c35 |
|
|
|
8d40c35 |
--
|
|
|
8d40c35 |
cgit v0.9.2
|