|
 |
7792df6 |
From cb8e390d258b7f8073afafcbb163976e27346e9d Mon Sep 17 00:00:00 2001
|
|
|
7792df6 |
From: Josh Boyer <jwboyer@fedoraproject.org>
|
|
|
7792df6 |
Date: Fri, 11 Oct 2013 08:37:53 -0400
|
|
|
7792df6 |
Subject: [PATCH] cpupower: Fix segfault due to incorrect getopt_long arugments
|
|
|
7792df6 |
|
|
|
7792df6 |
If a user calls 'cpupower set --perf-bias 15', the process will end with a
|
|
|
7792df6 |
SIGSEGV in libc because cpupower-set passes a NULL optarg to the atoi call.
|
|
|
7792df6 |
This is because the getopt_long structure currently has all of the options
|
|
|
7792df6 |
as having an optional_argument when they really have a required argument.
|
|
|
7792df6 |
We change the structure to use required_argument to match the short options
|
|
|
7792df6 |
and it resolves the issue.
|
|
|
7792df6 |
|
|
|
7792df6 |
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1000439
|
|
|
7792df6 |
|
|
|
7792df6 |
Cc: stable@vger.kernel.org
|
|
|
7792df6 |
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
|
|
|
7792df6 |
---
|
|
|
7792df6 |
tools/power/cpupower/utils/cpupower-set.c | 6 +++---
|
|
|
7792df6 |
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
7792df6 |
|
|
|
7792df6 |
diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
|
|
|
7792df6 |
index dc4de37..bcf1d2f 100644
|
|
|
7792df6 |
--- a/tools/power/cpupower/utils/cpupower-set.c
|
|
|
7792df6 |
+++ b/tools/power/cpupower/utils/cpupower-set.c
|
|
|
7792df6 |
@@ -18,9 +18,9 @@
|
|
|
7792df6 |
#include "helpers/bitmask.h"
|
|
|
7792df6 |
|
|
|
7792df6 |
static struct option set_opts[] = {
|
|
|
7792df6 |
- { .name = "perf-bias", .has_arg = optional_argument, .flag = NULL, .val = 'b'},
|
|
|
7792df6 |
- { .name = "sched-mc", .has_arg = optional_argument, .flag = NULL, .val = 'm'},
|
|
|
7792df6 |
- { .name = "sched-smt", .has_arg = optional_argument, .flag = NULL, .val = 's'},
|
|
|
7792df6 |
+ { .name = "perf-bias", .has_arg = required_argument, .flag = NULL, .val = 'b'},
|
|
|
7792df6 |
+ { .name = "sched-mc", .has_arg = required_argument, .flag = NULL, .val = 'm'},
|
|
|
7792df6 |
+ { .name = "sched-smt", .has_arg = required_argument, .flag = NULL, .val = 's'},
|
|
|
7792df6 |
{ },
|
|
|
7792df6 |
};
|
|
|
7792df6 |
|
|
|
7792df6 |
--
|
|
|
7792df6 |
1.8.3.1
|
|
|
7792df6 |
|