|
 |
a9dc6a3 |
From patchwork Mon Nov 23 09:32:42 2015
|
|
|
a9dc6a3 |
Content-Type: text/plain; charset="utf-8"
|
|
|
a9dc6a3 |
MIME-Version: 1.0
|
|
|
a9dc6a3 |
Content-Transfer-Encoding: 7bit
|
|
|
a9dc6a3 |
Subject: [09/29] drm/udl: Use unlocked gem unreferencing
|
|
|
a9dc6a3 |
From: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
|
a9dc6a3 |
X-Patchwork-Id: 65722
|
|
|
a9dc6a3 |
Message-Id: <1448271183-20523-10-git-send-email-daniel.vetter@ffwll.ch>
|
|
|
a9dc6a3 |
To: DRI Development <dri-devel@lists.freedesktop.org>
|
|
|
a9dc6a3 |
Cc: Daniel Vetter <daniel.vetter@intel.com>,
|
|
|
a9dc6a3 |
Daniel Vetter <daniel.vetter@ffwll.ch>,
|
|
|
a9dc6a3 |
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
|
|
|
a9dc6a3 |
Dave Airlie <airlied@redhat.com>
|
|
|
a9dc6a3 |
Date: Mon, 23 Nov 2015 10:32:42 +0100
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
For drm_gem_object_unreference callers are required to hold
|
|
|
a9dc6a3 |
dev->struct_mutex, which these paths don't. Enforcing this requirement
|
|
|
a9dc6a3 |
has become a bit more strict with
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663
|
|
|
a9dc6a3 |
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
|
a9dc6a3 |
Date: Thu Oct 15 09:36:25 2015 +0200
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
drm/gem: Check locking in drm_gem_object_unreference
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
Cc: Dave Airlie <airlied@redhat.com>
|
|
|
a9dc6a3 |
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
|
|
|
a9dc6a3 |
---
|
|
|
a9dc6a3 |
drivers/gpu/drm/udl/udl_fb.c | 2 +-
|
|
|
a9dc6a3 |
drivers/gpu/drm/udl/udl_gem.c | 2 +-
|
|
|
a9dc6a3 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
|
|
|
a9dc6a3 |
index 200419d4d43c..18a2acbccb7d 100644
|
|
|
a9dc6a3 |
--- a/drivers/gpu/drm/udl/udl_fb.c
|
|
|
a9dc6a3 |
+++ b/drivers/gpu/drm/udl/udl_fb.c
|
|
|
a9dc6a3 |
@@ -538,7 +538,7 @@ static int udlfb_create(struct drm_fb_helper *helper,
|
|
|
a9dc6a3 |
out_destroy_fbi:
|
|
|
a9dc6a3 |
drm_fb_helper_release_fbi(helper);
|
|
|
a9dc6a3 |
out_gfree:
|
|
|
a9dc6a3 |
- drm_gem_object_unreference(&ufbdev->ufb.obj->base);
|
|
|
a9dc6a3 |
+ drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base);
|
|
|
a9dc6a3 |
out:
|
|
|
a9dc6a3 |
return ret;
|
|
|
a9dc6a3 |
}
|
|
|
a9dc6a3 |
diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
|
|
|
a9dc6a3 |
index 2a0a784ab6ee..d7528e0d8442 100644
|
|
|
a9dc6a3 |
--- a/drivers/gpu/drm/udl/udl_gem.c
|
|
|
a9dc6a3 |
+++ b/drivers/gpu/drm/udl/udl_gem.c
|
|
|
a9dc6a3 |
@@ -52,7 +52,7 @@ udl_gem_create(struct drm_file *file,
|
|
|
a9dc6a3 |
return ret;
|
|
|
a9dc6a3 |
}
|
|
|
a9dc6a3 |
|
|
|
a9dc6a3 |
- drm_gem_object_unreference(&obj->base);
|
|
|
a9dc6a3 |
+ drm_gem_object_unreference_unlocked(&obj->base);
|
|
|
a9dc6a3 |
*handle_p = handle;
|
|
|
a9dc6a3 |
return 0;
|
|
|
a9dc6a3 |
}
|