ee54dc1
From: "David S. Miller" <davem@davemloft.net>
ee54dc1
Date: Fri, 1 May 2015 22:02:47 -0400
ee54dc1
Subject: [PATCH] ipv4: Missing sk_nulls_node_init() in ping_unhash().
ee54dc1
ee54dc1
If we don't do that, then the poison value is left in the ->pprev
ee54dc1
backlink.
ee54dc1
ee54dc1
This can cause crashes if we do a disconnect, followed by a connect().
ee54dc1
ee54dc1
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
ee54dc1
Reported-by: Wen Xu <hotdog3645@gmail.com>
ee54dc1
Signed-off-by: David S. Miller <davem@davemloft.net>
ee54dc1
---
ee54dc1
 net/ipv4/ping.c | 1 +
ee54dc1
 1 file changed, 1 insertion(+)
ee54dc1
ee54dc1
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
ee54dc1
index 208d5439e59b..787b0d699969 100644
ee54dc1
--- a/net/ipv4/ping.c
ee54dc1
+++ b/net/ipv4/ping.c
ee54dc1
@@ -158,6 +158,7 @@ void ping_unhash(struct sock *sk)
ee54dc1
 	if (sk_hashed(sk)) {
ee54dc1
 		write_lock_bh(&ping_table.lock);
ee54dc1
 		hlist_nulls_del(&sk->sk_nulls_node);
ee54dc1
+		sk_nulls_node_init(&sk->sk_nulls_node);
ee54dc1
 		sock_put(sk);
ee54dc1
 		isk->inet_num = 0;
ee54dc1
 		isk->inet_sport = 0;