Jesse Keating 2f82dd
From linville@redhat.com Mon Mar 29 14:49:37 2010
Jesse Keating 2f82dd
Return-path: <linville@redhat.com>
Jesse Keating 2f82dd
Envelope-to: linville@tuxdriver.com
Jesse Keating 2f82dd
Delivery-date: Mon, 29 Mar 2010 14:49:37 -0400
Jesse Keating 2f82dd
Received: from mx1.redhat.com ([209.132.183.28])
Jesse Keating 2f82dd
	by smtp.tuxdriver.com with esmtp (Exim 4.63)
Jesse Keating 2f82dd
	(envelope-from <linville@redhat.com>)
Jesse Keating 2f82dd
	id 1NwK1n-0004Zz-SW
Jesse Keating 2f82dd
	for linville@tuxdriver.com; Mon, 29 Mar 2010 14:49:37 -0400
Jesse Keating 2f82dd
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
Jesse Keating 2f82dd
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2TInYO7028996
Jesse Keating 2f82dd
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
Jesse Keating 2f82dd
	for <linville@tuxdriver.com>; Mon, 29 Mar 2010 14:49:35 -0400
Jesse Keating 2f82dd
Received: from savage.usersys.redhat.com (savage.devel.redhat.com [10.11.231.4])
Jesse Keating 2f82dd
	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2TInX27023483
Jesse Keating 2f82dd
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
Jesse Keating 2f82dd
	for <linville@tuxdriver.com>; Mon, 29 Mar 2010 14:49:33 -0400
Jesse Keating 2f82dd
Received: from savage.usersys.redhat.com (localhost.localdomain [127.0.0.1])
Jesse Keating 2f82dd
	by savage.usersys.redhat.com (8.13.1/8.13.1) with ESMTP id o2TInXPn000652
Jesse Keating 2f82dd
	for <linville@tuxdriver.com>; Mon, 29 Mar 2010 14:49:33 -0400
Jesse Keating 2f82dd
Received: (from linville@localhost)
Jesse Keating 2f82dd
	by savage.usersys.redhat.com (8.13.1/8.13.1/Submit) id o2TInWt7000651
Jesse Keating 2f82dd
	for linville@tuxdriver.com; Mon, 29 Mar 2010 14:49:32 -0400
Jesse Keating 2f82dd
Resent-Message-Id: <201003291849.o2TInWt7000651@savage.usersys.redhat.com>
Jesse Keating 2f82dd
Received: from zmta03.collab.prod.int.phx2.redhat.com (LHLO
Jesse Keating 2f82dd
 zmta03.collab.prod.int.phx2.redhat.com) (10.5.5.33) by
Jesse Keating 2f82dd
 mail03.corp.redhat.com with LMTP; Fri, 26 Mar 2010 06:05:51 -0400 (EDT)
Jesse Keating 2f82dd
Received: from localhost (localhost.localdomain [127.0.0.1])
Jesse Keating 2f82dd
	by zmta03.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 038004CBE9;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 06:05:51 -0400 (EDT)
Jesse Keating 2f82dd
Received: from zmta03.collab.prod.int.phx2.redhat.com ([127.0.0.1])
Jesse Keating 2f82dd
	by localhost (zmta03.collab.prod.int.phx2.redhat.com [127.0.0.1]) (amavisd-new, port 10024)
Jesse Keating 2f82dd
	with ESMTP id IVjBQyibLBw2; Fri, 26 Mar 2010 06:05:50 -0400 (EDT)
Jesse Keating 2f82dd
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
Jesse Keating 2f82dd
	by zmta03.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id BF0144CBE7;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 06:05:50 -0400 (EDT)
Jesse Keating 2f82dd
Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.12])
Jesse Keating 2f82dd
	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2QA5m7L004056;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 06:05:49 -0400
Jesse Keating 2f82dd
Received: from bastion.fedoraproject.org (bastion.phx2.fedoraproject.org [10.5.126.11])
Jesse Keating 2f82dd
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2QA5bS2028477;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 06:05:37 -0400
Jesse Keating 2f82dd
Received: from lists.fedoraproject.org (collab1.vpn.fedoraproject.org [192.168.1.21])
Jesse Keating 2f82dd
	by bastion02.phx2.fedoraproject.org (Postfix) with ESMTP id 16EF710F96C;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 10:05:37 +0000 (UTC)
Jesse Keating 2f82dd
Received: from collab1.fedoraproject.org (localhost.localdomain [127.0.0.1])
Jesse Keating 2f82dd
	by lists.fedoraproject.org (Postfix) with ESMTP id 1C8C93267AC;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 10:05:19 +0000 (UTC)
Jesse Keating 2f82dd
X-Original-To: kernel@lists.fedoraproject.org
Jesse Keating 2f82dd
Delivered-To: kernel@lists.fedoraproject.org
Jesse Keating 2f82dd
Received: from smtp-mm1.fedoraproject.org (smtp-mm1.fedoraproject.org
Jesse Keating 2f82dd
	[80.239.156.217])
Jesse Keating 2f82dd
	by lists.fedoraproject.org (Postfix) with ESMTP id 5FD26326780
Jesse Keating 2f82dd
	for <kernel@lists.fedoraproject.org>;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 10:05:14 +0000 (UTC)
Jesse Keating 2f82dd
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
Jesse Keating 2f82dd
	by smtp-mm1.fedoraproject.org (Postfix) with ESMTP id 9BB6A87E5F
Jesse Keating 2f82dd
	for <kernel@lists.fedoraproject.org>;
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 10:05:13 +0000 (UTC)
Jesse Keating 2f82dd
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
Jesse Keating 2f82dd
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
Jesse Keating 2f82dd
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2QA5CbS005173
Jesse Keating 2f82dd
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
Jesse Keating 2f82dd
	Fri, 26 Mar 2010 06:05:12 -0400
Jesse Keating 2f82dd
Received: from localhost (dhcp-0-189.brq.redhat.com [10.34.0.189])
Jesse Keating 2f82dd
	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
Jesse Keating 2f82dd
	id o2QA5BKo028563; Fri, 26 Mar 2010 06:05:11 -0400
Jesse Keating 2f82dd
From: Stanislaw Gruszka <sgruszka@redhat.com>
Jesse Keating 2f82dd
To: kernel@lists.fedoraproject.org
Jesse Keating 2f82dd
Subject: [PATCH 2/3] iwlwifi: reset card during probe
Jesse Keating 2f82dd
Date: Fri, 26 Mar 2010 11:03:26 +0100
Jesse Keating 2f82dd
Message-Id: <1269597807-2925-2-git-send-email-sgruszka@redhat.com>
Jesse Keating 2f82dd
In-Reply-To: <1269597807-2925-1-git-send-email-sgruszka@redhat.com>
Jesse Keating 2f82dd
References: <1269597807-2925-1-git-send-email-sgruszka@redhat.com>
Jesse Keating 2f82dd
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17
Jesse Keating 2f82dd
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17
Jesse Keating 2f82dd
X-Scanned-By: MIMEDefang 2.67 on 10.5.110.12
Jesse Keating 2f82dd
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21
Jesse Keating 2f82dd
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Jesse Keating 2f82dd
        "John W. Linville" <linville@tuxdriver.com>
Jesse Keating 2f82dd
X-BeenThere: kernel@lists.fedoraproject.org
Jesse Keating 2f82dd
X-Mailman-Version: 2.1.9
Jesse Keating 2f82dd
Precedence: list
Jesse Keating 2f82dd
List-Id: "Fedora kernel development." <kernel.lists.fedoraproject.org>
Jesse Keating 2f82dd
List-Unsubscribe: <https: admin.fedoraproject.org="" mailman="" listinfo="" kernel="">,
Jesse Keating 2f82dd
	<mailto:kernel-request@lists.fedoraproject.org?subject=unsubscribe>
Jesse Keating 2f82dd
List-Archive: <http: lists.fedoraproject.org="" pipermail="" kernel="">
Jesse Keating 2f82dd
List-Post: <mailto:kernel@lists.fedoraproject.org>
Jesse Keating 2f82dd
List-Help: <mailto:kernel-request@lists.fedoraproject.org?subject=help>
Jesse Keating 2f82dd
List-Subscribe: <https: admin.fedoraproject.org="" mailman="" listinfo="" kernel="">,
Jesse Keating 2f82dd
	<mailto:kernel-request@lists.fedoraproject.org?subject=subscribe>
Jesse Keating 2f82dd
MIME-Version: 1.0
Jesse Keating 2f82dd
Content-Type: text/plain; charset="us-ascii"
Jesse Keating 2f82dd
Content-Transfer-Encoding: 7bit
Jesse Keating 2f82dd
Sender: kernel-bounces@lists.fedoraproject.org
Jesse Keating 2f82dd
Errors-To: kernel-bounces@lists.fedoraproject.org
Jesse Keating 2f82dd
X-RedHat-Spam-Score: -0.01  (T_RP_MATCHES_RCVD)
Jesse Keating 2f82dd
Resent-From: linville@redhat.com
Jesse Keating 2f82dd
Resent-Date: Mon, 29 Mar 2010 14:49:32 -0400
Jesse Keating 2f82dd
Resent-To: linville@tuxdriver.com
Jesse Keating 2f82dd
X-Spam-Score: -8.8 (--------)
Jesse Keating 2f82dd
X-Spam-Status: No
Jesse Keating 2f82dd
Content-Length: 2455
Jesse Keating 2f82dd
Lines: 61
Jesse Keating 2f82dd
Jesse Keating 2f82dd
RHBZ#557084 
Jesse Keating 2f82dd
Jesse Keating 2f82dd
To ensure that card is in a sane state during probe we add a reset call.
Jesse Keating 2f82dd
This change was prompted by users of kdump who was not able to bring up the
Jesse Keating 2f82dd
wireless driver in the kdump kernel. The problem here was that the primary
Jesse Keating 2f82dd
kernel, which is not running at the time, left the wireless card up and
Jesse Keating 2f82dd
running. When the kdump kernel starts it is thus possible to immediately
Jesse Keating 2f82dd
receive interrupts from firmware after registering interrupt, but without
Jesse Keating 2f82dd
being ready to deal with interrupts from firmware yet.
Jesse Keating 2f82dd
Jesse Keating 2f82dd
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Jesse Keating 2f82dd
---
Jesse Keating 2f82dd
 drivers/net/wireless/iwlwifi/iwl-agn.c      |    8 ++++++++
Jesse Keating 2f82dd
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    7 +++++++
Jesse Keating 2f82dd
 2 files changed, 15 insertions(+), 0 deletions(-)
Jesse Keating 2f82dd
Jesse Keating 2f82dd
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
Jesse Keating 2f82dd
index 921dc4a..1661f3c 100644
Jesse Keating 2f82dd
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
Jesse Keating 2f82dd
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
Jesse Keating 2f82dd
@@ -2976,6 +2976,14 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
Jesse Keating 2f82dd
 	 * we should init now
Jesse Keating 2f82dd
 	 */
Jesse Keating 2f82dd
 	spin_lock_init(&priv->reg_lock);
Jesse Keating 2f82dd
+
Jesse Keating 2f82dd
+	/*
Jesse Keating 2f82dd
+	 * stop and reset the on-board processor just in case it is in a
Jesse Keating 2f82dd
+	 * strange state ... like being left stranded by a primary kernel
Jesse Keating 2f82dd
+	 * and this is now the kdump kernel trying to start up
Jesse Keating 2f82dd
+	 */
Jesse Keating 2f82dd
+	iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_NEVO_RESET);
Jesse Keating 2f82dd
+
Jesse Keating 2f82dd
 	iwl_hw_detect(priv);
Jesse Keating 2f82dd
 	IWL_INFO(priv, "Detected Intel Wireless WiFi Link %s REV=0x%X\n",
Jesse Keating 2f82dd
 		priv->cfg->name, priv->hw_rev);
Jesse Keating 2f82dd
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
Jesse Keating 2f82dd
index 5f26c93..3726b01 100644
Jesse Keating 2f82dd
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
Jesse Keating 2f82dd
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
Jesse Keating 2f82dd
@@ -4032,6 +4032,13 @@ static int iwl3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *e
Jesse Keating 2f82dd
 	IWL_INFO(priv, "Detected Intel Wireless WiFi Link %s\n",
Jesse Keating 2f82dd
 		priv->cfg->name);
Jesse Keating 2f82dd
 
Jesse Keating 2f82dd
+	/*
Jesse Keating 2f82dd
+	 * stop and reset the on-board processor just in case it is in a
Jesse Keating 2f82dd
+	 * strange state ... like being left stranded by a primary kernel
Jesse Keating 2f82dd
+	 * and this is now the kdump kernel trying to start up
Jesse Keating 2f82dd
+	 */
Jesse Keating 2f82dd
+	iwl_write32(priv, CSR_RESET, CSR_RESET_REG_FLAG_NEVO_RESET);
Jesse Keating 2f82dd
+
Jesse Keating 2f82dd
 	/***********************
Jesse Keating 2f82dd
 	 * 7. Setup Services
Jesse Keating 2f82dd
 	 * ********************/
Jesse Keating 2f82dd
-- 
Jesse Keating 2f82dd
1.6.2.5
Jesse Keating 2f82dd
Jesse Keating 2f82dd
_______________________________________________
Jesse Keating 2f82dd
kernel mailing list
Jesse Keating 2f82dd
kernel@lists.fedoraproject.org
Jesse Keating 2f82dd
https://admin.fedoraproject.org/mailman/listinfo/kernel
Jesse Keating 2f82dd
Jesse Keating 2f82dd