|
 |
58bbe0b |
From: Eric Work <work.eric@gmail.com>
|
|
|
58bbe0b |
Date: Tue, 19 May 2015 06:26:23 -0700
|
|
|
58bbe0b |
Subject: [PATCH] md/raid0: fix restore to sector variable in
|
|
|
58bbe0b |
raid0_make_request
|
|
|
58bbe0b |
|
|
|
58bbe0b |
md/raid0: fix restore to sector variable in raid0_make_request
|
|
|
58bbe0b |
|
|
|
58bbe0b |
The variable "sector" in "raid0_make_request()" was improperly updated
|
|
|
58bbe0b |
by a call to "sector_div()" which modifies its first argument in place.
|
|
|
58bbe0b |
Commit 47d68979cc968535cb87f3e5f2e6a3533ea48fbd restored this variable
|
|
|
58bbe0b |
after the call for later re-use. Unfortunetly the restore was done after
|
|
|
58bbe0b |
the referenced variable "bio" was advanced. This lead to the original
|
|
|
58bbe0b |
value and the restored value being different. Here we move this line to
|
|
|
58bbe0b |
the proper place.
|
|
|
58bbe0b |
|
|
|
58bbe0b |
One observed side effect of this bug was discarding a file though
|
|
|
58bbe0b |
unlinking would cause an unrelated file's contents to be discarded.
|
|
|
58bbe0b |
|
|
|
58bbe0b |
Signed-off-by: NeilBrown <neilb@suse.de>
|
|
|
58bbe0b |
Fixes: 47d68979cc96 ("md/raid0: fix bug with chunksize not a power of 2.")
|
|
|
58bbe0b |
Cc: stable@vger.kernel.org (any that received above backport)
|
|
|
58bbe0b |
URL: https://bugzilla.kernel.org/show_bug.cgi?id=98501
|
|
|
58bbe0b |
---
|
|
|
58bbe0b |
drivers/md/raid0.c | 4 +++-
|
|
|
58bbe0b |
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
58bbe0b |
|
|
|
58bbe0b |
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
|
|
|
58bbe0b |
index 6a68ef5246d4..efb654eb5399 100644
|
|
|
58bbe0b |
--- a/drivers/md/raid0.c
|
|
|
58bbe0b |
+++ b/drivers/md/raid0.c
|
|
|
58bbe0b |
@@ -524,6 +524,9 @@ static void raid0_make_request(struct mddev *mddev, struct bio *bio)
|
|
|
58bbe0b |
? (sector & (chunk_sects-1))
|
|
|
58bbe0b |
: sector_div(sector, chunk_sects));
|
|
|
58bbe0b |
|
|
|
58bbe0b |
+ /* Restore due to sector_div */
|
|
|
58bbe0b |
+ sector = bio->bi_iter.bi_sector;
|
|
|
58bbe0b |
+
|
|
|
58bbe0b |
if (sectors < bio_sectors(bio)) {
|
|
|
58bbe0b |
split = bio_split(bio, sectors, GFP_NOIO, fs_bio_set);
|
|
|
58bbe0b |
bio_chain(split, bio);
|
|
|
58bbe0b |
@@ -531,7 +534,6 @@ static void raid0_make_request(struct mddev *mddev, struct bio *bio)
|
|
|
58bbe0b |
split = bio;
|
|
|
58bbe0b |
}
|
|
|
58bbe0b |
|
|
|
58bbe0b |
- sector = bio->bi_iter.bi_sector;
|
|
|
58bbe0b |
zone = find_zone(mddev->private, §or);
|
|
|
58bbe0b |
tmp_dev = map_sector(mddev, zone, sector, §or);
|
|
|
58bbe0b |
split->bi_bdev = tmp_dev->bdev;
|