|
 |
0903551 |
From patchwork Wed Jun 22 17:40:50 2016
|
|
|
0903551 |
Content-Type: text/plain; charset="utf-8"
|
|
|
0903551 |
MIME-Version: 1.0
|
|
|
0903551 |
Content-Transfer-Encoding: 7bit
|
|
|
0903551 |
Subject: [v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0
|
|
|
0903551 |
From: Jeremy Linton <jeremy.linton@arm.com>
|
|
|
0903551 |
X-Patchwork-Id: 639331
|
|
|
0903551 |
X-Patchwork-Delegate: davem@davemloft.net
|
|
|
0903551 |
Message-Id: <1466617250-27317-1-git-send-email-jeremy.linton@arm.com>
|
|
|
0903551 |
To: netdev@vger.kernel.org
|
|
|
0903551 |
Cc: steve.glendinning@shawell.net, andrew@lunn.ch,
|
|
|
0903551 |
sergei.shtylyov@cogentembedded.com, linux-kernel@vger.kernel.org,
|
|
|
0903551 |
stable@vger.kernel.org, pbrobinson@gmail.com,
|
|
|
0903551 |
mlangsdorf@redhat.com, steve.capper@arm.com
|
|
|
0903551 |
Date: Wed, 22 Jun 2016 12:40:50 -0500
|
|
|
0903551 |
|
|
|
0903551 |
By default, mdiobus_alloc() sets the PHYs to polling mode, but a
|
|
|
0903551 |
pointer size memcpy means that a couple IRQs end up being overwritten
|
|
|
0903551 |
with a value of 0. This means that PHY_POLL is disabled and results
|
|
|
0903551 |
in unpredictable behavior depending on the PHY's location on the
|
|
|
0903551 |
MDIO bus. Remove that memcpy and the now unused phy_irq member to
|
|
|
0903551 |
force the SMSC911x PHYs into polling mode 100% of the time.
|
|
|
0903551 |
|
|
|
0903551 |
Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
|
|
|
0903551 |
|
|
|
0903551 |
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
|
|
|
0903551 |
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
|
0903551 |
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
|
|
|
0903551 |
---
|
|
|
0903551 |
drivers/net/ethernet/smsc/smsc911x.c | 2 --
|
|
|
0903551 |
1 file changed, 2 deletions(-)
|
|
|
0903551 |
|
|
|
0903551 |
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
|
|
|
0903551 |
index 8af2556..b5ab5e1 100644
|
|
|
0903551 |
--- a/drivers/net/ethernet/smsc/smsc911x.c
|
|
|
0903551 |
+++ b/drivers/net/ethernet/smsc/smsc911x.c
|
|
|
0903551 |
@@ -116,7 +116,6 @@ struct smsc911x_data {
|
|
|
0903551 |
|
|
|
0903551 |
struct phy_device *phy_dev;
|
|
|
0903551 |
struct mii_bus *mii_bus;
|
|
|
0903551 |
- int phy_irq[PHY_MAX_ADDR];
|
|
|
0903551 |
unsigned int using_extphy;
|
|
|
0903551 |
int last_duplex;
|
|
|
0903551 |
int last_carrier;
|
|
|
0903551 |
@@ -1073,7 +1072,6 @@ static int smsc911x_mii_init(struct platform_device *pdev,
|
|
|
0903551 |
pdata->mii_bus->priv = pdata;
|
|
|
0903551 |
pdata->mii_bus->read = smsc911x_mii_read;
|
|
|
0903551 |
pdata->mii_bus->write = smsc911x_mii_write;
|
|
|
0903551 |
- memcpy(pdata->mii_bus->irq, pdata->phy_irq, sizeof(pdata->mii_bus));
|
|
|
0903551 |
|
|
|
0903551 |
pdata->mii_bus->parent = &pdev->dev;
|
|
|
0903551 |
|