1c29f2a
From patchwork Fri Sep 20 03:00:41 2019
1c29f2a
Content-Type: text/plain; charset="utf-8"
1c29f2a
MIME-Version: 1.0
1c29f2a
Content-Transfer-Encoding: 7bit
1c29f2a
X-Patchwork-Submitter: Navid Emamdoost <navid.emamdoost@gmail.com>
1c29f2a
X-Patchwork-Id: 11153733
1c29f2a
X-Patchwork-Delegate: kvalo@adurom.com
1c29f2a
Return-Path: <SRS0=+Ljc=XP=vger.kernel.org=linux-wireless-owner@kernel.org>
1c29f2a
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
1c29f2a
 [172.30.200.123])
1c29f2a
	by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7607B76
1c29f2a
	for <patchwork-linux-wireless@patchwork.kernel.org>;
1c29f2a
 Fri, 20 Sep 2019 03:00:56 +0000 (UTC)
1c29f2a
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
1c29f2a
	by mail.kernel.org (Postfix) with ESMTP id 48CF521929
1c29f2a
	for <patchwork-linux-wireless@patchwork.kernel.org>;
1c29f2a
 Fri, 20 Sep 2019 03:00:56 +0000 (UTC)
1c29f2a
Authentication-Results: mail.kernel.org;
1c29f2a
	dkim=fail reason="signature verification failed" (2048-bit key)
1c29f2a
 header.d=gmail.com header.i=@gmail.com header.b="fzAGUdQV"
1c29f2a
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
1c29f2a
        id S2405830AbfITDAw (ORCPT
1c29f2a
        <rfc822;patchwork-linux-wireless@patchwork.kernel.org>);
1c29f2a
        Thu, 19 Sep 2019 23:00:52 -0400
1c29f2a
Received: from mail-io1-f66.google.com ([209.85.166.66]:44050 "EHLO
1c29f2a
        mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
1c29f2a
        with ESMTP id S2389956AbfITDAv (ORCPT
1c29f2a
        <rfc822;linux-wireless@vger.kernel.org>);
1c29f2a
        Thu, 19 Sep 2019 23:00:51 -0400
1c29f2a
Received: by mail-io1-f66.google.com with SMTP id j4so12740088iog.11;
1c29f2a
        Thu, 19 Sep 2019 20:00:51 -0700 (PDT)
1c29f2a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
1c29f2a
        d=gmail.com; s=20161025;
1c29f2a
        h=from:to:cc:subject:date:message-id;
1c29f2a
        bh=wR9pye3sH3f9c/Ue486PD/cpETKoqUyEfHnMaMiRPdY=;
1c29f2a
        b=fzAGUdQVIXP8BO6Um0bEY7aXmxWrofp3WYusEuhMgPmQ27A5ZhIq51xSMAN9gohJey
1c29f2a
         xdsD6nXME5ZveH9/lQ1MvNo7e8lxKB+VJiF53+KRWHjYY3yo3CO+r/lMh38wUGe5T120
1c29f2a
         NI5FyQ8YmYV/aaqGUTa6/SbDVBDZBSb3F3uOkXNjWxRyI80HGsx60/fhQaY8HNtHHcDb
1c29f2a
         511aV1DthYS9mGIh4z56qpebAKs9Q6CMcrqtYaemGR01y1sZsyooYZweWPqYYQ28lZUi
1c29f2a
         oVHgUKZHp3jvfYhzZnVc8ousIPPiZiLXszN06Siqs6CGkR6p4m+lf80we8Xi6J0bEISz
1c29f2a
         hFBw==
1c29f2a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
1c29f2a
        d=1e100.net; s=20161025;
1c29f2a
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
1c29f2a
        bh=wR9pye3sH3f9c/Ue486PD/cpETKoqUyEfHnMaMiRPdY=;
1c29f2a
        b=mUe4i46sJphvT9eHFwqTegYlyqNnE95+R/GbAr/Is0OJfzCFXHu/cUrw5ElaQR4ATd
1c29f2a
         ShSEU7xpcL4ISPtNRc3kSBvt3ROv3RHbxdgCw3UYVG+DJLMet3AvPnJT0bwN5UWcCodd
1c29f2a
         z7bw4VprjwTZj8WPj+itlX2LdPws17O4C/ROM8RuRJ7MFQLwCg0qLscbxBXwKUsnyoTp
1c29f2a
         KIi52u4X85ABBEBFgGrx6ZS/sllG/u+spcSMjf/TVV0UglkLy7sRgZ4gyMBHgbMrzUDO
1c29f2a
         tGJQMGon7uU9OTA6a73s3ap8eeQ/c8KZUftJBh6c7xJL7qrH5lfZJSQBjePgKF+RF/rt
1c29f2a
         40wQ==
1c29f2a
X-Gm-Message-State: APjAAAWUFzu7MpjxWJtu4hgZuo8rk1uE8i27EiFcdjhNEG5ZaOg9jkNB
1c29f2a
        zqGym44mT1nF7nFS4RHjg/Y=
1c29f2a
X-Google-Smtp-Source: 
1c29f2a
 APXvYqwI+IXRu7Lhr0HmMj08qfXGIRkcCHYMdmSMkCW5GIIz+Ml1cQ5Uy6GCUGV2WrCpixMQAv4aog==
1c29f2a
X-Received: by 2002:a02:ac82:: with SMTP id x2mr13978167jan.34.1568948450810;
1c29f2a
        Thu, 19 Sep 2019 20:00:50 -0700 (PDT)
1c29f2a
Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54])
1c29f2a
        by smtp.googlemail.com with ESMTPSA id
1c29f2a
 t9sm380269iop.86.2019.09.19.20.00.50
1c29f2a
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
1c29f2a
        Thu, 19 Sep 2019 20:00:50 -0700 (PDT)
1c29f2a
From: Navid Emamdoost <navid.emamdoost@gmail.com>
1c29f2a
Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu,
1c29f2a
        Navid Emamdoost <navid.emamdoost@gmail.com>,
1c29f2a
        Jes Sorensen <Jes.Sorensen@gmail.com>,
1c29f2a
        Kalle Valo <kvalo@codeaurora.org>,
1c29f2a
        "David S. Miller" <davem@davemloft.net>,
1c29f2a
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
1c29f2a
        linux-kernel@vger.kernel.org
1c29f2a
Subject: [PATCH] rtl8xxxu: prevent leaking urb
1c29f2a
Date: Thu, 19 Sep 2019 22:00:41 -0500
1c29f2a
Message-Id: <20190920030043.30137-1-navid.emamdoost@gmail.com>
1c29f2a
X-Mailer: git-send-email 2.17.1
1c29f2a
To: unlisted-recipients:; (no To-header on input)
1c29f2a
Sender: linux-wireless-owner@vger.kernel.org
1c29f2a
Precedence: bulk
1c29f2a
List-ID: <linux-wireless.vger.kernel.org>
1c29f2a
X-Mailing-List: linux-wireless@vger.kernel.org
1c29f2a
1c29f2a
In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
1c29f2a
should be released.
1c29f2a
1c29f2a
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
1c29f2a
Reviewed-by: Chris Chiu <chiu@endlessm.com>
1c29f2a
---
1c29f2a
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 +
1c29f2a
 1 file changed, 1 insertion(+)
1c29f2a
1c29f2a
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
1c29f2a
index 8136e268b4e6..4a559c37e208 100644
1c29f2a
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
1c29f2a
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
1c29f2a
@@ -5443,6 +5443,7 @@ static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw)
1c29f2a
 	ret = usb_submit_urb(urb, GFP_KERNEL);
1c29f2a
 	if (ret) {
1c29f2a
 		usb_unanchor_urb(urb);
1c29f2a
+		usb_free_urb(urb);
1c29f2a
 		goto error;
1c29f2a
 	}
1c29f2a