|
 |
b151c2b |
Path: news.gmane.org!not-for-mail
|
|
|
b151c2b |
From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
|
|
b151c2b |
Newsgroups: gmane.linux.kernel.wireless.general
|
|
|
b151c2b |
Subject: [PATCH v2] rtlwifi: fix lps_lock deadlock
|
|
|
b151c2b |
Date: Mon, 28 Nov 2011 10:33:40 +0100
|
|
|
b151c2b |
Lines: 169
|
|
|
b151c2b |
Approved: news@gmane.org
|
|
|
b151c2b |
Message-ID: <20111128093339.GC2372@redhat.com>
|
|
|
b151c2b |
References: <1322219327-23148-1-git-send-email-sgruszka@redhat.com>
|
|
|
b151c2b |
<4ECFD1BF.4070503@lwfinger.net>
|
|
|
b151c2b |
<20111128092308.GB2372@redhat.com>
|
|
|
b151c2b |
NNTP-Posting-Host: lo.gmane.org
|
|
|
b151c2b |
Mime-Version: 1.0
|
|
|
b151c2b |
Content-Type: text/plain; charset=us-ascii
|
|
|
b151c2b |
X-Trace: dough.gmane.org 1322472712 10173 80.91.229.12 (28 Nov 2011 09:31:52 GMT)
|
|
|
b151c2b |
X-Complaints-To: usenet@dough.gmane.org
|
|
|
b151c2b |
NNTP-Posting-Date: Mon, 28 Nov 2011 09:31:52 +0000 (UTC)
|
|
|
b151c2b |
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
|
|
|
b151c2b |
Chaoming Li <chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>
|
|
|
b151c2b |
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>,
|
|
|
b151c2b |
"John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
|
|
|
b151c2b |
Original-X-From: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Mon Nov 28 10:31:45 2011
|
|
|
b151c2b |
Return-path: <linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
|
|
|
b151c2b |
Envelope-to: glkwg-linux-wireless-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
|
|
|
b151c2b |
Original-Received: from vger.kernel.org ([209.132.180.67])
|
|
|
b151c2b |
by lo.gmane.org with esmtp (Exim 4.69)
|
|
|
b151c2b |
(envelope-from <linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
|
|
|
b151c2b |
id 1RUxYu-0002H1-AY
|
|
|
b151c2b |
for glkwg-linux-wireless-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Mon, 28 Nov 2011 10:31:44 +0100
|
|
|
b151c2b |
Original-Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
|
|
|
b151c2b |
id S1751698Ab1K1Jbm (ORCPT
|
|
|
b151c2b |
<rfc822;glkwg-linux-wireless@m.gmane.org>);
|
|
|
b151c2b |
Mon, 28 Nov 2011 04:31:42 -0500
|
|
|
b151c2b |
Original-Received: from mx1.redhat.com ([209.132.183.28]:62078 "EHLO mx1.redhat.com"
|
|
|
b151c2b |
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
|
|
|
b151c2b |
id S1751434Ab1K1Jbl (ORCPT <rfc822;linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
|
|
|
b151c2b |
Mon, 28 Nov 2011 04:31:41 -0500
|
|
|
b151c2b |
Original-Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
|
|
|
b151c2b |
by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAS9VSak003418
|
|
|
b151c2b |
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
|
|
|
b151c2b |
Mon, 28 Nov 2011 04:31:28 -0500
|
|
|
b151c2b |
Original-Received: from localhost (vpn1-4-194.ams2.redhat.com [10.36.4.194])
|
|
|
b151c2b |
by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAS9VQNG013260;
|
|
|
b151c2b |
Mon, 28 Nov 2011 04:31:27 -0500
|
|
|
b151c2b |
Content-Disposition: inline
|
|
|
b151c2b |
In-Reply-To: <20111128092308.GB2372-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
|
|
b151c2b |
User-Agent: Mutt/1.5.20 (2009-12-10)
|
|
|
b151c2b |
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
|
|
|
b151c2b |
Original-Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
|
|
b151c2b |
Precedence: bulk
|
|
|
b151c2b |
List-ID: <linux-wireless.vger.kernel.org>
|
|
|
b151c2b |
X-Mailing-List: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
|
|
b151c2b |
Xref: news.gmane.org gmane.linux.kernel.wireless.general:81657
|
|
|
b151c2b |
Archived-At: <http://permalink.gmane.org/gmane.linux.kernel.wireless.general/81657>
|
|
|
b151c2b |
|
|
|
b151c2b |
rtl_lps_leave can be called from interrupt context, so we have to
|
|
|
b151c2b |
disable interrupts when taking lps_lock.
|
|
|
b151c2b |
|
|
|
b151c2b |
Below is full lockdep info about deadlock:
|
|
|
b151c2b |
|
|
|
b151c2b |
[ 93.815269] =================================
|
|
|
b151c2b |
[ 93.815390] [ INFO: inconsistent lock state ]
|
|
|
b151c2b |
[ 93.815472] 2.6.41.1-3.offch.fc15.x86_64.debug #1
|
|
|
b151c2b |
[ 93.815556] ---------------------------------
|
|
|
b151c2b |
[ 93.815635] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
|
|
|
b151c2b |
[ 93.815743] swapper/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
|
|
|
b151c2b |
[ 93.815832] (&(&rtlpriv->locks.lps_lock)->rlock){+.?...}, at: [<ffffffffa025dad6>] rtl_lps_leave+0x26/0x103 [rtlwifi]
|
|
|
b151c2b |
[ 93.815947] {SOFTIRQ-ON-W} state was registered at:
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8108e10d>] __lock_acquire+0x369/0xd0c
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8108efb3>] lock_acquire+0xf3/0x13e
|
|
|
b151c2b |
[ 93.815947] [<ffffffff814e981d>] _raw_spin_lock+0x45/0x79
|
|
|
b151c2b |
[ 93.815947] [<ffffffffa025de34>] rtl_swlps_rf_awake+0x5a/0x76 [rtlwifi]
|
|
|
b151c2b |
[ 93.815947] [<ffffffffa025aec0>] rtl_op_config+0x12a/0x32a [rtlwifi]
|
|
|
b151c2b |
[ 93.815947] [<ffffffffa01d614b>] ieee80211_hw_config+0x124/0x129 [mac80211]
|
|
|
b151c2b |
[ 93.815947] [<ffffffffa01e0af3>] ieee80211_dynamic_ps_disable_work+0x32/0x47 [mac80211]
|
|
|
b151c2b |
[ 93.815947] [<ffffffff81075aa5>] process_one_work+0x205/0x3e7
|
|
|
b151c2b |
[ 93.815947] [<ffffffff81076753>] worker_thread+0xda/0x15d
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8107a119>] kthread+0xa8/0xb0
|
|
|
b151c2b |
[ 93.815947] [<ffffffff814f3184>] kernel_thread_helper+0x4/0x10
|
|
|
b151c2b |
[ 93.815947] irq event stamp: 547822
|
|
|
b151c2b |
[ 93.815947] hardirqs last enabled at (547822): [<ffffffff814ea1a7>] _raw_spin_unlock_irqrestore+0x45/0x61
|
|
|
b151c2b |
[ 93.815947] hardirqs last disabled at (547821): [<ffffffff814e9987>] _raw_spin_lock_irqsave+0x22/0x8e
|
|
|
b151c2b |
[ 93.815947] softirqs last enabled at (547790): [<ffffffff810623ed>] _local_bh_enable+0x13/0x15
|
|
|
b151c2b |
[ 93.815947] softirqs last disabled at (547791): [<ffffffff814f327c>] call_softirq+0x1c/0x30
|
|
|
b151c2b |
[ 93.815947]
|
|
|
b151c2b |
[ 93.815947] other info that might help us debug this:
|
|
|
b151c2b |
[ 93.815947] Possible unsafe locking scenario:
|
|
|
b151c2b |
[ 93.815947]
|
|
|
b151c2b |
[ 93.815947] CPU0
|
|
|
b151c2b |
[ 93.815947] ----
|
|
|
b151c2b |
[ 93.815947] lock(&(&rtlpriv->locks.lps_lock)->rlock);
|
|
|
b151c2b |
[ 93.815947] <Interrupt>
|
|
|
b151c2b |
[ 93.815947] lock(&(&rtlpriv->locks.lps_lock)->rlock);
|
|
|
b151c2b |
[ 93.815947]
|
|
|
b151c2b |
[ 93.815947] *** DEADLOCK ***
|
|
|
b151c2b |
[ 93.815947]
|
|
|
b151c2b |
[ 93.815947] no locks held by swapper/0.
|
|
|
b151c2b |
[ 93.815947]
|
|
|
b151c2b |
[ 93.815947] stack backtrace:
|
|
|
b151c2b |
[ 93.815947] Pid: 0, comm: swapper Not tainted 2.6.41.1-3.offch.fc15.x86_64.debug #1
|
|
|
b151c2b |
[ 93.815947] Call Trace:
|
|
|
b151c2b |
[ 93.815947] <IRQ> [<ffffffff814dfd00>] print_usage_bug+0x1e7/0x1f8
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8101a849>] ? save_stack_trace+0x2c/0x49
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8108d55c>] ? print_irq_inversion_bug.part.18+0x1a0/0x1a0
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8108dc8a>] mark_lock+0x106/0x220
|
|
|
b151c2b |
[ 93.815947] [<ffffffff8108e099>] __lock_acquire+0x2f5/0xd0c
|
|
|
b151c2b |
[ 93.815947] [<ffffffff810152af>] ? native_sched_clock+0x34/0x36
|
|
|
b151c2b |
[ 93.830125] [<ffffffff810152ba>] ? sched_clock+0x9/0xd
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81080181>] ? sched_clock_local+0x12/0x75
|
|
|
b151c2b |
[ 93.830125] [<ffffffffa025dad6>] ? rtl_lps_leave+0x26/0x103 [rtlwifi]
|
|
|
b151c2b |
[ 93.830125] [<ffffffff8108efb3>] lock_acquire+0xf3/0x13e
|
|
|
b151c2b |
[ 93.830125] [<ffffffffa025dad6>] ? rtl_lps_leave+0x26/0x103 [rtlwifi]
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814e981d>] _raw_spin_lock+0x45/0x79
|
|
|
b151c2b |
[ 93.830125] [<ffffffffa025dad6>] ? rtl_lps_leave+0x26/0x103 [rtlwifi]
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81422467>] ? skb_dequeue+0x62/0x6d
|
|
|
b151c2b |
[ 93.830125] [<ffffffffa025dad6>] rtl_lps_leave+0x26/0x103 [rtlwifi]
|
|
|
b151c2b |
[ 93.830125] [<ffffffffa025f677>] _rtl_pci_ips_leave_tasklet+0xe/0x10 [rtlwifi]
|
|
|
b151c2b |
[ 93.830125] [<ffffffff8106281f>] tasklet_action+0x8d/0xee
|
|
|
b151c2b |
[ 93.830125] [<ffffffff810629ce>] __do_softirq+0x112/0x25a
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814f327c>] call_softirq+0x1c/0x30
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81010bf6>] do_softirq+0x4b/0xa1
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81062d7d>] irq_exit+0x5d/0xcf
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814f3b7e>] do_IRQ+0x8e/0xa5
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814ea533>] common_interrupt+0x73/0x73
|
|
|
b151c2b |
[ 93.830125] <EOI> [<ffffffff8108b825>] ? trace_hardirqs_off+0xd/0xf
|
|
|
b151c2b |
[ 93.830125] [<ffffffff812bb6d5>] ? intel_idle+0xe5/0x10c
|
|
|
b151c2b |
[ 93.830125] [<ffffffff812bb6d1>] ? intel_idle+0xe1/0x10c
|
|
|
b151c2b |
[ 93.830125] [<ffffffff813f8d5e>] cpuidle_idle_call+0x11c/0x1fe
|
|
|
b151c2b |
[ 93.830125] [<ffffffff8100e2ef>] cpu_idle+0xab/0x101
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814c6373>] rest_init+0xd7/0xde
|
|
|
b151c2b |
[ 93.830125] [<ffffffff814c629c>] ? csum_partial_copy_generic+0x16c/0x16c
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81d4bbb0>] start_kernel+0x3dd/0x3ea
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81d4b2c4>] x86_64_start_reservations+0xaf/0xb3
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81d4b140>] ? early_idt_handlers+0x140/0x140
|
|
|
b151c2b |
[ 93.830125] [<ffffffff81d4b3ca>] x86_64_start_kernel+0x102/0x111
|
|
|
b151c2b |
|
|
|
b151c2b |
Resolves:
|
|
|
b151c2b |
https://bugzilla.redhat.com/show_bug.cgi?id=755154
|
|
|
b151c2b |
|
|
|
b151c2b |
Reported-by: vjain02-9geRo0GdX4mblYp+tMVdN4dd74u8MsAO@public.gmane.org
|
|
|
b151c2b |
Reported-and-tested-by: Oliver Paukstadt <pstadt-J4iCZ0GWXu6s5+MaFmuW5Q@public.gmane.org>
|
|
|
b151c2b |
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
|
|
b151c2b |
Acked-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
|
|
|
b151c2b |
Signed-off-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
|
|
|
b151c2b |
---
|
|
|
b151c2b |
v1 -> v2: add bug report reference
|
|
|
b151c2b |
|
|
|
b151c2b |
drivers/net/wireless/rtlwifi/ps.c | 17 +++++++++--------
|
|
|
b151c2b |
1 files changed, 9 insertions(+), 8 deletions(-)
|
|
|
b151c2b |
|
|
|
b151c2b |
diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c
|
|
|
b151c2b |
index db52628..55c8e50 100644
|
|
|
b151c2b |
--- a/drivers/net/wireless/rtlwifi/ps.c
|
|
|
b151c2b |
+++ b/drivers/net/wireless/rtlwifi/ps.c
|
|
|
b151c2b |
@@ -395,7 +395,7 @@ void rtl_lps_enter(struct ieee80211_hw *hw)
|
|
|
b151c2b |
if (mac->link_state != MAC80211_LINKED)
|
|
|
b151c2b |
return;
|
|
|
b151c2b |
|
|
|
b151c2b |
- spin_lock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_lock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
|
|
|
b151c2b |
/* Idle for a while if we connect to AP a while ago. */
|
|
|
b151c2b |
if (mac->cnt_after_linked >= 2) {
|
|
|
b151c2b |
@@ -407,7 +407,7 @@ void rtl_lps_enter(struct ieee80211_hw *hw)
|
|
|
b151c2b |
}
|
|
|
b151c2b |
}
|
|
|
b151c2b |
|
|
|
b151c2b |
- spin_unlock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_unlock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
}
|
|
|
b151c2b |
|
|
|
b151c2b |
/*Leave the leisure power save mode.*/
|
|
|
b151c2b |
@@ -416,8 +416,9 @@ void rtl_lps_leave(struct ieee80211_hw *hw)
|
|
|
b151c2b |
struct rtl_priv *rtlpriv = rtl_priv(hw);
|
|
|
b151c2b |
struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
|
|
|
b151c2b |
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
|
|
|
b151c2b |
+ unsigned long flags;
|
|
|
b151c2b |
|
|
|
b151c2b |
- spin_lock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_lock_irqsave(&rtlpriv->locks.lps_lock, flags);
|
|
|
b151c2b |
|
|
|
b151c2b |
if (ppsc->fwctrl_lps) {
|
|
|
b151c2b |
if (ppsc->dot11_psmode != EACTIVE) {
|
|
|
b151c2b |
@@ -438,7 +439,7 @@ void rtl_lps_leave(struct ieee80211_hw *hw)
|
|
|
b151c2b |
rtl_lps_set_psmode(hw, EACTIVE);
|
|
|
b151c2b |
}
|
|
|
b151c2b |
}
|
|
|
b151c2b |
- spin_unlock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flags);
|
|
|
b151c2b |
}
|
|
|
b151c2b |
|
|
|
b151c2b |
/* For sw LPS*/
|
|
|
b151c2b |
@@ -539,9 +540,9 @@ void rtl_swlps_rf_awake(struct ieee80211_hw *hw)
|
|
|
b151c2b |
RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM);
|
|
|
b151c2b |
}
|
|
|
b151c2b |
|
|
|
b151c2b |
- spin_lock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_lock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
rtl_ps_set_rf_state(hw, ERFON, RF_CHANGE_BY_PS);
|
|
|
b151c2b |
- spin_unlock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_unlock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
}
|
|
|
b151c2b |
|
|
|
b151c2b |
void rtl_swlps_rfon_wq_callback(void *data)
|
|
|
b151c2b |
@@ -574,9 +575,9 @@ void rtl_swlps_rf_sleep(struct ieee80211_hw *hw)
|
|
|
b151c2b |
if (rtlpriv->link_info.busytraffic)
|
|
|
b151c2b |
return;
|
|
|
b151c2b |
|
|
|
b151c2b |
- spin_lock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_lock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
rtl_ps_set_rf_state(hw, ERFSLEEP, RF_CHANGE_BY_PS);
|
|
|
b151c2b |
- spin_unlock(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
+ spin_unlock_irq(&rtlpriv->locks.lps_lock);
|
|
|
b151c2b |
|
|
|
b151c2b |
if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM &&
|
|
|
b151c2b |
!RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) {
|
|
|
b151c2b |
--
|
|
|
b151c2b |
1.7.1
|
|
|
b151c2b |
|
|
|
b151c2b |
--
|
|
|
b151c2b |
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
|
|
|
b151c2b |
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
|
|
|
b151c2b |
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
|
|
b151c2b |
|