|
 |
8be4430 |
From: Sergei Zviagintsev <sergei@s15v.net>
|
|
|
8be4430 |
Date: Wed, 17 Jun 2015 19:33:26 +0300
|
|
|
8be4430 |
Subject: [PATCH] selftests/kdbus: remove useless initializations from
|
|
|
8be4430 |
kdbus_clone_userns_test()
|
|
|
8be4430 |
|
|
|
8be4430 |
Do not initialize efd, unpriv_conn_id, userns_conn_id and monitor. These
|
|
|
8be4430 |
vars are assigned to values later in code while initial values are never
|
|
|
8be4430 |
used.
|
|
|
8be4430 |
|
|
|
8be4430 |
Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
|
|
|
8be4430 |
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
|
|
|
8be4430 |
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
|
8be4430 |
---
|
|
|
8be4430 |
tools/testing/selftests/kdbus/test-metadata-ns.c | 9 +++------
|
|
|
8be4430 |
1 file changed, 3 insertions(+), 6 deletions(-)
|
|
|
8be4430 |
|
|
|
8be4430 |
diff --git a/tools/testing/selftests/kdbus/test-metadata-ns.c b/tools/testing/selftests/kdbus/test-metadata-ns.c
|
|
|
8be4430 |
index 2cb1d4d2a5be..ccdfae06922b 100644
|
|
|
8be4430 |
--- a/tools/testing/selftests/kdbus/test-metadata-ns.c
|
|
|
8be4430 |
+++ b/tools/testing/selftests/kdbus/test-metadata-ns.c
|
|
|
8be4430 |
@@ -281,16 +281,13 @@ out:
|
|
|
8be4430 |
static int kdbus_clone_userns_test(const char *bus,
|
|
|
8be4430 |
struct kdbus_conn *conn)
|
|
|
8be4430 |
{
|
|
|
8be4430 |
- int ret;
|
|
|
8be4430 |
- int status;
|
|
|
8be4430 |
- int efd = -1;
|
|
|
8be4430 |
+ int ret, status, efd;
|
|
|
8be4430 |
pid_t pid, ppid;
|
|
|
8be4430 |
- uint64_t unpriv_conn_id = 0;
|
|
|
8be4430 |
- uint64_t userns_conn_id = 0;
|
|
|
8be4430 |
+ uint64_t unpriv_conn_id, userns_conn_id;
|
|
|
8be4430 |
struct kdbus_msg *msg;
|
|
|
8be4430 |
const struct kdbus_item *item;
|
|
|
8be4430 |
struct kdbus_pids expected_pids;
|
|
|
8be4430 |
- struct kdbus_conn *monitor = NULL;
|
|
|
8be4430 |
+ struct kdbus_conn *monitor;
|
|
|
8be4430 |
|
|
|
8be4430 |
kdbus_printf("STARTING TEST 'metadata-ns'.\n");
|
|
|
8be4430 |
|