|
 |
4594824 |
From mboxrd@z Thu Jan 1 00:00:00 1970
|
|
|
4594824 |
Return-Path: <SRS0=rUXN=XZ=vger.kernel.org=linux-kernel-owner@kernel.org>
|
|
|
4594824 |
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
|
|
|
4594824 |
aws-us-west-2-korg-lkml-1.web.codeaurora.org
|
|
|
4594824 |
X-Spam-Level:
|
|
|
4594824 |
X-Spam-Status: No, score=-9.4 required=3.0 tests=DKIM_ADSP_CUSTOM_MED,
|
|
|
4594824 |
DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
|
|
|
4594824 |
HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
|
|
|
4594824 |
SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no
|
|
|
4594824 |
version=3.4.0
|
|
|
4594824 |
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
|
|
|
4594824 |
by smtp.lore.kernel.org (Postfix) with ESMTP id C92DFC4360C
|
|
|
4594824 |
for <linux-kernel@archiver.kernel.org>; Mon, 30 Sep 2019 03:46:18 +0000 (UTC)
|
|
|
4594824 |
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
|
|
|
4594824 |
by mail.kernel.org (Postfix) with ESMTP id 9B3EE20863
|
|
|
4594824 |
for <linux-kernel@archiver.kernel.org>; Mon, 30 Sep 2019 03:46:18 +0000 (UTC)
|
|
|
4594824 |
Authentication-Results: mail.kernel.org;
|
|
|
4594824 |
dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MxIuKg6c"
|
|
|
4594824 |
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
|
|
4594824 |
id S1729507AbfI3DqO (ORCPT
|
|
|
4594824 |
<rfc822;linux-kernel@archiver.kernel.org>);
|
|
|
4594824 |
Sun, 29 Sep 2019 23:46:14 -0400
|
|
|
4594824 |
Received: from mail-io1-f66.google.com ([209.85.166.66]:35210 "EHLO
|
|
|
4594824 |
mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
|
|
|
4594824 |
with ESMTP id S1726360AbfI3DqO (ORCPT
|
|
|
4594824 |
<rfc822;linux-kernel@vger.kernel.org>);
|
|
|
4594824 |
Sun, 29 Sep 2019 23:46:14 -0400
|
|
|
4594824 |
Received: by mail-io1-f66.google.com with SMTP id q10so34551005iop.2;
|
|
|
4594824 |
Sun, 29 Sep 2019 20:46:13 -0700 (PDT)
|
|
|
4594824 |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
|
|
4594824 |
d=gmail.com; s=20161025;
|
|
|
4594824 |
h=from:to:cc:subject:date:message-id;
|
|
|
4594824 |
bh=CSb8gKQFW+56QuRhWd4MVB/962Fvkd5QK+eXub6cDmE=;
|
|
|
4594824 |
b=MxIuKg6cc7vmVBU35srXcQltSjWfzAQElpoZgAlV4IAegsPDx906fw8dUzLriT4baK
|
|
|
4594824 |
fBI64z8uZ5KseshsQzqi5BVxbpb6LulT2mykTJq/pUGdaGaks60BJexhUMeSfNyaRrSw
|
|
|
4594824 |
jfZjzE0QCgGBSOYA5ovK/1GcPySgrArlnITUbkIzeObOLmetAQSgfIuEmD3QDkMSGBgo
|
|
|
4594824 |
vEJ/PmjTcPWD8rCJc/XKg+rTU7wVeK/VTlmL6KxFvwOwenU6A7VjSjSUIUuRLyY4DrMN
|
|
|
4594824 |
cYq+KCSyF9sfI4q5YOSUdQ0T1s5RpFvx8+sTAS78lMKQQqGwvVqM05jR/nbSHSEltzPy
|
|
|
4594824 |
JHUg==
|
|
|
4594824 |
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
|
|
4594824 |
d=1e100.net; s=20161025;
|
|
|
4594824 |
h=x-gm-message-state:from:to:cc:subject:date:message-id;
|
|
|
4594824 |
bh=CSb8gKQFW+56QuRhWd4MVB/962Fvkd5QK+eXub6cDmE=;
|
|
|
4594824 |
b=bNFNL53TYUcz8nZsGgBlk1ntXRHaszBkoC9NrxFaR2ySpC2T71F+IlYFFeTyhVcLUW
|
|
|
4594824 |
F9WAID6IG3m1OQEoyR0Hdnz5xkY22u1wVHTx4QWpil9NKsfyBmzVhoAlGmKRvgt1nso3
|
|
|
4594824 |
2XJXPzoemp9nWy/y8GTqhFO+OofhRcwJdijhsRitU6J8z5xb0wHCwplFwRGZjRZI9uP7
|
|
|
4594824 |
/+81BUj3Dhsz4jPbMTT9LrFVvqszsTkzTReqyp6sKnxMKhpfhUQwSX9fRF++E5EBEc3C
|
|
|
4594824 |
X8uCSxmhI2UraYuwaASHqGk+nvpVTkUaNNaaz9J8HNMi0dq7N1xua7AT65rICXDfBvkO
|
|
|
4594824 |
Sdnw==
|
|
|
4594824 |
X-Gm-Message-State: APjAAAWroOwvHW6SHGBmhWef7X7KS1ypb0sPG9ZHVxp4GIygokLX/WFb
|
|
|
4594824 |
1azxubBLqnwY/4ic3z+D784=
|
|
|
4594824 |
X-Google-Smtp-Source: APXvYqzx55nalXFB8YovlLh9qfXLKQ5njGsXu/sw9z0VR74i+3mZlYSj//BvPzrbGIA2nI5KDHHqbw==
|
|
|
4594824 |
X-Received: by 2002:a92:844b:: with SMTP id l72mr17962867ild.275.1569815173041;
|
|
|
4594824 |
Sun, 29 Sep 2019 20:46:13 -0700 (PDT)
|
|
|
4594824 |
Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54])
|
|
|
4594824 |
by smtp.googlemail.com with ESMTPSA id w16sm5283677ilc.62.2019.09.29.20.46.12
|
|
|
4594824 |
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
|
|
|
4594824 |
Sun, 29 Sep 2019 20:46:12 -0700 (PDT)
|
|
|
4594824 |
From: Navid Emamdoost <navid.emamdoost@gmail.com>
|
|
|
4594824 |
Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu,
|
|
|
4594824 |
Navid Emamdoost <navid.emamdoost@gmail.com>,
|
|
|
4594824 |
Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
|
|
|
4594824 |
linux-kernel@vger.kernel.org
|
|
|
4594824 |
Subject: [PATCH] spi: lpspi: fix memory leak in fsl_lpspi_probe
|
|
|
4594824 |
Date: Sun, 29 Sep 2019 22:46:01 -0500
|
|
|
4594824 |
Message-Id: <20190930034602.1467-1-navid.emamdoost@gmail.com>
|
|
|
4594824 |
X-Mailer: git-send-email 2.17.1
|
|
|
4594824 |
To: unlisted-recipients:; (no To-header on input)
|
|
|
4594824 |
Sender: linux-kernel-owner@vger.kernel.org
|
|
|
4594824 |
Precedence: bulk
|
|
|
4594824 |
List-ID: <linux-kernel.vger.kernel.org>
|
|
|
4594824 |
X-Mailing-List: linux-kernel@vger.kernel.org
|
|
|
4594824 |
Archived-At: <https://lore.kernel.org/lkml/20190930034602.1467-1-navid.emamdoost@gmail.com/>
|
|
|
4594824 |
List-Archive: <https://lore.kernel.org/lkml/>
|
|
|
4594824 |
List-Post: <mailto:linux-kernel@vger.kernel.org>
|
|
|
4594824 |
|
|
|
4594824 |
In fsl_lpspi_probe an SPI controller is allocated either via
|
|
|
4594824 |
spi_alloc_slave or spi_alloc_master. In all but one error cases this
|
|
|
4594824 |
controller is put by going to error handling code. This commit fixes the
|
|
|
4594824 |
case when pm_runtime_get_sync fails and it should go to the error
|
|
|
4594824 |
handling path.
|
|
|
4594824 |
|
|
|
4594824 |
Fixes: 944c01a889d9 ("spi: lpspi: enable runtime pm for lpspi")
|
|
|
4594824 |
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
|
|
|
4594824 |
---
|
|
|
4594824 |
drivers/spi/spi-fsl-lpspi.c | 2 +-
|
|
|
4594824 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
4594824 |
|
|
|
4594824 |
diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
|
|
|
4594824 |
index d08e9324140e..3528ed5eea9b 100644
|
|
|
4594824 |
--- a/drivers/spi/spi-fsl-lpspi.c
|
|
|
4594824 |
+++ b/drivers/spi/spi-fsl-lpspi.c
|
|
|
4594824 |
@@ -938,7 +938,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
|
|
|
4594824 |
ret = pm_runtime_get_sync(fsl_lpspi->dev);
|
|
|
4594824 |
if (ret < 0) {
|
|
|
4594824 |
dev_err(fsl_lpspi->dev, "failed to enable clock\n");
|
|
|
4594824 |
- return ret;
|
|
|
4594824 |
+ goto out_controller_put;
|
|
|
4594824 |
}
|
|
|
4594824 |
|
|
|
4594824 |
temp = readl(fsl_lpspi->base + IMX7ULP_PARAM);
|
|
|
4594824 |
--
|
|
|
4594824 |
2.17.1
|
|
|
4594824 |
|
|
|
4594824 |
|